InputSensor removal ready for review (was: The Inbox: Kernel-dtl.985.mcz)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

InputSensor removal ready for review (was: The Inbox: Kernel-dtl.985.mcz)

David T. Lewis
This completes the removal of InputSensor, which is replaced by EventSensor.

I would appreciate another set of eyes on this, but if there are no issues
I will move it to trunk some time soon.

Some update maps will be needed as well as a minor update to package System,
but aside from that the changes should now be complete.

To test from the inbox, load Kernel-dtl.981 through Kernel-dtl.985 in sequence.
Class initialization methods should take care of the conversion.

Dave


On Sat, Jan 30, 2016 at 07:53:41PM +0000, [hidden email] wrote:

> David T. Lewis uploaded a new version of Kernel to project The Inbox:
> http://source.squeak.org/inbox/Kernel-dtl.985.mcz
>
> ==================== Summary ====================
>
> Name: Kernel-dtl.985
> Author: dtl
> Time: 30 January 2016, 2:53:37.508491 pm
> UUID: 14804760-466d-4af1-a5f8-ad60b34fdc1d
> Ancestors: Kernel-dtl.984
>
> EventSensor replaces InputSensor, update class and method comments.
>
> =============== Diff against Kernel-dtl.984 ===============

Reply | Threaded
Open this post in threaded view
|

Re: InputSensor removal ready for review (was: The Inbox: Kernel-dtl.985.mcz)

Chris Muller-3
> I would appreciate another set of eyes on this, but if there are no issues
> I will move it to trunk some time soon.

When you do that, it would be appreciated if you will move all the
ancestor versions, too.  This facilitates our code repository model to
be complete and indexable when loaded into one big Magma DB.

Reply | Threaded
Open this post in threaded view
|

Re: InputSensor removal ready for review (was: The Inbox: Kernel-dtl.985.mcz)

David T. Lewis
On Sun, Jan 31, 2016 at 02:56:26PM -0600, Chris Muller wrote:
> > I would appreciate another set of eyes on this, but if there are no issues
> > I will move it to trunk some time soon.
>
> When you do that, it would be appreciated if you will move all the
> ancestor versions, too.  This facilitates our code repository model to
> be complete and indexable when loaded into one big Magma DB.

Yes I will do that. I am a packrat by nature, and I never throw anything away ;-)

Dave