Is it dangerous to ignore Dangerous?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Is it dangerous to ignore Dangerous?

David T. Lewis
Following the removal of Classbuilder>>format:variable:words:pointers:weak:
I had planned to remove a reference to that method (and one or two others)
in MethodFinder>>noteDangerous. But to my surprise, I see that the set of
Dangerous methods in MethodFinder is completely unused (except by a method
that is itself unused).

How is this even possible? I had assumed that the Dangerous methods were
important to the fundamental functioning of MethodFinder, which explores
the system looking for methods that produce results matching some example
pattern. How could this possibly be working if we do not pay attention to
the set of methods that are too dangerous to be invoked by the method finder?

This is not a new situation, I looked at a Squeak 3.6 image and see the
same thing.

Dave


Reply | Threaded
Open this post in threaded view
|

Re: Is it dangerous to ignore Dangerous?

Karl Ramberg
Same in Squeak 2.8.
Dangerous is nil and not accessed.

Best,

Karl

On Wed, Aug 19, 2020 at 9:41 PM David T. Lewis <[hidden email]> wrote:
Following the removal of Classbuilder>>format:variable:words:pointers:weak:
I had planned to remove a reference to that method (and one or two others)
in MethodFinder>>noteDangerous. But to my surprise, I see that the set of
Dangerous methods in MethodFinder is completely unused (except by a method
that is itself unused).

How is this even possible? I had assumed that the Dangerous methods were
important to the fundamental functioning of MethodFinder, which explores
the system looking for methods that produce results matching some example
pattern. How could this possibly be working if we do not pay attention to
the set of methods that are too dangerous to be invoked by the method finder?

This is not a new situation, I looked at a Squeak 3.6 image and see the
same thing.

Dave




Reply | Threaded
Open this post in threaded view
|

Re: Is it dangerous to ignore Dangerous?

codefrau
Not sure why the methods in noteDangerous are not used. We could ask Ted, who wrote it initially. CC'ing.

It still works because MethodFinder only tries methods understood by the objects you give as an example. So as long as you don't try it on "dangerous" classes it's going to be fine.

- Vanessa -

On Wed, Aug 19, 2020 at 1:22 PM karl ramberg <[hidden email]> wrote:
Same in Squeak 2.8.
Dangerous is nil and not accessed.

Best,

Karl

On Wed, Aug 19, 2020 at 9:41 PM David T. Lewis <[hidden email]> wrote:
Following the removal of Classbuilder>>format:variable:words:pointers:weak:
I had planned to remove a reference to that method (and one or two others)
in MethodFinder>>noteDangerous. But to my surprise, I see that the set of
Dangerous methods in MethodFinder is completely unused (except by a method
that is itself unused).

How is this even possible? I had assumed that the Dangerous methods were
important to the fundamental functioning of MethodFinder, which explores
the system looking for methods that produce results matching some example
pattern. How could this possibly be working if we do not pay attention to
the set of methods that are too dangerous to be invoked by the method finder?

This is not a new situation, I looked at a Squeak 3.6 image and see the
same thing.

Dave