Issue 115 in metacello: Invalid method construction by toolbox

Status: Accepted
Owner: [hidden email]
Labels: Type-Defect Priority-Medium Product-Core Version-1.0-beta.28  
Milestone-1.0

New issue 115 by [hidden email]: Invalid method construction by toolbox
http://code.google.com/p/metacello/issues/detail?id=115

 From Alexandre:

Here is a simple scenario:
1 - Load squeaksource.com/Spy
2 - Add a version using the toolbox (or +Version). I get a DNU  
ByteString>>projectSpec
3 - When I manually inspect the method, I can see the problem:
        ConfigurationOfSpy>>version122: spec
                <version: '1.22' imports: #('default' )>
                ...
                spec
                        project: 'MemoryMonitor' ;
                        project: 'Merlin' with: '1.0';
                        project: 'Mondrian' with: '2.54';
                        project: 'HealthReportProducer' with: '1.3'.
                ...
4 - The baseline contains:
                ...
                spec project: 'MemoryMonitor' with: [
                                spec
                                        className: 'ConfigurationOfMemoryMonitor';
                                        loads: #('default' );
                                        file: 'ConfigurationOfMemoryMonitor';
                                        repository: 'http://www.squeaksource.com/MemoryMonitor'
                        ].
                ...
5 - "ConfigurationOfMemoryMonitor project currentVersion" gives me " 1.0.3  
[ConfigurationOfMemoryMonitor]"

see http://forum.world.st/ByteString-gt-gt-projectSpec-td3324435.html for  
additional details

Updates:
        Labels: -Product-Core Product-ToolBox

Comment #1 on issue 115 by [hidden email]: Invalid method construction  
by toolbox
http://code.google.com/p/metacello/issues/detail?id=115

(No comment was entered for this change.)

Comment #2 on issue 115 by [hidden email]: Invalid method  
construction by toolbox
http://code.google.com/p/metacello/issues/detail?id=115

I can confirm this.

Form the squeakSource Configuration, when adding a new Verison via the  
ToolBox,
it instantly chokes on that error:

...
spec for: #'common' do: [
                spec blessing: #'development'.
                spec description: 'Pick up Gerhard Obermanns changes.'.
                spec author: 'topa'.
                spec timestamp: '3/15/2011 16:14'.
                spec
                        project: 'Seaside Extras' ;
                        project: 'Magritte2 Seaside' .
                spec
                       " --  HERE the DNU happens -- "
                        package: 'SqueakSource-Core' with: 'SqueakSource-Core-topa.15';
                        package: 'SqueakSource-Issues' with: 'SqueakSource-Issues-obi.6';
...

I suspect the spec project: 'Bla'. call immediately preceding the spec  
package:with: call.
The specs own project is overwritten.

This does not happen, when it it looks like this:

...
spec for: #'common' do: [
                spec blessing: #'development'.
                spec description: 'Pick up Gerhard Obermanns changes.'.
                spec author: 'topa'.
                spec timestamp: '3/15/2011 16:14'.
                spec
                        project: 'Seaside Extras' with: '3.0.4';
                        project: 'Magritte2 Seaside' with: '2.0.6'.
                spec
                        package: 'SqueakSource-Core' with: 'SqueakSource-Core-topa.15';
                        package: 'SqueakSource-Issues' with: 'SqueakSource-Issues-obi.6';
...

Note the  replacement of project:  with project:with:

I bumped into this issues many many times. It would be cool to address it

Alexandre


On 15 Mar 2011, at 12:24, [hidden email] wrote:

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Updates:
        Labels: -Milestone-1.0 Milestone-1.0-beta.28.3.2

Comment #3 on issue 115 by [hidden email]: Invalid method construction  
by toolbox
http://code.google.com/p/metacello/issues/detail?id=115

(No comment was entered for this change.)

Comment #4 on issue 115 by [hidden email]: Invalid method construction  
by toolbox
http://code.google.com/p/metacello/issues/detail?id=115

initial cut in:

Name: Metacello-Core-dkh.461
Author: dkh
Time: 14 March 2011, 12:08:39 pm
UUID: d17ee1bd-edaa-48ff-9f68-f7e0f0bda98e
Ancestors: Metacello-Core-DaleHenrichs.460

Updates:
        Status: Fixed
        Labels: Fixed-1.0-beta.29

Comment #5 on issue 115 by [hidden email]: Invalid method construction  
by toolbox
http://code.google.com/p/metacello/issues/detail?id=115

tests included in:

Name: Metacello-TestsMC-dkh.145
Author: dkh
Time: 22 March 2011, 5:07:56 pm
UUID: 836e42f0-17f2-4e28-a283-dd1c1e84fd0c
Ancestors: Metacello-TestsMC-dkh.144

spec project: 'cc'.
spce project: 'cc' with: ''.

are both alowed although they will result in validation errors