Issue 119 in metacello: leading trailing spaces in spec names should be flagged as input errors

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 119 in metacello: leading trailing spaces in spec names should be flagged as input errors

metacello
Status: Accepted
Owner: [hidden email]
Labels: Type-Defect Priority-Medium Product-Core Milestone-1.0

New issue 119 by [hidden email]: leading trailing spaces in spec names  
should be flagged as input errors
http://code.google.com/p/metacello/issues/detail?id=119

see http://forum.world.st/trailing-space-in-package-name-td3338447.html

Reply | Threaded
Open this post in threaded view
|

Re: Issue 119 in metacello: leading trailing spaces in spec names should be flagged as input errors

metacello
Updates:
        Labels: -Milestone-1.0 Milestone-1.0-beta.32

Comment #1 on issue 119 by [hidden email]: leading trailing spaces  
in spec names should be flagged as input errors
http://code.google.com/p/metacello/issues/detail?id=119

(No comment was entered for this change.)

Reply | Threaded
Open this post in threaded view
|

Re: Issue 119 in metacello: leading trailing spaces in spec names should be flagged as input errors

metacello
Updates:
        Status: Fixed
        Labels: Fixed-1.0-beta.32

Comment #2 on issue 119 by [hidden email]: leading trailing spaces  
in spec names should be flagged as input errors
http://code.google.com/p/metacello/issues/detail?id=119

fixed in Metacello 1.0-beta.32 (dkh.668).

Since Issue 119 involves throwing a creation-time error, I needed to solve  
the general problem of what to do when errros occur during version  
creation. Errors that occur during project construction no longer cause a  
halt to the proceedings. Project construction proceeds, however, the  
version with the error is (obviously) not available for use. If on accesses  
such a version, a MetacelloVersionDefinitionError (a kindOf:  
MetacelloVersionDoesNotExistError) that is thrown. If you wrap project  
creation with the following exception handler:
   [ConfigurationOfExample project ]
        on: MetacelloErrorInProjectConstructionNotification
        do: [:ex | ex resume: true ].
   the Error is thrown immediately.

There is also a new error reasonCode (#'versionCreationError') to flag  
these errors for the validator.