Issue 126 in metacello: Morphic-based browser needs t ouse OB-style isActive

Status: Accepted
Owner: [hidden email]
Labels: Type-Defect Priority-Medium Product-Browser

New issue 126 by [hidden email]: Morphic-based browser needs t ouse  
OB-style isActive
http://code.google.com/p/metacello/issues/detail?id=126

I've just gone through list of commands (MetacelloBrowser 1.59 (dkh.257))  
and defined isActive in terms of whether or not the command applies to the  
target, i.e., can't checkpoint dev if no #development version defined...

Morphic menu builder ought to use isActive as well ...

Comment #1 on issue 126 by [hidden email]: Morphic-based browser  
needs t ouse OB-style isActive
http://code.google.com/p/metacello/issues/detail?id=126

Hi Dale!

Can you be a bit more specific on this? isActive is defined on MBCommand  
and heavily overridden.
Are you referring to the button at the top of the browser?

Comment #2 on issue 126 by [hidden email]: Morphic-based browser needs  
t ouse OB-style isActive
http://code.google.com/p/metacello/issues/detail?id=126

In OB the #isActive method is used to control whether or not buttons are  
activated or whether or not a menu item shows up for the selected  
target ... for example, the 'compare to stable' command is useless if there  
is no #stable version defined, so the isActive logic for that command  
answers false if there is no #stable version defined and the menu item only  
shows up in projects that have a #stable version defined ... there are  
several other examples ...

The Morphic menus do not use this logic when constructing the menu and they  
probably should ...