Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

metacello
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Product-Core

New issue 133 by [hidden email]: MetacelloBrowser: Abstract test not  
indicated
http://code.google.com/p/metacello/issues/detail?id=133

At least three test classes for the MetacelloBrowser are
abstract but not declared as such.
The attached  changeset includes the necessary changes.



Attachments:
        MetacelloBrowserAbstractTests.1.cs  811 bytes

Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

metacello

Comment #1 on issue 133 by [hidden email]: MetacelloBrowser:  
Abstract test not indicated
http://code.google.com/p/metacello/issues/detail?id=133

Thanks Tobias,
Now in Version 1.60.1 (296)

Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
In reply to this post by metacello
Now in 1.60.1 (296): Fixed  Issue 133: MetacelloBrowser: Abstract test not indicated.
I also added a test for this.

Thanks Tobias!

Cheers,
Alexandre


On 15 Apr 2011, at 09:19, [hidden email] wrote:

> Status: New
> Owner: ----
> Labels: Type-Defect Priority-Medium Product-Core
>
> New issue 133 by [hidden email]: MetacelloBrowser: Abstract test not indicated
> http://code.google.com/p/metacello/issues/detail?id=133
>
> At least three test classes for the MetacelloBrowser are
> abstract but not declared as such.
> The attached  changeset includes the necessary changes.
>
>
>
> Attachments:
> MetacelloBrowserAbstractTests.1.cs  811 bytes
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Dale Henrichs
On 04/15/2011 08:19 AM, Alexandre Bergel wrote:

> Now in 1.60.1 (296): Fixed  Issue 133: MetacelloBrowser: Abstract test not indicated.
> I also added a test for this.
>
> Thanks Tobias!
>
> Cheers,
> Alexandre
>
>
> On 15 Apr 2011, at 09:19, [hidden email] wrote:
>
>> Status: New
>> Owner: ----
>> Labels: Type-Defect Priority-Medium Product-Core
>>
>> New issue 133 by [hidden email]: MetacelloBrowser: Abstract test not indicated
>> http://code.google.com/p/metacello/issues/detail?id=133
>>
>> At least three test classes for the MetacelloBrowser are
>> abstract but not declared as such.
>> The attached  changeset includes the necessary changes.
>>
>>
>>
>> Attachments:
>> MetacelloBrowserAbstractTests.1.cs  811 bytes
>>
>

Alexandre,

Why are you creating new versions (again)?

I've asked you multiple times to use the open development version and to
not spin off new metacello versions on each commit and here you've gone
off and done it again ...

I thought we had an understanding:(

Dale
Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
> Why are you creating new versions (again)?
>
> I've asked you multiple times to use the open development version and to not spin off new metacello versions on each commit and here you've gone off and done it again ...


There was 1.59, 1.59.1, 1.60. So why not 1.60.1?
I am now working on fixing the issues Tobias raised. I think it makes sense to put all his fixes into 1.60.1. I started with 133, there is 132 and 134 that will come up.
Something wrong with that?

Alexandre

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Dale Henrichs
On 04/15/2011 09:42 AM, Alexandre Bergel wrote:

>> Why are you creating new versions (again)?
>>
>> I've asked you multiple times to use the open development version and to not spin off new metacello versions on each commit and here you've gone off and done it again ...
>
>
> There was 1.59, 1.59.1, 1.60. So why not 1.60.1?
> I am now working on fixing the issues Tobias raised. I think it makes sense to put all his fixes into 1.60.1. I started with 133, there is 132 and 134 that will come up.
> Something wrong with that?
>
> Alexandre
>

Alexandre,

"Is there something wrong with that?", sigh.

Do you recall the many, many, many emails that we have exchanged talking
about working in a single metacello version vs creating a separate
metacello version for each commit?

I have documented the process that I think we should follow and I have
ssaid that I think we should follow that process.

I have asked you to document your process and I have seen nothing.

I have tried to get you to explain why you _need_ to create additional
metacello versions for each unit of work and I have repeatedly asked you
not to do so ...

It is obvious to me that we are not on the same page ... do you think we
should be on the same page?

You keep saying that you can do it "my way" but you don't do it "my way"....

I now think the root cause is that you do not under "Software
versioningg" or you are choosing not to think in terms of "Software
versioning" when thinking of metacello versions ...

Metacello versions are for the consumers of the project, not the
developers of project ... You release a new Metacello version when you
have something that you would like the consumers of the project to use
... you open a version for development and add content to that version
until it is ready for the consumers and then you release the version...
if you find a bug in a previously released version of the project, you
create a point release and release the version ... you make a major
release when there are major changes to the project and you make minor
and point releases when there are less significant changes to a project ...

You are thinking in terms of a paper ... versions are not papers ...
1.58.1 is a branch of 1.58 and is based on the software contained in
1.58 and does not include software/features/fixes from 1.59 ...

Dale
Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
> Do you recall the many, many, many emails that we have exchanged talking about working in a single metacello version vs creating a separate metacello version for each commit?

Yes I do.

> I have asked you to document your process and I have seen nothing.

Easy:
 1 - do your modif (e.g., adding 10 classes and 100 methods, fixing a bug, adding a comment, or simply fixing a typo in a comment)
 2 - run the test, if green then go to 3 else to 1
 3 - commit and add a new version number

This is what Pharo is doing (e.g., 12345, 12346, 12347, ...) and most of the tool that I use (e.g., I use version 5.138.140.0.129428 of Omnigraffle :-)


> I now think the root cause is that you do not under "Software versioningg" or you are choosing not to think in terms of "Software versioning" when thinking of metacello versions ...

I found the wikipedia page long, complicated and non intuitive. But this is my opinion and I do not want to force people to agree with it. Probably that if I have to manage 100 people working on many different branches, I will think about a more sophisticated process. But until then...

> You are thinking in terms of a paper ... versions are not papers ...

:-)

Tobias fixes are important. Very important. They are as important than any other fix. This is what I wanted to gratify this with a version since this is a very important change for the future of MetacelloBrowser. No less important than all the changes that made 1.59 stable.

I will only commit on 1.60.1. We will then discuss when to move to 1.61.

Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Miguel Cobá
In reply to this post by Dale Henrichs
El vie, 15-04-2011 a las 09:01 -0700, Dale Henrichs escribió:
>
> I have asked you to document your process and I have seen nothing.

I don't understand Alexandre's process either. It appear to me that he's
using Metacello as a thin transparent layer over Monticello versions.
That isn't the goal of Metacello.

> Metacello versions are for the consumers of the project, not the
> developers of project ... You release a new Metacello version when you
> have something that you would like the consumers of the project to use
> ... you open a version for development and add content to that version
> until it is ready for the consumers and then you release the version...
> if you find a bug in a previously released version of the project, you
> create a point release and release the version ... you make a major
> release when there are major changes to the project and you make minor
> and point releases when there are less significant changes to a project ...

+1

This is the way I understand software development and software releases.
I think that is also the way most open source projects work.

Cheers
--
Miguel Cobá
http://twitter.com/MiguelCobaMtz
http://miguel.leugim.com.mx



Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Miguel Cobá
In reply to this post by abergel
El vie, 15-04-2011 a las 13:23 -0400, Alexandre Bergel escribió:

> > Do you recall the many, many, many emails that we have exchanged talking about working in a single metacello version vs creating a separate metacello version for each commit?
>
> Yes I do.
>
> > I have asked you to document your process and I have seen nothing.
>
> Easy:
>  1 - do your modif (e.g., adding 10 classes and 100 methods, fixing a bug, adding a comment, or simply fixing a typo in a comment)
>  2 - run the test, if green then go to 3 else to 1
>  3 - commit and add a new version number

In monticello you mean. Because I could just commit the first of three
related changes to the repo. That doesn't mean that I should update the
Metacello configuration to put it available to users. When I have the
other two commits done and commited (monticello has three new versions)
then I do *one* metacello release (encompassing three commits, not that
my users care indeed, it could be thousands).

>
> This is what Pharo is doing (e.g., 12345, 12346, 12347, ...) and most of the tool that I use

> (e.g., I use version 5.138.140.0.129428 of Omnigraffle :-)

No idea what that could even mean to the *end user* (the target for
Metacello)

>
>
> > I now think the root cause is that you do not under "Software versioningg" or you are choosing not to think in terms of "Software versioning" when thinking of metacello versions ...
>
> I found the wikipedia page long, complicated and non intuitive. But this is my opinion and I do not want to force people to agree with it. Probably that if I have to manage 100 people working on many different branches, I will think about a more sophisticated process. But until then...
>
> > You are thinking in terms of a paper ... versions are not papers ...
>
> :-)
>
> Tobias fixes are important. Very important. They are as important than any other fix. This is what I wanted to gratify this with a version since this is a very important change for the future of MetacelloBrowser. No less important than all the changes that made 1.59 stable.

I think that a released version should only have security fixes and
grave bug fixes. What will happen when you have 10 release out there?
Will you update the ten release to include a fix, that is a nightmare
(effectively you're maintaining 10 branches of your code base, no
project can survive that).
 
Regards
--
Miguel Cobá
http://twitter.com/MiguelCobaMtz
http://miguel.leugim.com.mx



Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Dale Henrichs
In reply to this post by abergel
Alexandre,

I agree with Miguel ...

I think that you are using Metacello incorrectly. Until you understand
the ideas behind "Software Versioning" it is difficult for us to have a
meaningful conversation about .... Software versioning....

Metacello versions are aimed at "Software versioning":

   http://en.wikipedia.org/wiki/Software_versioning

and not software "Revision control":

   http://en.wikipedia.org/wiki/Revision_control

There is overlap between the two ideas, but the version name in
Metacello is firmly intended to address the "Software versioning"
problem. Monticello is firmly intended to address the "Revision control"
problem.

There _are_ aspects of Metacello that are aimed at "Revision control,"
so it is very _important_ that you become familiar with _both_ concepts
... otherwise the difficulties in communication that we are having will
only be magnified.

Dale

On 04/15/2011 10:23 AM, Alexandre Bergel wrote:

>> Do you recall the many, many, many emails that we have exchanged talking about working in a single metacello version vs creating a separate metacello version for each commit?
>
> Yes I do.
>
>> I have asked you to document your process and I have seen nothing.
>
> Easy:
>   1 - do your modif (e.g., adding 10 classes and 100 methods, fixing a bug, adding a comment, or simply fixing a typo in a comment)
>   2 - run the test, if green then go to 3 else to 1
>   3 - commit and add a new version number
>
> This is what Pharo is doing (e.g., 12345, 12346, 12347, ...) and most of the tool that I use (e.g., I use version 5.138.140.0.129428 of Omnigraffle :-)
>
>
>> I now think the root cause is that you do not under "Software versioningg" or you are choosing not to think in terms of "Software versioning" when thinking of metacello versions ...
>
> I found the wikipedia page long, complicated and non intuitive. But this is my opinion and I do not want to force people to agree with it. Probably that if I have to manage 100 people working on many different branches, I will think about a more sophisticated process. But until then...
>
>> You are thinking in terms of a paper ... versions are not papers ...
>
> :-)
>
> Tobias fixes are important. Very important. They are as important than any other fix. This is what I wanted to gratify this with a version since this is a very important change for the future of MetacelloBrowser. No less important than all the changes that made 1.59 stable.
>
> I will only commit on 1.60.1. We will then discuss when to move to 1.61.
>
> Alexandre

Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
In reply to this post by Miguel Cobá
I finally got back to my computer earlier than I expected. So, the discussion can be resumed...

> In monticello you mean. Because I could just commit the first of three
> related changes to the repo. That doesn't mean that I should update the
> Metacello configuration to put it available to users. When I have the
> other two commits done and commited (monticello has three new versions)
> then I do *one* metacello release (encompassing three commits, not that
> my users care indeed, it could be thousands).

This is the way you program and I respect this. I use a slightly different way of numbering, and it has worked very well so far. When someone asks to use Mondrian or Hapao, I recommend to use the last version. This is simple and everybody understand. All the tests are green. If they are not green, then I apology for the damage caused and I fix them.
If a user finds a bug, then I merely open a bug fix and try to fix this rapidly. Once fixed, I made another release. We do this for Moose and it just works. I am not saying this is better than other way of working. Look, we are lucky to live in a free World :-)

Again, I want to be able to precisely trace the version of an application, without having to ask about the number of the .mcz file configuration. I value being able to easily know which version a user has when he says he is using 1.60.1. Asking what is the version of the .mcz file is conter-productive in my opinion.

>> This is what Pharo is doing (e.g., 12345, 12346, 12347, ...) and most of the tool that I use
>
>> (e.g., I use version 5.138.140.0.129428 of Omnigraffle :-)
>
> No idea what that could even mean to the *end user* (the target for
> Metacello)

That doesn't matter. If I have to report a bug in Omnigraffle, I would give this number and they would precisely know which version I am using.

> What will happen when you have 10 release out there?
> Will you update the ten release to include a fix, that is a nightmare
> (effectively you're maintaining 10 branches of your code base, no
> project can survive that).

No. I consider every version as a release. And having plenty of them is healthy. People have to always use the last version of Mondrian, Spy, Moose and so on.

So, shall I use Pharo 1.2.1 or use the last version of Pharo? Am I a user or a developer?
Unfortunately, I haven't got much resources to directly contribute to improve Pharo core. Will I get slashed if I use the last version of it? :-)

Cheers,
Alexandre

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
In reply to this post by Dale Henrichs
> I think that you are using Metacello incorrectly.

But as soon as I am happy :-)

> Metacello versions are aimed at "Software versioning":
>
>  http://en.wikipedia.org/wiki/Software_versioning

This is one way to see the World. I prefer a simple version schema, which is to consider the last version as the best one.

> There _are_ aspects of Metacello that are aimed at "Revision control," so it is very _important_ that you become familiar with _both_ concepts ... otherwise the difficulties in communication that we are having will only be magnified.

Maybe. But I am simply happy with having the last version as the best version.

Alexandre


>
> On 04/15/2011 10:23 AM, Alexandre Bergel wrote:
>>> Do you recall the many, many, many emails that we have exchanged talking about working in a single metacello version vs creating a separate metacello version for each commit?
>>
>> Yes I do.
>>
>>> I have asked you to document your process and I have seen nothing.
>>
>> Easy:
>>  1 - do your modif (e.g., adding 10 classes and 100 methods, fixing a bug, adding a comment, or simply fixing a typo in a comment)
>>  2 - run the test, if green then go to 3 else to 1
>>  3 - commit and add a new version number
>>
>> This is what Pharo is doing (e.g., 12345, 12346, 12347, ...) and most of the tool that I use (e.g., I use version 5.138.140.0.129428 of Omnigraffle :-)
>>
>>
>>> I now think the root cause is that you do not under "Software versioningg" or you are choosing not to think in terms of "Software versioning" when thinking of metacello versions ...
>>
>> I found the wikipedia page long, complicated and non intuitive. But this is my opinion and I do not want to force people to agree with it. Probably that if I have to manage 100 people working on many different branches, I will think about a more sophisticated process. But until then...
>>
>>> You are thinking in terms of a paper ... versions are not papers ...
>>
>> :-)
>>
>> Tobias fixes are important. Very important. They are as important than any other fix. This is what I wanted to gratify this with a version since this is a very important change for the future of MetacelloBrowser. No less important than all the changes that made 1.59 stable.
>>
>> I will only commit on 1.60.1. We will then discuss when to move to 1.61.
>>
>> Alexandre
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Dale Henrichs
In reply to this post by abergel
Alexandre,

If you do not know what "Software versioning" is and you are not interested in learning, please tell me why I should pay attention to anything else you have to say on the subject?

Dale


On Apr 15, 2011, at 5:25 PM, Alexandre Bergel wrote:

> I finally got back to my computer earlier than I expected. So, the discussion can be resumed...
>
>> In monticello you mean. Because I could just commit the first of three
>> related changes to the repo. That doesn't mean that I should update the
>> Metacello configuration to put it available to users. When I have the
>> other two commits done and commited (monticello has three new versions)
>> then I do *one* metacello release (encompassing three commits, not that
>> my users care indeed, it could be thousands).
>
> This is the way you program and I respect this. I use a slightly different way of numbering, and it has worked very well so far. When someone asks to use Mondrian or Hapao, I recommend to use the last version. This is simple and everybody understand. All the tests are green. If they are not green, then I apology for the damage caused and I fix them.
> If a user finds a bug, then I merely open a bug fix and try to fix this rapidly. Once fixed, I made another release. We do this for Moose and it just works. I am not saying this is better than other way of working. Look, we are lucky to live in a free World :-)
>
> Again, I want to be able to precisely trace the version of an application, without having to ask about the number of the .mcz file configuration. I value being able to easily know which version a user has when he says he is using 1.60.1. Asking what is the version of the .mcz file is conter-productive in my opinion.
>
>>> This is what Pharo is doing (e.g., 12345, 12346, 12347, ...) and most of the tool that I use
>>
>>> (e.g., I use version 5.138.140.0.129428 of Omnigraffle :-)
>>
>> No idea what that could even mean to the *end user* (the target for
>> Metacello)
>
> That doesn't matter. If I have to report a bug in Omnigraffle, I would give this number and they would precisely know which version I am using.
>
>> What will happen when you have 10 release out there?
>> Will you update the ten release to include a fix, that is a nightmare
>> (effectively you're maintaining 10 branches of your code base, no
>> project can survive that).
>
> No. I consider every version as a release. And having plenty of them is healthy. People have to always use the last version of Mondrian, Spy, Moose and so on.
>
> So, shall I use Pharo 1.2.1 or use the last version of Pharo? Am I a user or a developer?
> Unfortunately, I haven't got much resources to directly contribute to improve Pharo core. Will I get slashed if I use the last version of it? :-)
>
> Cheers,
> Alexandre
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
Even if I do not fully agree on your schema, I am willing to follow it.

Dale, let's be constructive please.
How can I help you to turn the yellow test green? I would like to incorporate Tobias fixes, but I do not feel confident in committing if tests are not green.

Alexandre


On 15 Apr 2011, at 21:54, Dale Henrichs wrote:

> Alexandre,
>
> If you do not know what "Software versioning" is and you are not interested in learning, please tell me why I should pay attention to anything else you have to say on the subject?
>
> Dale
>
>
> On Apr 15, 2011, at 5:25 PM, Alexandre Bergel wrote:
>
>> I finally got back to my computer earlier than I expected. So, the discussion can be resumed...
>>
>>> In monticello you mean. Because I could just commit the first of three
>>> related changes to the repo. That doesn't mean that I should update the
>>> Metacello configuration to put it available to users. When I have the
>>> other two commits done and commited (monticello has three new versions)
>>> then I do *one* metacello release (encompassing three commits, not that
>>> my users care indeed, it could be thousands).
>>
>> This is the way you program and I respect this. I use a slightly different way of numbering, and it has worked very well so far. When someone asks to use Mondrian or Hapao, I recommend to use the last version. This is simple and everybody understand. All the tests are green. If they are not green, then I apology for the damage caused and I fix them.
>> If a user finds a bug, then I merely open a bug fix and try to fix this rapidly. Once fixed, I made another release. We do this for Moose and it just works. I am not saying this is better than other way of working. Look, we are lucky to live in a free World :-)
>>
>> Again, I want to be able to precisely trace the version of an application, without having to ask about the number of the .mcz file configuration. I value being able to easily know which version a user has when he says he is using 1.60.1. Asking what is the version of the .mcz file is conter-productive in my opinion.
>>
>>>> This is what Pharo is doing (e.g., 12345, 12346, 12347, ...) and most of the tool that I use
>>>
>>>> (e.g., I use version 5.138.140.0.129428 of Omnigraffle :-)
>>>
>>> No idea what that could even mean to the *end user* (the target for
>>> Metacello)
>>
>> That doesn't matter. If I have to report a bug in Omnigraffle, I would give this number and they would precisely know which version I am using.
>>
>>> What will happen when you have 10 release out there?
>>> Will you update the ten release to include a fix, that is a nightmare
>>> (effectively you're maintaining 10 branches of your code base, no
>>> project can survive that).
>>
>> No. I consider every version as a release. And having plenty of them is healthy. People have to always use the last version of Mondrian, Spy, Moose and so on.
>>
>> So, shall I use Pharo 1.2.1 or use the last version of Pharo? Am I a user or a developer?
>> Unfortunately, I haven't got much resources to directly contribute to improve Pharo core. Will I get slashed if I use the last version of it? :-)
>>
>> Cheers,
>> Alexandre
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Dale Henrichs

On Apr 15, 2011, at 8:01 PM, Alexandre Bergel wrote:

> Even if I do not fully agree on your schema, I am willing to follow it.

If you don't understand it, how can you follow it? If you don't understand it how can you agree or disagree?

> Dale, let's be constructive please.

If you want to be constructive, express a willingness to learn about "Software versioning".... We cannot have a meaningful conversation about Metacello unless you are wiling to learn some of the concepts ...


> How can I help you to turn the yellow test green? I would like to incorporate Tobias fixes, but I do not feel confident in committing if tests are not green.

If you understood the process that I want to follow, you would not be pleading with me to turn the tests green on a version that is not ready to be used by anyone else, whether or not the tests are green ... you would also know that there is a very simple answer to your problem .... a hint is that I've already mentioned the solution in an earlier email....

Dale
Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
I can't believe that all started because I prefer to write "1.60.1" instead of "1.60 (dkh.288)".

Alexandre


On 15 Apr 2011, at 22:12, Dale Henrichs wrote:

>
> On Apr 15, 2011, at 8:01 PM, Alexandre Bergel wrote:
>
>> Even if I do not fully agree on your schema, I am willing to follow it.
>
> If you don't understand it, how can you follow it? If you don't understand it how can you agree or disagree?
>
>> Dale, let's be constructive please.
>
> If you want to be constructive, express a willingness to learn about "Software versioning".... We cannot have a meaningful conversation about Metacello unless you are wiling to learn some of the concepts ...
>
>
>> How can I help you to turn the yellow test green? I would like to incorporate Tobias fixes, but I do not feel confident in committing if tests are not green.
>
> If you understood the process that I want to follow, you would not be pleading with me to turn the tests green on a version that is not ready to be used by anyone else, whether or not the tests are green ... you would also know that there is a very simple answer to your problem .... a hint is that I've already mentioned the solution in an earlier email....
>
> Dale

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Dale Henrichs
Alexandre,

You are completely missing the point ... read about "software versioning" ....

I can't believe that you aren't willing to learn about Software versioning ... that is really incredible to me...

Seriously if you refuse to learn, I will simply fork the project ... I don't want to ... I still believe that you have something to contribute, but if you are unwilling to inform yourself so that we can have a meaningful conversation/debate, then I am unwilling to work with you...

Dale

On Apr 15, 2011, at 8:31 PM, Alexandre Bergel wrote:

> I can't believe that all started because I prefer to write "1.60.1" instead of "1.60 (dkh.288)".
>
> Alexandre
>
>
> On 15 Apr 2011, at 22:12, Dale Henrichs wrote:
>
>>
>> On Apr 15, 2011, at 8:01 PM, Alexandre Bergel wrote:
>>
>>> Even if I do not fully agree on your schema, I am willing to follow it.
>>
>> If you don't understand it, how can you follow it? If you don't understand it how can you agree or disagree?
>>
>>> Dale, let's be constructive please.
>>
>> If you want to be constructive, express a willingness to learn about "Software versioning".... We cannot have a meaningful conversation about Metacello unless you are wiling to learn some of the concepts ...
>>
>>
>>> How can I help you to turn the yellow test green? I would like to incorporate Tobias fixes, but I do not feel confident in committing if tests are not green.
>>
>> If you understood the process that I want to follow, you would not be pleading with me to turn the tests green on a version that is not ready to be used by anyone else, whether or not the tests are green ... you would also know that there is a very simple answer to your problem .... a hint is that I've already mentioned the solution in an earlier email....
>>
>> Dale
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
Dale, I am not attached to any version numbering for the browser. Feel free to increase it when you feel like, I will agree with you. So, when can I integrate Tobias' change?

Alexandre


On 15 Apr 2011, at 22:43, Dale Henrichs wrote:

> Alexandre,
>
> You are completely missing the point ... read about "software versioning" ....
>
> I can't believe that you aren't willing to learn about Software versioning ... that is really incredible to me...
>
> Seriously if you refuse to learn, I will simply fork the project ... I don't want to ... I still believe that you have something to contribute, but if you are unwilling to inform yourself so that we can have a meaningful conversation/debate, then I am unwilling to work with you...
>
> Dale
>
> On Apr 15, 2011, at 8:31 PM, Alexandre Bergel wrote:
>
>> I can't believe that all started because I prefer to write "1.60.1" instead of "1.60 (dkh.288)".
>>
>> Alexandre
>>
>>
>> On 15 Apr 2011, at 22:12, Dale Henrichs wrote:
>>
>>>
>>> On Apr 15, 2011, at 8:01 PM, Alexandre Bergel wrote:
>>>
>>>> Even if I do not fully agree on your schema, I am willing to follow it.
>>>
>>> If you don't understand it, how can you follow it? If you don't understand it how can you agree or disagree?
>>>
>>>> Dale, let's be constructive please.
>>>
>>> If you want to be constructive, express a willingness to learn about "Software versioning".... We cannot have a meaningful conversation about Metacello unless you are wiling to learn some of the concepts ...
>>>
>>>
>>>> How can I help you to turn the yellow test green? I would like to incorporate Tobias fixes, but I do not feel confident in committing if tests are not green.
>>>
>>> If you understood the process that I want to follow, you would not be pleading with me to turn the tests green on a version that is not ready to be used by anyone else, whether or not the tests are green ... you would also know that there is a very simple answer to your problem .... a hint is that I've already mentioned the solution in an earlier email....
>>>
>>> Dale
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

abergel
In reply to this post by Dale Henrichs
> I can't believe that you aren't willing to learn about Software versioning ... that is really incredible to me...

Dale, this is not about not willing to learn. I read and learn the whole day long. I have read the wikipage about versioning and revision. I also have read many many software engineering books. I am perfectly fine with the version number schema you wish to give to the browser. I am not sentimentally attached to mine for the browser. As the wikipage you give says, there are several different version naming schemas.

What is important for me is to move on, fixing bugs, and answering to questions asked by users. I have received many questions and suggestions for improvement. So far, I feel blocked because tests are not green. Apparently printing a config info produce a slightly different result.

Whereas I perfectly trust many of the decisions you made, keeping the tests green or yellow for a short time is important for me.

Alexandre



> On Apr 15, 2011, at 8:31 PM, Alexandre Bergel wrote:
>
>> I can't believe that all started because I prefer to write "1.60.1" instead of "1.60 (dkh.288)".
>>
>> Alexandre
>>
>>
>> On 15 Apr 2011, at 22:12, Dale Henrichs wrote:
>>
>>>
>>> On Apr 15, 2011, at 8:01 PM, Alexandre Bergel wrote:
>>>
>>>> Even if I do not fully agree on your schema, I am willing to follow it.
>>>
>>> If you don't understand it, how can you follow it? If you don't understand it how can you agree or disagree?
>>>
>>>> Dale, let's be constructive please.
>>>
>>> If you want to be constructive, express a willingness to learn about "Software versioning".... We cannot have a meaningful conversation about Metacello unless you are wiling to learn some of the concepts ...
>>>
>>>
>>>> How can I help you to turn the yellow test green? I would like to incorporate Tobias fixes, but I do not feel confident in committing if tests are not green.
>>>
>>> If you understood the process that I want to follow, you would not be pleading with me to turn the tests green on a version that is not ready to be used by anyone else, whether or not the tests are green ... you would also know that there is a very simple answer to your problem .... a hint is that I've already mentioned the solution in an earlier email....
>>>
>>> Dale
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





Reply | Threaded
Open this post in threaded view
|

Re: Issue 133 in metacello: MetacelloBrowser: Abstract test not indicated

Miguel Cobá
In reply to this post by abergel
El vie, 15-04-2011 a las 20:25 -0400, Alexandre Bergel escribió:

> I finally got back to my computer earlier than I expected. So, the discussion can be resumed...
>
> > In monticello you mean. Because I could just commit the first of three
> > related changes to the repo. That doesn't mean that I should update the
> > Metacello configuration to put it available to users. When I have the
> > other two commits done and commited (monticello has three new versions)
> > then I do *one* metacello release (encompassing three commits, not that
> > my users care indeed, it could be thousands).
>
> This is the way you program and I respect this. I use a slightly different way of numbering, and it has worked very well so far. When someone asks to use Mondrian or Hapao, I recommend to use the last version. This is simple and everybody understand. All the tests are green. If they are not green, then I apology for the damage caused and I fix them.
> If a user finds a bug, then I merely open a bug fix and try to fix this rapidly. Once fixed, I made another release. We do this for Moose and it just works. I am not saying this is better than other way of working. Look, we are lucky to live in a free World :-)

How can this possibly work. Keep with me, before throwing my scenario on
the side:

Suppose that I have project X started in Pharo 1.0 and I follow the
process you said (only one line of development, every fix goes to HEAD,
no branching, tests always green, a commit is a release). The following
dates are sequential in time.

Date 1: Pharo 1.0 release
Date 2: Project X release 0.1 relying on feature Y of Pharo 1.0
Date 3: Project X release 0.2 (a bug fix)
Date 4: Project X release 0.3 (new functionality)
Date 5: Pharo 1.1 release (deprecates but not delete feature Y)
Date 6: Project X release 0.4 (new functionality)
Date 7: Pharo 1.2 release (deletes feature Y)
Date 8: Project X release 0.5 (fixes dependency on feature Y and now
relies on feature Z to do the equivalent functionality)

Now, user Alice uses Pharo 1.0 and Project X for production deployment.
She contributes a fix for a bug she found and sends it to you.

Date 9: Alice sends improvement targeted on Project X 0.1.

At that moment you...?

- Reject the patch because she isn't using latest version
- Reject the patch because isn't applicable to release 0.5 of Project X
because the improvement uses feature Y that no longer is used (was
replaced by feature Z)
- Rewrite the improvement to use feature Z and integrate it to Project X
as 0.6
- Thanks her but notifies that your process doesn't have branches so you
can apply the improvement to the official codebase and she'll have to
have its patch for herself.

I don't see advantages on your process and as I said before is very
awkward and not what one see on just every open source project where
anyone can contribute patches to a (reasonable) old release and if yet
maintained, applied to it without modifications and to the head of
development possibly with modifications.

Now, as an aside, the biggest selling point of git (arguably the most
used distributed SCM software, replacing subversion everywhere on the
internet, followed by mercurial and bazaar) is the cheap,
use-for-every-thing-no-matter-how-small-the-change-to-project-is,
branching model. And the point of a branch is to allow the developers to
*use* as many commits as they want to implement some functionality,
knowing that when merging with the main branch (or the head of
development) the SCM software will create a single commit with all the
changes applied.

What you're arguing is the model that subversion and CVS had, where each
commit is visible to anyone, no matter if complete, tested or
functional. Either or you commit something incomplete, or you keep your
changes to yourself (backing up in a zip and other esoteric procedures)
and work as if no SCM was available to you.

This use of a DSCM as a SCM is a regression to all efects.

Regards
--
Miguel Cobá
http://twitter.com/MiguelCobaMtz
http://miguel.leugim.com.mx



12