Issue 4549 in pharo: Unable to open the Test Runner menu on OS X

Status: New
Owner: ----

New issue 4549 by [hidden email]: Unable to open the Test Runner menu  
on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

Pharo image: Pharo
Pharo core version: 1.3 #13287
Virtual machine used: Cog OS X
Class browser used (if applicable): OBSystemBrowserAdaptor

Steps to reproduce:
1. Open the TestRunner
2. Command-click the classes or categories list
3. No menu shows up


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

I added a SLICE to PharoInbox that fixes this on my machine for Pharo 1.3 &  
1.4. I don't know if it's a clean patch...when I opened Monticello, it  
listed PluggableTextMorph>>stylerStyled: and stylerStyledInBackground: even  
though the only method that I changed was PluggableListMorph>>mouseDown:

I also don't know if I broke anything in the process. Presumably that  
method was written that way for a reason. But anyway, I just want to report  
that the Test Runner menu doesn't open on OS X in 1.3 and 1.4, and the  
change that I submitted gets it working again, so might be used as a  
starting point for a final fix.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ReviewNeeded
        Labels: Milestone-1.3 Milestone-1.4

Comment #2 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

Yes this is probably my mistake when I rewrote it.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

from which image did you do your changes because I could not load in 1.3  
or .14 (even by adding the phaor repository)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

I could not reproduce this problem on 1.3 and 1.4. so can you reproduce it?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

I experienced the bug and made the changes using the image downloaded from  
https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.3/ 
specifically the Pharo-1.3.zip


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

Here's a 1 minute video demonstrating the problem & fix:  
http://www.youtube.com/watch?v=g8EX31G0yZs


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

great idea!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

Thanks a lot this is the best bug tracking entry we got!!!
I will look into that.
I do not understand why on my 1.3 image it works. I will check - ok may be  
I did not use the dev image.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #9 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

This seems to be related to the MultiSelection changes of Benjamin...

I CC: him.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #10 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Comment

Comment #11 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

It's possible. I have implemented a new behavior which tell if you right  
click or if you cmd+click

The first one open the menu, the second one is to select non-continus items.

So either we remove this behavior, or we found another key binding or we  
assume that most of the mac now have right click without using cmd.

Just tell me :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

Yes, right click brings up the menu.

But in the normal Browser, both control-click and right click bring up a  
menu. So being consistent would be nice.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

It's not depending on the browser, it's depending of the kind of list (and  
moreover, the Browser should be replaced soon).

The problem is that I (and it seems I am not alone) want to have some multi  
selection lists around, and be able to select non-continus item is a must  
have.

So somehow, we have to implement this behavior. We just have to decide the  
to way to do it ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

On a mac, control-clicking IS right-clicking. So I don't think you can  
distinguish between "control click" and "right click" - not on Mac, anyway.

And on my machine, on 1.2 (and 1.3/1.4 with the patch I submitted),  
command-click brings up the test menu, and ctrl-click ("right click")  
brings up the morph context menu - e.g. aPluggableListMorphOfMany


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

On mac, you can distinguish (right click value is 2 when cmd clicl is 4X)

Try Nautilus, you will see that you can cmd+clicK or right click with a  
different behavior.

I am ok to have a different key binding, but let's define wich one  
together :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

Yes, command-click is different from right-click. right-click's equivalent  
is control-click.

Since I've been using Pharo (1.0), ctrl-click (right click) has always  
brought up the morph menu, and command-click has brought up the  
context-sensitive "action" menu. But now that's broken in 1.3, where  
command-clicking doesn't work *at all* (at least in the test runner, and  
presumably elsewhere)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

Do what do we do?

The idea is that 1.3 should not be the perfect release.... it should just  
be a release so that we can
start to focus on 1.4.

One idea could be to revert in 1.3 to the behavior before, so we have time  
to come up with a consistent
story for 1.4.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: -[hidden email] [hidden email]

Comment #18 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #19 on issue 4549 by [hidden email]: Unable to open the Test  
Runner menu on OS X
http://code.google.com/p/pharo/issues/detail?id=4549

This is not a showstopper -> move it to 1.4



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker