Issue 4718 in pharo: Deprecate old deprecation messages

Status: New
Owner: ----

New issue 4718 by [hidden email]: Deprecate old deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

In Pharo 1.4, there are:
   deprecated:
   deprecated:on:
   deprecated:on:in:

deprecated:on:in: should be used

Discussion at  
http://forum.world.st/what-about-deprecating-deprecated-td2306905.html

I think the message name should be deprecatedIn:On:warn:, but that is  
another story. Then you would have:
   self
     deprecatedIn: '1.4'
     on: '8/29/2011'
     warn: 'Use haltOnCount:. Since you end up in a debugger, aString  
provides little information'.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted
        Labels: Milestone-1.4

Comment #1 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Ok for me!



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Fix in inbox:  
SLICE-Issue-4718-Deprecate-old-deprecation-messages-SeanDeNigris.1

However, does it make sense for them to call deprecated:on:in:? Maybe this  
should be commented out... My thinking is that if the method is in the  
*deprecated14 protocol and deprecated:on:in: is listed in the method  
comment, these will be hints. But actually calling deprecated:on:in: will  
not warn the offender, but the poor user who calls a method deprecated  
using the old system and is warned twice. What do you think?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Alternate fix in inbox:  
SLICE-Issue-4718-Deprecate-old-deprecation-messages-SeanDeNigris.2

Warns in method comments, but doesn't send deprecated:on:in:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

I thought about this some more...

If Pharo itself is the only one using these messages, we could:
- fix the senders to use deprecated:on:in: with the newest method version  
date and 'Pharo1.4'
- remove deprecated: & deprecated:on: all-together
- announce via mailing list
Then, future deprecators will be warned about the unknown message and  
investigate (we could also put a comment in deprecated:on:in: about the  
removal).



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Okay, all done. The latest fix in the inbox  
(SLICE-Issue-4718-Deprecate-old-deprecation-messages-SeanDeNigris.3) does  
the following:
* Removed Object>>deprecated: and Object>>deprecated:in:
* Changed all senders in image to use deprecated:on:in:, using timeStamp  
for the date and correct version in which it was deprecated


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

thanks a lot for your time and energy


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Before integrating: keep in mind that this touches Deprecated13, so the  
package needs to be loaded first.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Hmmm... loading Deprecated13 from the Pharo14 I get a *System Error  
Handling Failed" immediately.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Is this error because of my fix, or something else? I saved all the images  
with the fixes, so if you need me to adjust anything, just let me know.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Started

Comment #10 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

Deprecated13 is not in 14 anymore (it was just too large... 5000loc, and  
made it impossible to clean up more)

Can you do a version of the slice without Deprecated13?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

I'm merging simply all the other packages now.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #12 on issue 4718 by [hidden email]: Deprecate old  
deprecation messages
http://code.google.com/p/pharo/issues/detail?id=4718

in 14148 :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker