Issues 56/57 fixed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Issues 56/57 fixed

Simon Denier-3
Hi Dale

I see on the issue list that 56 and 57 have been fixed in version 25. Can you give the API? :)

--
 Simon



Reply | Threaded
Open this post in threaded view
|

Re: Issues 56/57 fixed

Dale
For Issue 56, I added a new OB command: 'Save Packages (nested)' which recurses through the projects for a given configuration, commits packages, updates package methods and commits configuration on a project by project basis. The commit comment is carried through all of the commits...
 
For Issue 57 I add the class method spawnPackageMethodIn:category:named:sourceVersion:targetVersion:blessing: to MetacelloVersionConstructor.

Dale

----- "Simon Denier" <[hidden email]> wrote:

| Hi Dale
|
| I see on the issue list that 56 and 57 have been fixed in version 25.
| Can you give the API? :)
|
| --
|  Simon
Reply | Threaded
Open this post in threaded view
|

Re: Issues 56/57 fixed

Dale
In reply to this post by Simon Denier-3
Simon,

I am guessing that I didn't quite fix the Issue 56 the way you had anticipated ... I think that I can push the gofer commit out of OB-Metacello to the Metacello core where it can be used in other contexts ...

Dale
----- "Simon Denier" <[hidden email]> wrote:

| Hi Dale
|
| I see on the issue list that 56 and 57 have been fixed in version 25.
| Can you give the API? :)
|
| --
|  Simon
Reply | Threaded
Open this post in threaded view
|

Re: Issues 56/57 fixed

Simon Denier-3

On 15 mars 2010, at 17:53, Dale Henrichs wrote:

> Simon,
>
> I am guessing that I didn't quite fix the Issue 56 the way you had anticipated ... I think that I can push the gofer commit out of OB-Metacello to the Metacello core where it can be used in other contexts ...

Yes

I have seem the feature in OB-metacello but haven't looked deeper. I just assumed that I could reuse the code in here to make a commit. So, do whatever you want to make it reusable.


>
> Dale
> ----- "Simon Denier" <[hidden email]> wrote:
>
> | Hi Dale
> |
> | I see on the issue list that 56 and 57 have been fixed in version 25.
> | Can you give the API? :)
> |
> | --
> |  Simon

--
 Simon



Reply | Threaded
Open this post in threaded view
|

Re: Issues 56/57 fixed

Dale
Simon,

MetacelloMCProject>>goferCommitProject:
MetacelloPackageSpec>>goferCommitPackage:

both take a string a do a gofer commit (instead of interactive commit).

Available in 1.0-beta.25.

Dale

----- "Simon Denier" <[hidden email]> wrote:

| On 15 mars 2010, at 17:53, Dale Henrichs wrote:
|
| > Simon,
| >
| > I am guessing that I didn't quite fix the Issue 56 the way you had
| anticipated ... I think that I can push the gofer commit out of
| OB-Metacello to the Metacello core where it can be used in other
| contexts ...
|
| Yes
|
| I have seem the feature in OB-metacello but haven't looked deeper. I
| just assumed that I could reuse the code in here to make a commit. So,
| do whatever you want to make it reusable.
|
|
| >
| > Dale
| > ----- "Simon Denier" <[hidden email]> wrote:
| >
| > | Hi Dale
| > |
| > | I see on the issue list that 56 and 57 have been fixed in version
| 25.
| > | Can you give the API? :)
| > |
| > | --
| > |  Simon
|
| --
|  Simon

To unsubscribe from this group, send email to metacello+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Reply | Threaded
Open this post in threaded view
|

Re: Issues 56/57 fixed

Simon Denier-3
Hi Dale

To commit packages, I use the following snippet copy-pasted from OB commands:

commitPackageSpec: packageSpec into: repositoryList with: message
        | gofer |
        gofer := Gofer new.
        gofer disablePackageCache.
        repositoryList do: [:repository | gofer repository: repository].
        gofer package: packageSpec name.
        gofer commit: message


I guess that goferCommitPackage: is a shortcut?



On 23 mars 2010, at 23:42, Dale Henrichs wrote:

> Simon,
>
> MetacelloMCProject>>goferCommitProject:
> MetacelloPackageSpec>>goferCommitPackage:
>
> both take a string a do a gofer commit (instead of interactive commit).
>
> Available in 1.0-beta.25.
>
> Dale
>
> ----- "Simon Denier" <[hidden email]> wrote:
>
> | On 15 mars 2010, at 17:53, Dale Henrichs wrote:
> |
> | > Simon,
> | >
> | > I am guessing that I didn't quite fix the Issue 56 the way you had
> | anticipated ... I think that I can push the gofer commit out of
> | OB-Metacello to the Metacello core where it can be used in other
> | contexts ...
> |
> | Yes
> |
> | I have seem the feature in OB-metacello but haven't looked deeper. I
> | just assumed that I could reuse the code in here to make a commit. So,
> | do whatever you want to make it reusable.
> |
> |
> | >
> | > Dale
> | > ----- "Simon Denier" <[hidden email]> wrote:
> | >
> | > | Hi Dale
> | > |
> | > | I see on the issue list that 56 and 57 have been fixed in version
> | 25.
> | > | Can you give the API? :)
> | > |
> | > | --
> | > |  Simon
> |
> | --
> |  Simon
>
> To unsubscribe from this group, send email to metacello+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.

--
 Simon



To unsubscribe from this group, send email to metacello+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Reply | Threaded
Open this post in threaded view
|

Re: Issues 56/57 fixed

Dale
In reply to this post by Simon Denier-3
That's right...If the package spec does not have a repository spec associated with it then doing it directly with OB-style is probably preferred...

Dale

----- "Simon Denier" <[hidden email]> wrote:

| Hi Dale
|
| To commit packages, I use the following snippet copy-pasted from OB
| commands:
|
| commitPackageSpec: packageSpec into: repositoryList with: message
| | gofer |
| gofer := Gofer new.
| gofer disablePackageCache.
| repositoryList do: [:repository | gofer repository: repository].
| gofer package: packageSpec name.
| gofer commit: message
|
|
| I guess that goferCommitPackage: is a shortcut?
|
|
|
| On 23 mars 2010, at 23:42, Dale Henrichs wrote:
|
| > Simon,
| >
| > MetacelloMCProject>>goferCommitProject:
| > MetacelloPackageSpec>>goferCommitPackage:
| >
| > both take a string a do a gofer commit (instead of interactive
| commit).
| >
| > Available in 1.0-beta.25.
| >
| > Dale
| >
| > ----- "Simon Denier" <[hidden email]> wrote:
| >
| > | On 15 mars 2010, at 17:53, Dale Henrichs wrote:
| > |
| > | > Simon,
| > | >
| > | > I am guessing that I didn't quite fix the Issue 56 the way you
| had
| > | anticipated ... I think that I can push the gofer commit out of
| > | OB-Metacello to the Metacello core where it can be used in other
| > | contexts ...
| > |
| > | Yes
| > |
| > | I have seem the feature in OB-metacello but haven't looked deeper.
| I
| > | just assumed that I could reuse the code in here to make a commit.
| So,
| > | do whatever you want to make it reusable.
| > |
| > |
| > | >
| > | > Dale
| > | > ----- "Simon Denier" <[hidden email]> wrote:
| > | >
| > | > | Hi Dale
| > | > |
| > | > | I see on the issue list that 56 and 57 have been fixed in
| version
| > | 25.
| > | > | Can you give the API? :)
| > | > |
| > | > | --
| > | > |  Simon
| > |
| > | --
| > |  Simon
| >
| > To unsubscribe from this group, send email to
| metacello+unsubscribegooglegroups.com or reply to this email with the
| words "REMOVE ME" as the subject.
|
| --
|  Simon
|
|
|
| To unsubscribe from this group, send email to
| metacello+unsubscribegooglegroups.com or reply to this email with the
| words "REMOVE ME" as the subject.

To unsubscribe from this group, send email to metacello+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.