Mantis Issue: 0003355 - TTCFont ascent reports wrong result

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Mantis Issue: 0003355 - TTCFont ascent reports wrong result

John Pierce-2
Hi all,

I got in trouble last time I posted a fix to this list. I'm not sure
how to post fixes, but I did make a bug report in Mantis (issue
#0003355).

The problem is TTCFont used to have an "ascent" instance variable that
the "ascent" method expects to use. The variable used to exist about
October of 2005 and no longer does, yet the method still references
it.

Thus, the "ascent" method seems to report the wrong answer and most
TTCFonts are not appropriately sized if "autofit" is enabled on the
TextMorph.

So, this fix is easy. Not sure where to post it, but just add "ascent"
to the instance variable list of TTCFont.

Regards,

John

--
It's easy to have a complicated idea. It's very very hard to have a
simple idea. -- Carver Mead

Reply | Threaded
Open this post in threaded view
|

Re: Mantis Issue: 0003355 - TTCFont ascent reports wrong result

Marcus Denker

On 25.03.2006, at 20:55, John Pierce wrote:

> Hi all,
>
> I got in trouble last time I posted a fix to this list. I'm not sure
> how to post fixes, but I did make a bug report in Mantis (issue
> #0003355).
>
You can just attach a .cs to the report on mantis. This makes
sure that the report and the solution are close, and having
a .cs (or at least a very clear description) makes harvesting
much easier.

       Marcus

Reply | Threaded
Open this post in threaded view
|

Re: Mantis Issue: 0003355 - TTCFont ascent reports wrong result

Ken Causey-3
In reply to this post by John Pierce-2
On Sat, 2006-03-25 at 14:55 -0500, John Pierce wrote:
> Hi all,
>
> I got in trouble last time I posted a fix to this list. I'm not sure
> how to post fixes, but I did make a bug report in Mantis (issue
> #0003355).

You can post a fix simply by modifying your image appropriately, using a
dual changesorter to make an appropriately simply changeset (make sure
to put your information in the preamble), file it out, gzip it with a
FileList (or from the command line as you prefer, and then attaching it
to the report using the 'Upload File' section of the report.  You may
have noticed that this field was also available when you created the
report.

Ken

P.S. I should be on #squeak (irc.freenode.net) of an on for the next
several hours if you need any assistance.



signature.asc (198 bytes) Download Attachment