May I remove ClassBuilder>format:variable:words:pointers:weak:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

May I remove ClassBuilder>format:variable:words:pointers:weak:

David T. Lewis
ClassBuilder>format:variable:words:pointers:weak: is obsolete and
unreferenced. May I remove it, and also clean up related references
in MethodFinder>>notDangerous?

Asking here so as not to clutter up the inbox.

Thanks,
Dave


Reply | Threaded
Open this post in threaded view
|

Re: May I remove ClassBuilder>format:variable:words:pointers:weak:

Eliot Miranda-2
Hi Dave,

> On Aug 15, 2020, at 11:36 AM, David T. Lewis <[hidden email]> wrote:
>
> ClassBuilder>format:variable:words:pointers:weak: is obsolete and
> unreferenced. May I remove it, and also clean up related references
> in MethodFinder>>notDangerous?

I have no objection. Quite the opposite.

>
> Asking here so as not to clutter up the inbox.
>
> Thanks,
> Dave
>
>

Reply | Threaded
Open this post in threaded view
|

Re: May I remove ClassBuilder>format:variable:words:pointers:weak:

marcel.taeumel
Hi Dave,

would it help users to keep it around as deprecated? Could there be a fall-back implementation to non-deprecated code?

Best,
Marcel

Am 16.08.2020 06:55:56 schrieb Eliot Miranda <[hidden email]>:

Hi Dave,

> On Aug 15, 2020, at 11:36 AM, David T. Lewis wrote:
>
> ClassBuilder>format:variable:words:pointers:weak: is obsolete and
> unreferenced. May I remove it, and also clean up related references
> in MethodFinder>>notDangerous?

I have no objection. Quite the opposite.

>
> Asking here so as not to clutter up the inbox.
>
> Thanks,
> Dave
>
>



Reply | Threaded
Open this post in threaded view
|

Re: May I remove ClassBuilder>format:variable:words:pointers:weak:

David T. Lewis
Hi Marcel,


On Mon, Aug 17, 2020 at 10:34:06AM +0200, Marcel Taeumel wrote:
> Hi Dave,
>
> would it help users to keep it around as deprecated? Could there be a fall-back implementation to non-deprecated code?
>


Yes we could move it to 60Deprecated. Actually we could have deprecated
it several years ago. But just deleting it and cleaning up the references
in MethodFinder seems safe enough at this point.

Basically ClassBuilder>format:variable:words:pointers:weak: has
been serving as the fallback method for its replacement method
ClassBuilder>format:variable:bitsUnitSize:pointers:weak: which has
been in use for the last several years. The difference is that the
new method allows specification of 64-bit and 16-bit data sizes, not
just 32-bit and 8-bit as before.

I am fairly sure that the method is intended only for private use by
the system itself (including Montecello). I checked Magma, and there
are no references there either.

This is not urgent, I will wait a couple of days before doing anything.

Dave


> Best,
> Marcel
> Am 16.08.2020 06:55:56 schrieb Eliot Miranda <[hidden email]>:
> Hi Dave,
>
> > On Aug 15, 2020, at 11:36 AM, David T. Lewis wrote:
> >
> > ???ClassBuilder>format:variable:words:pointers:weak: is obsolete and
> > unreferenced. May I remove it, and also clean up related references
> > in MethodFinder>>notDangerous?
>
> I have no objection. Quite the opposite.
>
> >
> > Asking here so as not to clutter up the inbox.
> >
> > Thanks,
> > Dave
> >
> >
>

>


Reply | Threaded
Open this post in threaded view
|

Re: May I remove ClassBuilder>format:variable:words:pointers:weak:

Chris Muller-3
I checked Magma, and there
are no references there either.

Aww, thanks Dave!  :)  Sincerely, I was just getting ready to check myself when I saw this.  Magma uses ClassBuilder in a couple of places, but this selector didn't ring a bell.
 - Chris