Merge! Merge! Merge! (was Re: [squeak-dev] Re: straaannnnge code in SystemWindow>>addMorph:fullFrame:)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Merge! Merge! Merge! (was Re: [squeak-dev] Re: straaannnnge code in SystemWindow>>addMorph:fullFrame:)

Frank Shearar-3
On 12 June 2013 23:36, Nicolas Cellier
<[hidden email]> wrote:
> Concerning the gem, this remind me http://bugs.squeak.org/view.php?id=7012

I can't test this myself at the moment (deadlines breathing down my
neck), but if it's still a valid bug, several people have tried the
fix. Let's update the fix as necessary & merge it in!

frank

Reply | Threaded
Open this post in threaded view
|

Re: Merge! Merge! Merge! (was Re: [squeak-dev] Re: straaannnnge code in SystemWindow>>addMorph:fullFrame:)

Nicolas Cellier
Me neither, but I bet it's already in image (since 3.10 or 3.11 ?)


2013/6/13 Frank Shearar <[hidden email]>
On 12 June 2013 23:36, Nicolas Cellier
<[hidden email]> wrote:
> Concerning the gem, this remind me http://bugs.squeak.org/view.php?id=7012

I can't test this myself at the moment (deadlines breathing down my
neck), but if it's still a valid bug, several people have tried the
fix. Let's update the fix as necessary & merge it in!

frank




Reply | Threaded
Open this post in threaded view
|

Re: Merge! Merge! Merge! (was Re: [squeak-dev] Re: straaannnnge code in SystemWindow>>addMorph:fullFrame:)

Frank Shearar-3
If it is, then there's still work to do on the ticket: it should be closed.

Would you mind terribly checking it out?

frank

On 13 June 2013 18:32, Nicolas Cellier
<[hidden email]> wrote:

> Me neither, but I bet it's already in image (since 3.10 or 3.11 ?)
>
>
> 2013/6/13 Frank Shearar <[hidden email]>
>>
>> On 12 June 2013 23:36, Nicolas Cellier
>> <[hidden email]> wrote:
>> > Concerning the gem, this remind me
>> > http://bugs.squeak.org/view.php?id=7012
>>
>> I can't test this myself at the moment (deadlines breathing down my
>> neck), but if it's still a valid bug, several people have tried the
>> fix. Let's update the fix as necessary & merge it in!
>>
>> frank
>>
>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Merge! Merge! Merge! (was Re: [squeak-dev] Re: straaannnnge code in SystemWindow>>addMorph:fullFrame:)

Nicolas Cellier
BrowserCommentPaneHiding-M7012.2.cs is in the image (a variant replacing and:[]and:[] with and:[and:[]] in 2010)
But the fix is obsolete since the code pane is no longer split in two when selecting a class.
I will close the bug


2013/6/13 Frank Shearar <[hidden email]>
If it is, then there's still work to do on the ticket: it should be closed.

Would you mind terribly checking it out?

frank

On 13 June 2013 18:32, Nicolas Cellier
<[hidden email]> wrote:
> Me neither, but I bet it's already in image (since 3.10 or 3.11 ?)
>
>
> 2013/6/13 Frank Shearar <[hidden email]>
>>
>> On 12 June 2013 23:36, Nicolas Cellier
>> <[hidden email]> wrote:
>> > Concerning the gem, this remind me
>> > http://bugs.squeak.org/view.php?id=7012
>>
>> I can't test this myself at the moment (deadlines breathing down my
>> neck), but if it's still a valid bug, several people have tried the
>> fix. Let's update the fix as necessary & merge it in!
>>
>> frank
>>
>
>
>
>