MetacelloPharoPlatform>>#do:disp
Locked
MetacelloPharoPlatform>>#do:disp
 
Administrator
|
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
Re: MetacelloPharoPlatform>>#do:disp
|
|
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
Re: MetacelloPharoPlatform>>#do:disp
|
|
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
Re: MetacelloPharoPlatform>>#do:disp
|
|
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
Re: MetacelloPharoPlatform>>#do:disp
|
|
Re: MetacelloPharoPlatform>>#do:disp
|
|
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
In reply to this post by Sean P. DeNigris
Okay, here's a new config... Dale, would you check it before I commit...
* Create version '1.0-beta.31.1.4', which loads Platform.pharo for 1.x and Platform.pharo20 for 2.x (Required for Issue 64) * Edit version '1.0-beta.32' - Update with same change as above - change spaces indenting to tabs * Update stable for #'common' to version '1.0-beta.31.1.4'. * Fix class-side #load, which is supposed to load the minimum necessary to load configs, to load the 'batch' group
Cheers,
Sean |
ConfigurationOfMetacello-SeanDeNigris.704.mcz (136K)
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
In reply to this post by Sean P. DeNigris
"Need to add the new package to a (new) baseline:"
I think because .pharo20 is only a branch of the Metacello-Platform package that the package structure is the same, so I used the same baseline and put the line you have above in the new literal version. Although I had to make a new version (still off dkh.703) because I forgot to update the Platform package version in the bootstrap. It now loads correctly in 2.0. b.t.w. did you know there was a drop-through in the bootstrap if the platform is neither squeak or pharo? I refactored bootstrapMetacelloFrom:, which was getting a little long after adding my changes, and noticed it returns self in that case... Name: ConfigurationOfMetacello-SeanDeNigris.705 Ancestors: ConfigurationOfMetacello-dkh.703 * Create version '1.0-beta.31.1.4', which loads Platform.pharo for 1.x and Platform.pharo20 for 2.x (Required for Issue 64) * Edit version '1.0-beta.32' - Update with same change as above - change spaces indenting to tabs * Update stable for #'common' to version '1.0-beta.31.1.4'. * Fix class-side #load, which is supposed to load the minimum necessary to load configs, to load the 'batch' group * Update bootstrap packages in #bootstrapMetacelloFrom: and refactor for clarity Cheers, Sean
Cheers,
Sean |
Re: MetacelloPharoPlatform>>#do:disp
|
|
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
In reply to this post by Sean P. DeNigris
Dale, thanks for bearing with me while I learn...
<quote author="Dale Henrichs"> You update the baseline with because if someone decides to load the baseline itself (which is allowed), you ensure that they get the correct branch for Pharo2.0... </quote> Ah, bleedingEdge, of course... <quote author="Dale Henrichs"> The logic still isn't quite correct with your new #platformPackage method .. now instead of nil, you end up with a class in the array of package names ... Metacello is only supported on 3 platforms (squeak, pharo, gemstone) and Metacello is installed by default in GemStone, so the only other platforms that are expected to work are squeak and pharo </quote> That makes perfect sense now. <quote author="Dale Henrichs">so the old logic was sufficient</quote> Absolutely, it was just getting unwieldy once I added the Pharo 2.0 branch. Just the platform package logic became 10 lines with three levels of nested conditionals. Would you accept this. I think it's correct based on your last post: platformPackage Smalltalk at: #SystemVersion ifPresent: [ :sysVersion | | versionString | versionString := sysVersion current version. (versionString beginsWith: 'Squeak') ifTrue: [ ^ (versionString beginsWith: 'Squeak3') ifTrue: [ 'Metacello-Platform.squeak-dkh.5' ] ifFalse: [ 'Metacello-Platform.squeak-dkh.10' ] ]. (versionString beginsWith: 'Pharo') ifTrue: [ ^ (versionString beginsWith: 'Pharo2') ifTrue: [ 'Metacello-Platform.pharo20-SeanDeNigris.28' ] ifFalse: [ 'Metacello-Platform.pharo-dkh.27' ] ] ]. ^ nil. I think the explicit nil is clearer for us new Metacello-ers. I was baffled by the nil return from at:ifPresent: until you mentioned it. And... bootstrapMetacelloFrom: repositoryUrl "Corresponds to version 1.0-beta.31.1.4" | minimumPackages | self ensureGoferVersion: 'Gofer-Core-lr.115' repositoryUrl: repositoryUrl. minimumPackages := OrderedCollection withAll: #( 'Metacello-Base-DaleHenrichs.19' 'Metacello-Core-dkh.465' 'Metacello-MC-dkh.522'). self platformPackage ifNotNil: [ :pkg | minimumPackages add: pkg ]. minimumPackages do: [ :pkg | self bootstrapPackage: pkg from: repositoryUrl ]. Tested on Pharo 2.0. Here's one more version with the above changes, the baseline edit, and a slight refactor to 31.1.4 (just moved the pharo1.x block back into pharo, like you have in the baseline)... If you give the green light, I'll commit it... Sean
Cheers,
Sean |
Re: MetacelloPharoPlatform>>#do:disp
|
|
Re: MetacelloPharoPlatform>>#do:disp
|
Administrator
|
| Free forum by Nabble | Edit this page |