Smalltalk › Squeak › Squeak - Dev

Missing STONJSON class

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Max Leske

Missing STONJSON class

Hi

While testing Fuel I ran into an issue with trunk (which impacts all SmalltalkCI builds): at least 3 methods reference an unknown global called "STONJSON". There is no such class. Renaming the references to "STON" fixes the problems.

My guess is that the refactoring of the repository classes led to this (the failing class during the build is the new MCFilesystemFetchOnlyRepository), why the global has that weird name is another question... :)

I've been trying for the last half hour to contribute the fix but I wasn't able to find the repository for Metacello-Platform.squeak-ct-70. I'll leave the fix to someone who knows what's going on.

Cheers,
Max

signature.asc (849 bytes) Download Attachment

Jakob Reschke

Re: Missing STONJSON class

Hi Max,

Curious. STONJSON is part of the STON-Core package. If the Squeak fork
is loaded, this is it:
https://github.com/squeak-smalltalk/squeak-ston/tree/master/repository/STON-Core.package/STONJSON.class

So the question is, why is it missing in those test images if STON is loaded.

The Metacello repository is on GitHub:
https://github.com/Metacello/metacello/tree/master/repository/Metacello-Platform.squeak.package

Kind regards,
Jakob

Am Fr., 21. Mai 2021 um 21:19 Uhr schrieb Max Leske <[hidden email]>:

>
> Hi
>
> While testing Fuel I ran into an issue with trunk (which impacts all SmalltalkCI builds): at least 3 methods reference an unknown global called "STONJSON". There is no such class. Renaming the references to "STON" fixes the problems.
>
> My guess is that the refactoring of the repository classes led to this (the failing class during the build is the new MCFilesystemFetchOnlyRepository), why the global has that weird name is another question... :)
>
>
> I've been trying for the last half hour to contribute the fix but I wasn't able to find the repository for Metacello-Platform.squeak-ct-70. I'll leave the fix to someone who knows what's going on.
>
>
> Cheers,
> Max

Max Leske

Re: Missing STONJSON class

In reply to this post by Max Leske

Thanks Jakob,

After looking at it again, the issues appears to be that SmalltalkCI provides its own STON-Core packages, replacing the one already in the image. I'll open an issue for SmalltalkCI.

Cheers,
Max

On 23 May 2021, at 15:45, [hidden email] wrote:

> Hi Max,
>
> Curious. STONJSON is part of the STON-Core package. If the Squeak fork
> is loaded, this is it:
> https://github.com/squeak-smalltalk/squeak-ston/tree/master/repository/STON-Core.package/STONJSON.class
>
> So the question is, why is it missing in those test images if STON is loaded.
>
> The Metacello repository is on GitHub:
> https://github.com/Metacello/metacello/tree/master/repository/Metacello-Platform.squeak.package
>
> Kind regards,
> Jakob
>
> Am Fr., 21. Mai 2021 um 21:19 Uhr schrieb Max Leske <[hidden email]>:
>
> Hi
>
> While testing Fuel I ran into an issue with trunk (which impacts all SmalltalkCI builds): at least 3 methods reference an unknown global called "STONJSON". There is no such class. Renaming the references to "STON" fixes the problems.
>
> My guess is that the refactoring of the repository classes led to this (the failing class during the build is the new MCFilesystemFetchOnlyRepository), why the global has that weird name is another question... :)
>
>
> I've been trying for the last half hour to contribute the fix but I wasn't able to find the repository for Metacello-Platform.squeak-ct-70. I'll leave the fix to someone who knows what's going on.
>
>
> Cheers,
> Max

signature.asc (849 bytes) Download Attachment