Smalltalk › Squeak › Squeak - Dev

Morph position: rounding side effect

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Stéphane Rollandin

Morph position: rounding side effect

Still working on porting Scratch to 4.4, I stumbled into a weird display
bug which I eventually fixed after hours of unpleasant wandering by
reverting the laza 2010 version of Morph>>position: to the previous wiz
version of 2004.

The change amounts to replacing

delta := (aPoint - bounds topLeft) rounded.

with

delta := aPoint asNonFractionalPoint - bounds topLeft.

Hence my question: does someone knows the reason for the 2010 change ?

Stef

Nicolas Cellier

Re: Morph position: rounding side effect

I don't understand the implications, but that would be:

http://source.squeak.org/trunk/Morphic-laza.421.mcz

==================== Summary ====================

Name: Morphic-laza.421
Author: laza
Time: 10 April 2010, 10:11:13.657 am
UUID: bdb40d75-5c3c-ef4b-8af6-5aba1fc537fc
Ancestors: Morphic-ar.420

Prevent FlapTabs to have floats as bounds after a change of the Squeak
window. This sometimes made FlapTabs leave "gribbles" on the screen
while moving them.

Addressing http://bugs.squeak.org/view.php?id=6536

2013/2/12 Stéphane Rollandin <[hidden email]>:

> Still working on porting Scratch to 4.4, I stumbled into a weird display bug
> which I eventually fixed after hours of unpleasant wandering by reverting
> the laza 2010 version of Morph>>position: to the previous wiz version of
> 2004.
>
> The change amounts to replacing
>
> delta := (aPoint - bounds topLeft) rounded.
>
> with
>
> delta := aPoint asNonFractionalPoint - bounds topLeft.
>
>
> Hence my question: does someone knows the reason for the 2010 change ?
>
> Stef
>

Karl Ramberg

Re: Morph position: rounding side effect

FlapTab overrides fullBounds and ownerChanged.

This cause problems with flexing FlapTab.

I think FlapTab>>ownerChanged can be safely discarded.

Karl

On Tue, Feb 12, 2013 at 10:00 PM, Nicolas Cellier <[hidden email]> wrote:

I don't understand the implications, but that would be:

http://source.squeak.org/trunk/Morphic-laza.421.mcz

==================== Summary ====================

Name: Morphic-laza.421
Author: laza
Time: 10 April 2010, 10:11:13.657 am
UUID: bdb40d75-5c3c-ef4b-8af6-5aba1fc537fc
Ancestors: Morphic-ar.420

Prevent FlapTabs to have floats as bounds after a change of the Squeak
window. This sometimes made FlapTabs leave "gribbles" on the screen
while moving them.

Addressing http://bugs.squeak.org/view.php?id=6536

2013/2/12 Stéphane Rollandin <[hidden email]>:

> Still working on porting Scratch to 4.4, I stumbled into a weird display bug
> which I eventually fixed after hours of unpleasant wandering by reverting
> the laza 2010 version of Morph>>position: to the previous wiz version of
> 2004.
>
> The change amounts to replacing
>
> delta := (aPoint - bounds topLeft) rounded.
>
> with
>
> delta := aPoint asNonFractionalPoint - bounds topLeft.
>
>
> Hence my question: does someone knows the reason for the 2010 change ?
>
> Stef
>