Smalltalk › Squeak › Squeak - Dev

My pending contributions

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 3 messages Options
Christoph Thiede
Reply | Threaded
Open this post in threaded view
♦
♦
|

My pending contributions

Christoph Thiede
Hi all,

over the past weeks, I uploaded several proposals into the inbox. There are
a few commits that haven't been resolved yet:

- Implement SyntaxErrorNotification>>#resume: (Compiler-ct.405 and
Tests-ct.412)
- Fix SyntaxErrorNotification>>#messageText (Compiler-ct.406)
- Fix two Compiler bugs (Compiler-ct.404 and Compiler-ct.407)
- SyntaxError: Preselect error message, and enable styling (Morphic-ct.1492
and Tools-ct.851)
- Implement #spawn on SearchBar (Tools-ct.850)
- Integrate TestRunner into Browser (SUnitTools-ct.5 and SUnitGUI-ct.70)
- Introduce context-dependent styling for Shout (ShoutCore-ct.66)
- Add Model>>#aboutToStyle:forMorph (ToolBuilder-Morphic-ct.228)
- Allow styling in Inspector's and Debugger's value panes (Tools-ct.852,
Tools-ct.853, and Tools-ct.854)

I would be very interested to know what is happening with them: Will anyone
review these changes, do you think they should be reworked? What are the
prerequisites for a commit to be released into Trunk? I am new to the
mailing list and not yet familiar with the usual processes. Should I always
write a separate email to ask for reviews?
I would be very happy about some feedback to my proposals! :)

Best,
Christoph



--
Sent from: http://forum.world.st/Squeak-Dev-f45488.html

Carpe Squeak!
Chris Muller-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: My pending contributions

Chris Muller-3
Hi Christoph,

Thanks for the submissions.  One consistent pattern I've noticed about this community is that it tends to slow down during the northern-hemisphere summer.  As far as process, you got it exactly right.  A trunk committer will review them and either commit them to trunk or propose a change.  After a few iterations of this, board will vote you to have trunk access directly, but it's still recommended to start out enhancements in the Inbox first.

In addition to reviewing code, what I generally like to do is put "time" to work _for_ me, by loading people's Inbox submissions into my image and just running and doing development with them for a while.  This tends to exercise the usability and also expose possible corner cases.  It also ensures they won't get "forgotten" before the next Squeak release, because they're marked a dirty package in the Monticello browser.

I'm sure someone will review them pretty soon.  Thanks and welcome to the community.

 - Chris


On Mon, Jul 29, 2019 at 1:00 PM Christoph Thiede <[hidden email]> wrote:
Hi all,

over the past weeks, I uploaded several proposals into the inbox. There are
a few commits that haven't been resolved yet:

- Implement SyntaxErrorNotification>>#resume: (Compiler-ct.405 and
Tests-ct.412)
- Fix SyntaxErrorNotification>>#messageText (Compiler-ct.406)
- Fix two Compiler bugs (Compiler-ct.404 and Compiler-ct.407)
- SyntaxError: Preselect error message, and enable styling (Morphic-ct.1492
and Tools-ct.851)
- Implement #spawn on SearchBar (Tools-ct.850)
- Integrate TestRunner into Browser (SUnitTools-ct.5 and SUnitGUI-ct.70)
- Introduce context-dependent styling for Shout (ShoutCore-ct.66)
- Add Model>>#aboutToStyle:forMorph (ToolBuilder-Morphic-ct.228)
- Allow styling in Inspector's and Debugger's value panes (Tools-ct.852,
Tools-ct.853, and Tools-ct.854)

I would be very interested to know what is happening with them: Will anyone
review these changes, do you think they should be reworked? What are the
prerequisites for a commit to be released into Trunk? I am new to the
mailing list and not yet familiar with the usual processes. Should I always
write a separate email to ask for reviews?
I would be very happy about some feedback to my proposals! :)

Best,
Christoph



--
Sent from: http://forum.world.st/Squeak-Dev-f45488.html
marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: My pending contributions

marcel.taeumel
In reply to this post by Christoph Thiede
Hi Christoph,

it's on my to-do list. ;-)

Best,
Marcel

Am 29.07.2019 20:00:07 schrieb Christoph Thiede <[hidden email]>:

Hi all,

over the past weeks, I uploaded several proposals into the inbox. There are
a few commits that haven't been resolved yet:

- Implement SyntaxErrorNotification>>#resume: (Compiler-ct.405 and
Tests-ct.412)
- Fix SyntaxErrorNotification>>#messageText (Compiler-ct.406)
- Fix two Compiler bugs (Compiler-ct.404 and Compiler-ct.407)
- SyntaxError: Preselect error message, and enable styling (Morphic-ct.1492
and Tools-ct.851)
- Implement #spawn on SearchBar (Tools-ct.850)
- Integrate TestRunner into Browser (SUnitTools-ct.5 and SUnitGUI-ct.70)
- Introduce context-dependent styling for Shout (ShoutCore-ct.66)
- Add Model>>#aboutToStyle:forMorph (ToolBuilder-Morphic-ct.228)
- Allow styling in Inspector's and Debugger's value panes (Tools-ct.852,
Tools-ct.853, and Tools-ct.854)

I would be very interested to know what is happening with them: Will anyone
review these changes, do you think they should be reworked? What are the
prerequisites for a commit to be released into Trunk? I am new to the
mailing list and not yet familiar with the usual processes. Should I always
write a separate email to ask for reviews?
I would be very happy about some feedback to my proposals! :)

Best,
Christoph



--
Sent from: http://forum.world.st/Squeak-Dev-f45488.html
Free forum by Nabble Edit this page