Smalltalk › Squeak › Squeak - Dev

Named serial port bug and how to contribute

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Ricardo Moran

Named serial port bug and how to contribute

Hi,

I think I found a bug with the named serial ports in windows.

I can open a named port without problem the first time but if I close it and try to open it again it fails until I restart the image. This doesn't happen with numeric ports. I could reproduce this bug in both Squeak5.2 and Pharo6.1 (both using windows 8.1).

I think the problem is that SerialPort>>#primClosePortByName: calls the "primitiveSerialPortCloseByName" but I couldn't find this primitive anywhere in the SerialPlugin source (https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/SerialPlugin/SerialPlugin.c). So I'm guessing that the port is never properly closed.

I added the missing primitive (find attached) and recompiled the vm, and now it seems to work. So my question is: how can I contribute this small fix? Should I commit to the VM Maker Inbox repository?

Thanks,

Richo

SerialPlugin-primitiveSerialPortCloseByName.st (454 bytes) Download Attachment

Levente Uzonyi

Re: Named serial port bug and how to contribute

Hi Richo,

Yes, the VMMaker Inbox is the right place for your fix.

Levente

On Thu, 29 Nov 2018, Ricardo Moran wrote:

> Hi,
>
> I think I found a bug with the named serial ports in windows.
> I can open a named port without problem the first time but if I close it and try to open it again it fails until I restart the image. This doesn't happen with numeric ports. I could reproduce this bug in both Squeak5.2 and Pharo6.1 (both using windows 8.1).
>
> I think the problem is that SerialPort>>#primClosePortByName: calls the "primitiveSerialPortCloseByName" but I couldn't find this primitive anywhere in the SerialPlugin source (https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/SerialPlugin/SerialPlugin.c).
> So I'm guessing that the port is never properly closed.
>
> I added the missing primitive (find attached) and recompiled the vm, and now it seems to work. So my question is: how can I contribute this small fix? Should I commit to the VM Maker Inbox repository?
>
> Thanks,
> Richo
>
>

Ricardo Moran

Re: Named serial port bug and how to contribute

Great! Thank you, Levente!

Richo

On Sun, Dec 2, 2018 at 10:41 AM Levente Uzonyi <[hidden email]> wrote:

Hi Richo,

Yes, the VMMaker Inbox is the right place for your fix.

Levente

On Thu, 29 Nov 2018, Ricardo Moran wrote:

> Hi,
>
> I think I found a bug with the named serial ports in windows.
> I can open a named port without problem the first time but if I close it and try to open it again it fails until I restart the image. This doesn't happen with numeric ports. I could reproduce this bug in both Squeak5.2 and Pharo6.1 (both using windows 8.1).
>
> I think the problem is that SerialPort>>#primClosePortByName: calls the "primitiveSerialPortCloseByName" but I couldn't find this primitive anywhere in the SerialPlugin source (https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/SerialPlugin/SerialPlugin.c).
> So I'm guessing that the port is never properly closed.
>
> I added the missing primitive (find attached) and recompiled the vm, and now it seems to work. So my question is: how can I contribute this small fix? Should I commit to the VM Maker Inbox repository?
>
> Thanks,
> Richo
>
>

Eliot Miranda-2

Re: Named serial port bug and how to contribute

In reply to this post by Ricardo Moran

Hi Richo,

Integrated and a new plugin has been generated. Thanks!!

_,,,^..^,,,_ (phone)

On Nov 29, 2018, at 5:25 PM, Ricardo Moran <[hidden email]> wrote:

Hi,

I think I found a bug with the named serial ports in windows.
I can open a named port without problem the first time but if I close it and try to open it again it fails until I restart the image. This doesn't happen with numeric ports. I could reproduce this bug in both Squeak5.2 and Pharo6.1 (both using windows 8.1).

I think the problem is that SerialPort>>#primClosePortByName: calls the "primitiveSerialPortCloseByName" but I couldn't find this primitive anywhere in the SerialPlugin source (https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/SerialPlugin/SerialPlugin.c). So I'm guessing that the port is never properly closed.

I added the missing primitive (find attached) and recompiled the vm, and now it seems to work. So my question is: how can I contribute this small fix? Should I commit to the VM Maker Inbox repository?

Thanks,
Richo

<SerialPlugin-primitiveSerialPortCloseByName.st>