NetNameResolver localHostAddress bug in trunk

> hello,
>
> something seems wrong in the trunk image concerning the new Network
> stuff, specifically in method NetNameResolver class>>#localHostAddress
>
> I have
>
> NetNameResolver addressForName: NetNameResolver localHostName
> => fe80::9d90:a71d:591f:29d3%21(Stef-PC),0(0)
>
> after sending #asByteArray it becomes #[80]
>
> while my proper and working local address is
>
> NetNameResolver primLocalAddress
> ==> #[92 153 174 111]
>
>
> Stef
>
>
>

>
> >hello,
> >
> >something seems wrong in the trunk image concerning the new Network
> >stuff, specifically in method NetNameResolver class>>#localHostAddress
> >
> >I have
> >
> >NetNameResolver addressForName: NetNameResolver localHostName
> >=> fe80::9d90:a71d:591f:29d3%21(Stef-PC),0(0)
> >
> >after sending #asByteArray it becomes #[80]
> >
> >while my proper and working local address is
> >
> >NetNameResolver primLocalAddress
> >==> #[92 153 174 111]
> >
> >
> >Stef
> >
> >
> >
>

> On Mon, Dec 17, 2012 at 06:53:10AM -0500, David T. Lewis wrote:
>>
>> There are some issues with IPV6 support, particularly on Windows, so
>> the Squeak 4.4 release image is being shipped with the IPV6 preference
>> disabled.
>>
>
> Oops, indeed there *is* something wrong. The Squeak4.4-12303 image
> has the IPV6 preference shown disabled in the preferences browser, but
>
>   NetNameResolver useOldNetwork ==> false
>
> It should be set true, so something must be wrong with the initialization
> of this preference in ReleaseBuilder.

> On 17 December 2012 12:02, David T. Lewis <[hidden email]> wrote:
> > On Mon, Dec 17, 2012 at 06:53:10AM -0500, David T. Lewis wrote:
> >>
> >> There are some issues with IPV6 support, particularly on Windows, so
> >> the Squeak 4.4 release image is being shipped with the IPV6 preference
> >> disabled.
> >>
> >
> > Oops, indeed there *is* something wrong. The Squeak4.4-12303 image
> > has the IPV6 preference shown disabled in the preferences browser, but
> >
> >   NetNameResolver useOldNetwork ==> false
> >
> > It should be set true, so something must be wrong with the initialization
> > of this preference in ReleaseBuilder.
>
> Hm, so "NetNameResolver enableIPv6: false" is insufficient? I should
> rather "NetNameResolver useOldNetwork: true", it looks like (because
> that's a definite "switch it off".

> On Mon, Dec 17, 2012 at 12:30:50PM +0000, Frank Shearar wrote:
>> On 17 December 2012 12:02, David T. Lewis <[hidden email]> wrote:
>> > On Mon, Dec 17, 2012 at 06:53:10AM -0500, David T. Lewis wrote:
>> >>
>> >> There are some issues with IPV6 support, particularly on Windows, so
>> >> the Squeak 4.4 release image is being shipped with the IPV6 preference
>> >> disabled.
>> >>
>> >
>> > Oops, indeed there *is* something wrong. The Squeak4.4-12303 image
>> > has the IPV6 preference shown disabled in the preferences browser, but
>> >
>> >   NetNameResolver useOldNetwork ==> false
>> >
>> > It should be set true, so something must be wrong with the initialization
>> > of this preference in ReleaseBuilder.
>>
>> Hm, so "NetNameResolver enableIPv6: false" is insufficient? I should
>> rather "NetNameResolver useOldNetwork: true", it looks like (because
>> that's a definite "switch it off".
>
> Yes I think that is better. But try browsing #enableIPv6: and some other
> methods in NetNameResolver. I'm getting errors with missing sources. Is
> something broken in the changes file?

> On 17 December 2012 13:04, David T. Lewis <[hidden email]> wrote:
> > On Mon, Dec 17, 2012 at 12:30:50PM +0000, Frank Shearar wrote:
> >> On 17 December 2012 12:02, David T. Lewis <[hidden email]> wrote:
> >> > On Mon, Dec 17, 2012 at 06:53:10AM -0500, David T. Lewis wrote:
> >> >>
> >> >> There are some issues with IPV6 support, particularly on Windows, so
> >> >> the Squeak 4.4 release image is being shipped with the IPV6 preference
> >> >> disabled.
> >> >>
> >> >
> >> > Oops, indeed there *is* something wrong. The Squeak4.4-12303 image
> >> > has the IPV6 preference shown disabled in the preferences browser, but
> >> >
> >> >   NetNameResolver useOldNetwork ==> false
> >> >
> >> > It should be set true, so something must be wrong with the initialization
> >> > of this preference in ReleaseBuilder.
> >>
> >> Hm, so "NetNameResolver enableIPv6: false" is insufficient? I should
> >> rather "NetNameResolver useOldNetwork: true", it looks like (because
> >> that's a definite "switch it off".
> >
> > Yes I think that is better. But try browsing #enableIPv6: and some other
> > methods in NetNameResolver. I'm getting errors with missing sources. Is
> > something broken in the changes file?
>
> That's odd. Do you see this with the shiny new RC at
> http://ftp.squeak.org/4.4/Squeak4.4-RC2.tgz ?

> On Mon, Dec 17, 2012 at 01:22:02PM +0000, Frank Shearar wrote:
>> On 17 December 2012 13:04, David T. Lewis <[hidden email]> wrote:
>> > On Mon, Dec 17, 2012 at 12:30:50PM +0000, Frank Shearar wrote:
>> >> On 17 December 2012 12:02, David T. Lewis <[hidden email]> wrote:
>> >> > On Mon, Dec 17, 2012 at 06:53:10AM -0500, David T. Lewis wrote:
>> >> >>
>> >> >> There are some issues with IPV6 support, particularly on Windows, so
>> >> >> the Squeak 4.4 release image is being shipped with the IPV6 preference
>> >> >> disabled.
>> >> >>
>> >> >
>> >> > Oops, indeed there *is* something wrong. The Squeak4.4-12303 image
>> >> > has the IPV6 preference shown disabled in the preferences browser, but
>> >> >
>> >> >   NetNameResolver useOldNetwork ==> false
>> >> >
>> >> > It should be set true, so something must be wrong with the initialization
>> >> > of this preference in ReleaseBuilder.
>> >>
>> >> Hm, so "NetNameResolver enableIPv6: false" is insufficient? I should
>> >> rather "NetNameResolver useOldNetwork: true", it looks like (because
>> >> that's a definite "switch it off".
>> >
>> > Yes I think that is better. But try browsing #enableIPv6: and some other
>> > methods in NetNameResolver. I'm getting errors with missing sources. Is
>> > something broken in the changes file?
>>
>> That's odd. Do you see this with the shiny new RC at
>> http://ftp.squeak.org/4.4/Squeak4.4-RC2.tgz ?
>
> No, it looks fine now in Squeak4.4-RC2.tgz :)
>
> Although we do still have:
>
>   NetNameResolver useOldNetwork ==> false
>
> Setting useOldNetwork to true will cause IPv6 support to be disabled. Too
> many double negatives I suppose ;)

> On 17 December 2012 14:12, David T. Lewis <[hidden email]> wrote:
> >
> > Setting useOldNetwork to true will cause IPv6 support to be disabled. Too
> > many double negatives I suppose ;)
>
> That makes sense, but I'm still confused, because both my little
> release script and ReleaseBuilder-fbs.85 set useOldNetwork to true.
>
> But NetNameResolver class >> #initiaize has "Smalltalk
> addToStartUpList: self", so could actually set useOldNetwork BACK to
> false even though the image was saved with value true?

> On Mon, Dec 17, 2012 at 02:59:23PM +0000, Frank Shearar wrote:
> > On 17 December 2012 14:12, David T. Lewis <[hidden email]> wrote:
> > >
> > > Setting useOldNetwork to true will cause IPv6 support to be disabled. Too
> > > many double negatives I suppose ;)
> >
> > That makes sense, but I'm still confused, because both my little
> > release script and ReleaseBuilder-fbs.85 set useOldNetwork to true.
> >
> > But NetNameResolver class >> #initiaize has "Smalltalk
> > addToStartUpList: self", so could actually set useOldNetwork BACK to
> > false even though the image was saved with value true?
>
> Yes that might be what is happening. And/or it may be that the preference
> needs to be initialized. I am away now but will try to have a look at it
> again later today.

> On Mon, Dec 17, 2012 at 01:15:12PM -0500, David T. Lewis wrote:
>> On Mon, Dec 17, 2012 at 02:59:23PM +0000, Frank Shearar wrote:
>> > On 17 December 2012 14:12, David T. Lewis <[hidden email]> wrote:
>> > >
>> > > Setting useOldNetwork to true will cause IPv6 support to be disabled. Too
>> > > many double negatives I suppose ;)
>> >
>> > That makes sense, but I'm still confused, because both my little
>> > release script and ReleaseBuilder-fbs.85 set useOldNetwork to true.
>> >
>> > But NetNameResolver class >> #initiaize has "Smalltalk
>> > addToStartUpList: self", so could actually set useOldNetwork BACK to
>> > false even though the image was saved with value true?
>>
>> Yes that might be what is happening. And/or it may be that the preference
>> needs to be initialized. I am away now but will try to have a look at it
>> again later today.
>
> Frank, I really have to apologize - I gave you a bunch of wrong information.
>
> You were correct all along to do "NetNameResolver enableIPv6: false". This
> sets the current value of the pragma preference for "Enable IPv6 and new
> network support". So setting this to false in ReleaseBuilder is the right
> thing to do.
>
> Contrary to what I said earlier, setting "NetNameResolver useOldNetwork: true"
> does *not* disable IPv6 permanently. It is a temporary flag that will be
> reset at image startup time based on the setting of the enableIPv6 preference,
> and also based on whether the VM provides the new IPv6 primitives, which
> is checked at image startup time.
>
> I do not see anywhere that NetNameResolver class>>initialize would be
> sent in normal use, so I do not think that is the problem.
>
> Bottom line: If you can do "NetNameResolver enableIPv6: false" prior to
> saving the image, this *should* set the preference correctly and it *should*
> cause the image to be restarted in the correct state regardless of VM.
>
> I really apologize for the (my) confusion. Next time you publish the
> release candidate, please do the "NetNameResolver enableIPv6: false"
> exactly as you had originally intended, and let's see if it comes out
> right this time around.

> On 18 December 2012 01:58, David T. Lewis <[hidden email]> wrote:
> > On Mon, Dec 17, 2012 at 01:15:12PM -0500, David T. Lewis wrote:
> >> On Mon, Dec 17, 2012 at 02:59:23PM +0000, Frank Shearar wrote:
> >> > On 17 December 2012 14:12, David T. Lewis <[hidden email]> wrote:
> >> > >
> >> > > Setting useOldNetwork to true will cause IPv6 support to be disabled. Too
> >> > > many double negatives I suppose ;)
> >> >
> >> > That makes sense, but I'm still confused, because both my little
> >> > release script and ReleaseBuilder-fbs.85 set useOldNetwork to true.
> >> >
> >> > But NetNameResolver class >> #initiaize has "Smalltalk
> >> > addToStartUpList: self", so could actually set useOldNetwork BACK to
> >> > false even though the image was saved with value true?
> >>
> >> Yes that might be what is happening. And/or it may be that the preference
> >> needs to be initialized. I am away now but will try to have a look at it
> >> again later today.
> >
> > Frank, I really have to apologize - I gave you a bunch of wrong information.
> >
> > You were correct all along to do "NetNameResolver enableIPv6: false". This
> > sets the current value of the pragma preference for "Enable IPv6 and new
> > network support". So setting this to false in ReleaseBuilder is the right
> > thing to do.
> >
> > Contrary to what I said earlier, setting "NetNameResolver useOldNetwork: true"
> > does *not* disable IPv6 permanently. It is a temporary flag that will be
> > reset at image startup time based on the setting of the enableIPv6 preference,
> > and also based on whether the VM provides the new IPv6 primitives, which
> > is checked at image startup time.
> >
> > I do not see anywhere that NetNameResolver class>>initialize would be
> > sent in normal use, so I do not think that is the problem.
> >
> > Bottom line: If you can do "NetNameResolver enableIPv6: false" prior to
> > saving the image, this *should* set the preference correctly and it *should*
> > cause the image to be restarted in the correct state regardless of VM.
> >
> > I really apologize for the (my) confusion. Next time you publish the
> > release candidate, please do the "NetNameResolver enableIPv6: false"
> > exactly as you had originally intended, and let's see if it comes out
> > right this time around.
>
> Thanks for everything, Dave. I've released a new version at
> http://ftp.squeak.org/4.4/Squeak4.4-RC3.tgz so let's see how that one
> works.

> It seems it get set to false every time NetNameResolver initializeNetwork
> is sent if the primitive NetNameResolver primHostNameSize does not fail.
>
> It should honor the preference, not the primitive.
>
> Karl
>
>
> On Tue, Dec 18, 2012 at 6:10 PM, David T. Lewis <[hidden email]> wrote:
>
> > On Tue, Dec 18, 2012 at 01:43:38PM +0000, Frank Shearar wrote:
> > > On 18 December 2012 01:58, David T. Lewis <[hidden email]> wrote:
> > > > On Mon, Dec 17, 2012 at 01:15:12PM -0500, David T. Lewis wrote:
> > > >> On Mon, Dec 17, 2012 at 02:59:23PM +0000, Frank Shearar wrote:
> > > >> > On 17 December 2012 14:12, David T. Lewis <[hidden email]>
> > wrote:
> > > >> > >
> > > >> > > Setting useOldNetwork to true will cause IPv6 support to be
> > disabled. Too
> > > >> > > many double negatives I suppose ;)
> > > >> >
> > > >> > That makes sense, but I'm still confused, because both my little
> > > >> > release script and ReleaseBuilder-fbs.85 set useOldNetwork to true.
> > > >> >
> > > >> > But NetNameResolver class >> #initiaize has "Smalltalk
> > > >> > addToStartUpList: self", so could actually set useOldNetwork BACK to
> > > >> > false even though the image was saved with value true?
> > > >>
> > > >> Yes that might be what is happening. And/or it may be that the
> > preference
> > > >> needs to be initialized. I am away now but will try to have a look at
> > it
> > > >> again later today.
> > > >
> > > > Frank, I really have to apologize - I gave you a bunch of wrong
> > information.
> > > >
> > > > You were correct all along to do "NetNameResolver enableIPv6: false".
> > This
> > > > sets the current value of the pragma preference for "Enable IPv6 and
> > new
> > > > network support". So setting this to false in ReleaseBuilder is the
> > right
> > > > thing to do.
> > > >
> > > > Contrary to what I said earlier, setting "NetNameResolver
> > useOldNetwork: true"
> > > > does *not* disable IPv6 permanently. It is a temporary flag that will
> > be
> > > > reset at image startup time based on the setting of the enableIPv6
> > preference,
> > > > and also based on whether the VM provides the new IPv6 primitives,
> > which
> > > > is checked at image startup time.
> > > >
> > > > I do not see anywhere that NetNameResolver class>>initialize would be
> > > > sent in normal use, so I do not think that is the problem.
> > > >
> > > > Bottom line: If you can do "NetNameResolver enableIPv6: false" prior to
> > > > saving the image, this *should* set the preference correctly and it
> > *should*
> > > > cause the image to be restarted in the correct state regardless of VM.
> > > >
> > > > I really apologize for the (my) confusion. Next time you publish the
> > > > release candidate, please do the "NetNameResolver enableIPv6: false"
> > > > exactly as you had originally intended, and let's see if it comes out
> > > > right this time around.
> > >
> > > Thanks for everything, Dave. I've released a new version at
> > > http://ftp.squeak.org/4.4/Squeak4.4-RC3.tgz so let's see how that one
> > > works.
> >
> > The preferences are set correctly now. But I took a quick look this morning
> > and I think I saw a case where the useOldNetwork flag got set back to
> > false,
> > so I am afraid that there must be a bug in the initialization somewhere
> > just
> > as you and St?phane had suggested earlier. I can't see where the problem is
> > happening, but something is not right. I'll try to take a better look at it
> > later today or tomorrow.
> >
> > :-/
> >
> > Dave
> >
> >
> >

>
> On Tue, Dec 18, 2012 at 06:31:49PM +0100, karl ramberg wrote:
> >
> > It seems it get set to false every time NetNameResolver initializeNetwork
> > is sent if the primitive NetNameResolver primHostNameSize does not fail.
> >
> > It should honor the preference, not the primitive.
> >
> > Karl
> >
> I think you have found the problem. Thanks :)
>