On my way down to plugins, I fixed a tiny mistake in VMMaker

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

On my way down to plugins, I fixed a tiny mistake in VMMaker

Niko Schwarz
I tried to understand slang, and walked some meters through VMMaker. I
had a fresh 3.8 basic image running and the current VMMaker installed
and guess what: VMMaker didn't work!

That is: VMMaker openInWorld wouldn't run, and VMMaker default wouldn't
run either.

The problem was that VMMaker called an unexisting method "wordSize". I
hope I fixed it, here's a changeset.

niko

'From Squeak3.8 of ''5 May 2005'' [latest update: #6665] on 12 July 2006 at 11:50:51 pm'!

!String methodsFor: 'converting' stamp: 'NES 7/12/2006 23:42'!
contains: aString
     "Answer, whether I contain aString, that is, whether aString is a bustring of myself."
    ^ ((self findString: aString) = 0) not! !


!VMMaker methodsFor: 'initialize' stamp: 'NES 7/12/2006 23:44'!
initialize
        logger := Transcript.
        inline := true.
        forBrowser := false.
        internalPlugins := SortedCollection new.
        externalPlugins := SortedCollection new.
        platformName := self class machinesDirName.
        is64BitVM := SmalltalkImage current platformSubtype contains: '64'.
        allFilesList := Dictionary new.
        interpreterClassName := Interpreter name! !



Reply | Threaded
Open this post in threaded view
|

Re: On my way down to plugins, I fixed a tiny mistake in VMMaker

Bert Freudenberg-3
Am 12.07.2006 um 23:55 schrieb Niko Schwarz:

> I tried to understand slang, and walked some meters through  
> VMMaker. I had a fresh 3.8 basic image running and the current  
> VMMaker installed and guess what: VMMaker didn't work!

Which VMMaker version was this?
>
> !String methodsFor: 'converting' stamp: 'NES 7/12/2006 23:42'!
> contains: aString
>      "Answer, whether I contain aString, that is, whether aString  
> is a bustring of myself."
>     ^ ((self findString: aString) = 0) not! !

Please do *not* lightly add such methods to base system classes.  
Almost certainly there is a method that already does what you need:

1. Open a Method Finder
2. Type in:
        'abcd'. 'bc'. true
3. Accept it (Cmd-S)
4. You get a list of messages matching this expression, amongst which  
you'll notice #includesSubString:


- Bert -


Reply | Threaded
Open this post in threaded view
|

Re: On my way down to plugins, I fixed a tiny mistake in VMMaker

David T. Lewis
In reply to this post by Niko Schwarz
On Wed, Jul 12, 2006 at 11:55:44PM +0200, Niko Schwarz wrote:
> I tried to understand slang, and walked some meters through VMMaker. I
> had a fresh 3.8 basic image running and the current VMMaker installed
> and guess what: VMMaker didn't work!
>
> That is: VMMaker openInWorld wouldn't run, and VMMaker default wouldn't
> run either.
>
> The problem was that VMMaker called an unexisting method "wordSize". I
> hope I fixed it, here's a changeset.
 
Hi Niko,

The #wordSize method first appeared in Squeak as part of the 64 bit
Squeak work by Ian and Dan. It does not really belong in the VMMaker
package, because it may be useful for lots of things other than
VMMaker.  If it's not in your image, it just means that you are
using an older image with a newer VMMaker.

Your changeset will work fine as a workaround, but I would suggest
that you just use a newer image for your VMMaker work. There may be
some other changes in the image that would be important (I'm not
sure), and a newer image will give you a better chance that VMMaker
and the platform sources will all play together nicely.

Dave