[OpenSmalltalk/opensmalltalk-vm] 081812: Make fullscreen mode consistent across Metal and O...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] 081812: Make fullscreen mode consistent across Metal and O...

Eliot Miranda-3
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 081812486daafb2ac25dbf7f448852189c933438
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/081812486daafb2ac25dbf7f448852189c933438
  Author: Fabio Niephaus <[hidden email]>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m
    M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m

  Log Message:
  -----------
  Make fullscreen mode consistent across Metal and OpenGL


  Commit: c25b8713647d8bba5264b792654747f7174b0eed
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c25b8713647d8bba5264b792654747f7174b0eed
  Author: Fabio Niephaus <[hidden email]>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m

  Log Message:
  -----------
  Minor Metal backend cleanups and improvements


  Commit: 6a0bc9626276dc58c20246adf5b2cd465af98402
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6a0bc9626276dc58c20246adf5b2cd465af98402
  Author: Fabio Niephaus <[hidden email]>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m

  Log Message:
  -----------
  Restore pumpRunLoopEventSendAndSignal: for Squeak

@guillep introduced some additional logic to filter out events that do not correspond to the VM window. The about panel and the fullscreen frame are also alien windows, but were not receiving any events because of this change. As a consequence, these events will forever remain in the queue and therefore, the buttons of the fullscreen frame and about panel cannot be clicked.
This commit reverts all changes back to the previous version that consumes all events and forwards them to NSApp.
In order to avoid breaking PharoVM, we do all of this behind an `#ifdef PharoVM`.

Relevant changes:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/295
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/300


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/1861db582c88...6a0bc9626276