Smalltalk › Squeak › Squeak VM

[OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Eliot Miranda-3

[OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 1e107be155f27df34f6578615984ab154a51efa4
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1e107be155f27df34f6578615984ab154a51efa4
Author: Tobias Pape <[hidden email]>
Date: 2020-09-16 (Wed, 16 Sep 2020)

Changed paths:
M platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c
M platforms/unix/plugins/MIDIPlugin/sqUnixMIDI.c
M platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c
M platforms/unix/vm-display-fbdev/sqUnixFBDev.c
M platforms/unix/vm/sqConfig.h
M platforms/unix/vm/sqUnixMemory.c
M platforms/unix/vm/sqUnixSpurMemory.c

Log Message:
-----------
[unix] Harmonize use of config.h

- prefer sq.h/sqConfig.h wherever sensible
- these should come early
- use HAVE_ tests to see if includes are necessary/available

Eliot Miranda-2

Re: [OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

Hi TObias,

cool stuff!! I'm hoping we can actually generate a single config.h file for each build.XXX directory and share it between all builds for that platform.

Can you please test a newspeak build on MacOS? That uses the FileCopyPlugin and currently your changes break the Mac build for that plugin.

On Wed, Sep 16, 2020 at 2:37 AM Tobias Pape <[hidden email]> wrote:

Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 1e107be155f27df34f6578615984ab154a51efa4
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1e107be155f27df34f6578615984ab154a51efa4
Author: Tobias Pape <[hidden email]>
Date: 2020-09-16 (Wed, 16 Sep 2020)

Changed paths:
M platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c
M platforms/unix/plugins/MIDIPlugin/sqUnixMIDI.c
M platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c
M platforms/unix/vm-display-fbdev/sqUnixFBDev.c
M platforms/unix/vm/sqConfig.h
M platforms/unix/vm/sqUnixMemory.c
M platforms/unix/vm/sqUnixSpurMemory.c

Log Message:
-----------
[unix] Harmonize use of config.h

- prefer sq.h/sqConfig.h wherever sensible
- these should come early
- use HAVE_ tests to see if includes are necessary/available

_,,,^..^,,,_

best, Eliot

timrowledge

Re: [OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

In reply to this post by Eliot Miranda-3

Seeing this -

> On 2020-09-16, at 2:37 AM, Tobias Pape <[hidden email]> wrote:
>
> M platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c

Reminds me that we are decades past when we should have dropped this plugin. Unfortunately we can't do that until we improve the file system stuff to be able to handle the file attributes when copying files.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Variables won't; constants aren't.

Tobias Pape

Re: [OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

In reply to this post by Eliot Miranda-2

Hi
> On 16.09.2020, at 17:31, Eliot Miranda <[hidden email]> wrote:
>
> Hi TObias,
>
> cool stuff!!

na.

> I'm hoping we can actually generate a single config.h file for each build.XXX directory and share it between all builds for that platform.
>
> Can you please test a newspeak build on MacOS? That uses the FileCopyPlugin and currently your changes break the Mac build for that plugin.

Humm. That the problem with that kind of reuse x.x
I'll see.
-t

>
> On Wed, Sep 16, 2020 at 2:37 AM Tobias Pape <[hidden email]> wrote:
>
> Branch: refs/heads/Cog
> Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
> Commit: 1e107be155f27df34f6578615984ab154a51efa4
> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1e107be155f27df34f6578615984ab154a51efa4
> Author: Tobias Pape <[hidden email]>
> Date: 2020-09-16 (Wed, 16 Sep 2020)
>
> Changed paths:
> M platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c
> M platforms/unix/plugins/MIDIPlugin/sqUnixMIDI.c
> M platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c
> M platforms/unix/vm-display-fbdev/sqUnixFBDev.c
> M platforms/unix/vm/sqConfig.h
> M platforms/unix/vm/sqUnixMemory.c
> M platforms/unix/vm/sqUnixSpurMemory.c
>
> Log Message:
> -----------
> [unix] Harmonize use of config.h
>
> - prefer sq.h/sqConfig.h wherever sensible
> - these should come early
> - use HAVE_ tests to see if includes are necessary/available

Tobias Pape

Re: [OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

> On 16.09.2020, at 19:29, Tobias Pape <[hidden email]> wrote:
>
>
> Hi
>> On 16.09.2020, at 17:31, Eliot Miranda <[hidden email]> wrote:
>>
>> Hi TObias,
>>
>> cool stuff!!
>
> na.
>
>
>> I'm hoping we can actually generate a single config.h file for each build.XXX directory and share it between all builds for that platform.
>>
>> Can you please test a newspeak build on MacOS? That uses the FileCopyPlugin and currently your changes break the Mac build for that plugin.
>
> Humm. That the problem with that kind of reuse x.x
> I'll see.

5ca742c20739ff5d55c9ab220707c6c6a85ff2dc should fix that. Not in a principled but a practical way…

-t

> -t
>
>>
>> On Wed, Sep 16, 2020 at 2:37 AM Tobias Pape <[hidden email]> wrote:
>>
>> Branch: refs/heads/Cog
>> Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
>> Commit: 1e107be155f27df34f6578615984ab154a51efa4
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1e107be155f27df34f6578615984ab154a51efa4
>> Author: Tobias Pape <[hidden email]>
>> Date: 2020-09-16 (Wed, 16 Sep 2020)
>>
>> Changed paths:
>> M platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c
>> M platforms/unix/plugins/MIDIPlugin/sqUnixMIDI.c
>> M platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c
>> M platforms/unix/vm-display-fbdev/sqUnixFBDev.c
>> M platforms/unix/vm/sqConfig.h
>> M platforms/unix/vm/sqUnixMemory.c
>> M platforms/unix/vm/sqUnixSpurMemory.c
>>
>> Log Message:
>> -----------
>> [unix] Harmonize use of config.h
>>
>> - prefer sq.h/sqConfig.h wherever sensible
>> - these should come early
>> - use HAVE_ tests to see if includes are necessary/available
>
>
>

Eliot Miranda-2

Re: [OpenSmalltalk/opensmalltalk-vm] 1e107b: [unix] Harmonize use of config.h

On Wed, Sep 16, 2020 at 11:14 AM Tobias Pape <[hidden email]> wrote:

Hi

> On 16.09.2020, at 19:29, Tobias Pape <[hidden email]> wrote:
>
>
> Hi
>> On 16.09.2020, at 17:31, Eliot Miranda <[hidden email]> wrote:
>>
>> Hi TObias,
>>
>> cool stuff!!
>
> na.
>
>
>> I'm hoping we can actually generate a single config.h file for each build.XXX directory and share it between all builds for that platform.
>>
>> Can you please test a newspeak build on MacOS? That uses the FileCopyPlugin and currently your changes break the Mac build for that plugin.
>
> Humm. That the problem with that kind of reuse x.x
> I'll see.

5ca742c20739ff5d55c9ab220707c6c6a85ff2dc should fix that. Not in a principled but a practical way…

thanks!!

-t

> -t
>
>>
>> On Wed, Sep 16, 2020 at 2:37 AM Tobias Pape <[hidden email]> wrote:
>>
>> Branch: refs/heads/Cog
>> Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
>> Commit: 1e107be155f27df34f6578615984ab154a51efa4
>> https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/1e107be155f27df34f6578615984ab154a51efa4
>> Author: Tobias Pape <[hidden email]>
>> Date: 2020-09-16 (Wed, 16 Sep 2020)
>>
>> Changed paths:
>> M platforms/unix/plugins/FileCopyPlugin/sqUnixFileCopyPlugin.c
>> M platforms/unix/plugins/MIDIPlugin/sqUnixMIDI.c
>> M platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c
>> M platforms/unix/vm-display-fbdev/sqUnixFBDev.c
>> M platforms/unix/vm/sqConfig.h
>> M platforms/unix/vm/sqUnixMemory.c
>> M platforms/unix/vm/sqUnixSpurMemory.c
>>
>> Log Message:
>> -----------
>> [unix] Harmonize use of config.h
>>
>> - prefer sq.h/sqConfig.h wherever sensible
>> - these should come early
>> - use HAVE_ tests to see if includes are necessary/available
>
>
>

_,,,^..^,,,_

best, Eliot