[OpenSmalltalk/opensmalltalk-vm] 21375-Add-FileAttributesPlugin-to-stack-and-lowcode-VMs (#218)

 

Add FileAttributesPlugin to any remaining VM that already includes
FilePlugin.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218

Commit Summary

• 21375-Add-FileAttributesPlugin-to-stack-and-lowcode-VMs

File Changes

• M build.linux32x86/pharo.cog.spur.lowcode/plugins.ext (1)
• M build.linux32x86/pharo.stack.spur.lowcode/plugins.ext (1)
• M build.macos32x86/pharo.cog.spur.lowcode/plugins.ext (1)
• M build.macos32x86/pharo.stack.spur.lowcode/plugins.ext (1)
• M build.macos32x86/pharo.stack.spur/plugins.ext (1)
• M build.macos64x64/pharo.cog.spur.lowcode/plugins.ext (1)
• M build.macos64x64/pharo.stack.spur.lowcode/plugins.ext (1)
• M build.macos64x64/pharo.stack.spur/plugins.ext (1)
• M build.win32x86/pharo.cog.spur.lowcode/plugins.ext (3)
• M build.win64x64/pharo.stack.spur/plugins.ext (3)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"21375-Add-FileAttributesPlugin-to-stack-and-lowcode-VMs (#218)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218"}}}</script>

 

The appveyor failure was a squeak build, which doesn't include FileAttributesPlugin, and looks like it was a failure to download cygwin related files. This PR should be good to go...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #218: The appveyor failure was a squeak build, which doesn't include FileAttributesPlugin, and looks like it was a failure to download cygwin related files. This PR should be good to go..."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218#issuecomment-366957750"}}}</script>

 

Fogbugz: https://pharo.fogbugz.com/f/cases/21375/

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #218: Fogbugz: https://pharo.fogbugz.com/f/cases/21375/"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218#issuecomment-366957879"}}}</script>

 

The appveyor failure was a squeak build, which doesn't include FileAttributesPlugin, and looks like it was a failure to download cygwin related files. This PR should be good to go...

Thanks for the info. I've fixed the problem that caused Pharo builds to fail on PRs in the meantime.

Merging this now, assuming @eliotmiranda and @estebanlm are ok with that...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@fniephaus in #218: \u003e The appveyor failure was a squeak build, which doesn't include FileAttributesPlugin, and looks like it was a failure to download cygwin related files. This PR should be good to go...\r\n\r\nThanks for the info. I've fixed the problem that caused Pharo builds to fail on PRs in the meantime.\r\n\r\nMerging this now, assuming @eliotmiranda and @estebanlm are ok with that..."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218#issuecomment-366962490"}}}</script>

 

Merged #218.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #218."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218#event-1482298938"}}}</script>

 

Merging this now, assuming @eliotmiranda and @estebanlm are ok with that...

Thanks @fniephaus !

I checked with @estebanlm before submitting the PR.

I didn't check with @eliotmiranda, but this doesn't change the VM, just the pharo build on some platforms, so hope that is OK.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #218: \u003e Merging this now, assuming @eliotmiranda and @estebanlm are ok with that...\r\n\r\nThanks @fniephaus !\r\n\r\nI checked with @estebanlm before submitting the PR.\r\n\r\nI didn't check with @eliotmiranda, but this doesn't change the VM, just the pharo build on some platforms, so hope that is OK."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/218#issuecomment-366968769"}}}</script>