…not available
According to the comment for primitiveFileStdioHandles():
Answer an Array of file handles for standard in, standard out and
standard error, with nil in entries that are unvailable, e.g. because
the platform does not provide standard error, etc.
However, on Windows in practice an array of sqFile entries with null
handles is returned. The image is unable to distinguish between valid
and invalid entries since sqFile is private to the VM.
- Modify sqWin32FilePrims.c() to set the valid mask correctly.
- Modify primitiveFileStdioHandles() to treat a mask of 0 as
successfully determining that no stdio is available (a normal case
on Windows).
A validMask of -1 is treated as an error.
- Update comments to reflect changed behaviour
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276
Commit Summary
- 274 primitiveFileStdioHandles() fails to return nil if stdio file is not available
File Changes
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"274 primitiveFileStdioHandles() fails to return nil if stdio file is … (#276)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "274 primitiveFileStdioHandles() fails to return nil if stdio file is … (#276)",
"sections": [
{
"text": "",
"activityTitle": "**akgrant43**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@akgrant43",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "2f91655",
"value": "274 primitiveFileStdioHandles() fails to return nil if stdio file is not available"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-0) (12 changes)"
},
{
"name": "Modified",
"value": "[platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-1) (11 changes)"
},
{
"name": "Modified",
"value": "[platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-2) (31 changes)"
},
{
"name": "Modified",
"value": "[src/plugins/FilePlugin/FilePlugin.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-3) (28 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 276,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 276\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 367372467\n}"
}
],
"themeColor": "26292E"
}
]</script>
Locked
