[OpenSmalltalk/opensmalltalk-vm] 662580: primitiveFileAtEnd / sqFileAtEnd stdio handling

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] 662580: primitiveFileAtEnd / sqFileAtEnd stdio handling

Eliot Miranda-3
 
  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 66258042e466f7bd71c5188619863bc38a3d9a00
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/66258042e466f7bd71c5188619863bc38a3d9a00
  Author: AlistairGrant <[hidden email]>
  Date:   2018-04-08 (Sun, 08 Apr 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  primitiveFileAtEnd / sqFileAtEnd stdio handling

Modify sqFileAtEnd (primitiveFileAtEnd) so that:

- stdout & stderr always return false
  feof() isn't valid on these files.
- Don't peek if stdin is a terminal
  We don't want to block in this case.
- Don't peek if already at end
  There's no need.


  Commit: 6bee4d2946da0f2b6ae61cc8c4d8d9efb2cc4263
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6bee4d2946da0f2b6ae61cc8c4d8d9efb2cc4263
  Author: akgrant43 <[hidden email]>
  Date:   2018-04-09 (Mon, 09 Apr 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c

  Log Message:
  -----------
  Merge pull request #243 from akgrant43/AtEndMkII

primitiveFileAtEnd / sqFileAtEnd stdio handling

- stdout & stderr always return false
  feof() isn't valid on these files.
- Don't peek if stdin is a terminal
  We don't want to block in this case.
- Don't peek if already at end
  There's no need.


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/03130f75d3f3...6bee4d2946da