Smalltalk › Squeak › Squeak VM

[OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

56 messages Options

123

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

@VincentBlondeau pushed 1 commit.

0ec7f5d Renaming of the primitive + change return value

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

That should do it with these adds.
However, I do not know how to test if pipes or files are used under windows.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

Hi Vincent,

In cygwin you can test pipes with:

$ cat | PharoConsole Pharo7.0.image | tee /dev/null

It's also a hacky way to get terminal i/o working in a cygwin terminal.

In a windows console:

echo "hello world" | PharoConsole Pharo7.0.image

Should allow you to test stdin at least (untested).

In both cygwin terminals and windows consoles file i/o can be tested with:

PharoConsole Pharo7.0.image < a.txt > b.txt

HTH,
Alistair

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

That's helping!
Tested and working!

Thanks Alistair!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

@akgrant43 commented on this pull request.

One minor fix for RiscOS and this is good to go (I'll update the code for Unix after this has been integrated).

In platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c:

> @@ -407,6 +407,11 @@ sqInt sqFileStdioHandlesInto(SQFile files[3]) {
 	return 0;
 }
 
+sqInt sqFileDescriptorType(int fdNum) {
+	//Not implemented
+	return 0;

RiscOS should return -1 (error), not 0 (no console).

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

@VincentBlondeau pushed 1 commit.

48101cd Return Error for RiskOS

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

@akgrant43 approved this pull request.

Build failures are unrelated.

I'll wait 24 hours before merging in case anyone else wants to comment.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

timrowledge

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

> On 11-05-2018, at 10:36 AM, akgrant43 <[hidden email]> wrote:
>
> In platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c:

Nice to see someone else caring for RISC OS :-)

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful Latin Phrases:- Anulos qui animum ostendunt omnes gestemus! = Let's all wear mood rings!

David T. Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

On Fri, May 11, 2018 at 02:53:28PM -0700, tim Rowledge wrote:

>
>
>
> > On 11-05-2018, at 10:36 AM, akgrant43 <[hidden email]> wrote:
> >
> > In platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c:
>
>
> Nice to see someone else caring for RISC OS :-)
>
> tim

Yay!

Dave

NorbertHartl

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by timrowledge

> Am 11.05.2018 um 23:53 schrieb tim Rowledge <[hidden email]>:
>
>
>
>
>> On 11-05-2018, at 10:36 AM, akgrant43 <[hidden email]> wrote:
>>
>> In platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c:
>
>
> Nice to see someone else caring for RISC OS :-)
>

Yes, but what for?

Norbert

David T. Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

On Sat, May 12, 2018 at 10:42:54AM +0200, Norbert Hartl wrote:

>
>
>
> > Am 11.05.2018 um 23:53 schrieb tim Rowledge <[hidden email]>:
> >
> >
> >
> >
> >> On 11-05-2018, at 10:36 AM, akgrant43 <[hidden email]> wrote:
> >>
> >> In platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c:
> >
> >
> > Nice to see someone else caring for RISC OS :-)
> >
> Yes, but what for?
>

Because portability of the VM is important, and RISC OS is the only
supported platform that is not a Unix derivative. Even the Windows
VM looks rather unixy from the VM point of view.

The only way to know if something is portable is to actually port it.

SqueakJS is another useful reference point in this regard.

Dave

timrowledge

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

> On 12-05-2018, at 6:57 AM, David T. Lewis <[hidden email]> wrote:
>
>
> On Sat, May 12, 2018 at 10:42:54AM +0200, Norbert Hartl wrote:
>>
>>
>>
>>> Am 11.05.2018 um 23:53 schrieb tim Rowledge <[hidden email]>:
>>>
>>>
>>>
>>>
>>>> On 11-05-2018, at 10:36 AM, akgrant43 <[hidden email]> wrote:
>>>>
>>>> In platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c:
>>>
>>>
>>> Nice to see someone else caring for RISC OS :-)
>>>
>> Yes, but what for?
>>
>
> Because portability of the VM is important, and RISC OS is the only
> supported platform that is not a Unix derivative. Even the Windows
> VM looks rather unixy from the VM point of view.
>
> The only way to know if something is portable is to actually port it.
>
> SqueakJS is another useful reference point in this regard.

Almost exactly what I was about to reply but with less wounded pride in The One True Operating System :-) RISC OS has always had that value even to Squeakers that are unfortunate enough not to use it; it is *different* and thus makes us think a bit more carefully about portability. It's like having users that use non-English-like languages; a reminder that not everyone is the same boring sort or person.

I really hope to get to making at least a stackVM for RISC OS sometime soon, and then maybe even a proper Cog vm. After all the Pi cog works really well and all that should simply copy over. It's mostly the 'fun' of setting up a new make system and (re)finding all the places where something isn't yet portable.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Compromise, says Prof. Trefusis, is stalling between two fools

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

@VincentBlondeau pushed 1 commit.

82d6abc Use methodReturn***: instead of pop: + push***: in FilePlugin

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

@akgrant43 : Are the changes I made ok to be integrated?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

Merged #254.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

David T Lewis

Re: [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

In reply to this post by David T Lewis

Hi Vincent,

Are the changes I made ok to be integrated?

Yes :-) Sorry, I'm not getting much Pharo time at the moment.

Cheers,
Alistair

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

123