[OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
 

adds the minheadless sources from @ronsaldo + my own changes.
this is still WIP (is working for Mac and Linux but not for Win), but to be honest, I want this integrated before the structure reorganisation so I do not need to do it myself after ;)


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298

Commit Summary

  • Starting to make a build without the windowing stuff.
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into MinimalisticHeadless
  • I am starting to load a basic image with the minimalistic vm (crashing).
  • Oops.
  • I keep doing this refactoring.
  • The completely headless VM is starting to work in Linux.
  • Now I am building more plugins.
  • I am starting to implement a SDL2 based Window backend for compatibility.
  • The SDL2 based window backend is now usable.
  • I am starting to compile the VM using Visual Studio in Windows (via projects generated by CMake).
  • The minimalistic headless VM is starting to work in Windows.
  • I keep working on making this work on Windows.
  • Minor change.
  • I am cleaning the Win32 security plugin unicode mess.
  • I added the missing files from the previous commit.
  • Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless
  • Adding some const to char*.
  • I am starting to generate the config.h using CMake.
  • Oops, missing file from the last commit.
  • I am starting to generate the config.h. Building and working in Linux.
  • Only use the -pthread option in Unixes.
  • I managed to get the FFI working back with MinGW. I was missing some flags in the CMake scripts. I still need to get this working with MSVC.
  • Minor change to the cmake files.
  • Minor changes for OSX.
  • Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless
  • The minheadless VM is now working on OS X.
  • Minheadless VM is now working on Windows with SDL2.
  • Oops.
  • I refactored the windowing system for choosing between the null window system and the SDL2 based system depending wheter the VM was executed in headless mode or not.
  • I keep working on the SDL2 backend.
  • Use a SDL2 hint instead of restoring the signal handlers for sigint and sigterm.
  • I added missing flags to the cmake building scripts.
  • I implemented legacy file dropping support with the SDL2 backend.
  • I started to create the initial version of the embedding interface.
  • I added back some floating point flags to the minheadless vm.
  • I added back the processor relinquishing in the Windows Minheadless vm.
  • I fixed a minor bug when using the SDL2 based window and Alt-Gr+Key combination.
  • Merge branch 'Cog' into MinimalisticHeadless
  • Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless
  • I refactored the locations of the files composing the minheadless favlour of the VM.
  • I removed the old FFI workaround in Windows.
  • I fixed the VirtualProtect failure in Windows. The size was not being computed in the correct way.
  • I fixed the errors when calling mprotect with the spur memory manager.
  • Oops.
  • I added back the stack trace printing to the Unix version of the Minheadless favlour.
  • I fixed the stack trace printing in OS X when in the Minheadless favlour.
  • I added back the stack trace to the Windows version of the Minheadless VM Favlour.
  • Swapping some lines before mprotect call.
  • I fixed some compilation errors with the original Windows compilation scripts. I added some convenience scripts for building the different variants.
  • Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless
  • I added some missing execution permissions.
  • Fixing the building of some VM variants when using CMake for the minheadless VM.
  • Set more lf eol attributes.
  • I am fixing the build scripts for Cygwin.
  • Restore the OpenGL context whenever we use a SDL2 renderer in legacy display mode.
  • Removing the hack for getting the Git version string by using CMake.
  • Merge branch 'Cog' into MinimalisticHeadless
  • Adding missing toolchain files.
  • Cleaning a bit the coding style. Fixing a bug after merging the upstream Cog branch.
  • Use the osvm prefix instead of squeak for the public interface.
  • Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless
  • Fixing some coding style issues.
  • Merge pull request #1 from ronsaldo/MinimalisticHeadless
  • makefiles for build minheadless on macOS
  • add EXTRAVMLIBS
  • pharo minheadless for macOS (i386 and x86) working
  • Adding the rest of the Pharo plugins to the cmake building scripts.
  • Merge pull request #2 from ronsaldo/add-minheadless-vm
  • pharo minheadless for linux (i386 and x86) threaded hearbeat working
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • fixes
  • Merge branch 'Cog' into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • update freetype to 2.9.1
  • update libSDL to 2.0.7
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • update paths
  • Merge branch 'update-libsdl-and-freetype' into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm
  • Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add minheadless vm (#298)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**Esteban Lorenzano**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@estebanlm", "facts": [ ] }, { "title": "Commit Summary", "facts": [ { "name": "db5df21", "value": "Starting to make a build without the windowing stuff." }, { "name": "2e08c1c", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into MinimalisticHeadless" }, { "name": "19dc739", "value": "I am starting to load a basic image with the minimalistic vm (crashing)." }, { "name": "1b3cd47", "value": "Oops." }, { "name": "8b8d8e5", "value": "I keep doing this refactoring." }, { "name": "479e27d", "value": "The completely headless VM is starting to work in Linux." }, { "name": "ff4e4c8", "value": "Now I am building more plugins." }, { "name": "5ab9173", "value": "I am starting to implement a SDL2 based Window backend for compatibility." }, { "name": "69c9760", "value": "The SDL2 based window backend is now usable." }, { "name": "4d9943d", "value": "I am starting to compile the VM using Visual Studio in Windows (via projects generated by CMake)." }, { "name": "88c60ff", "value": "The minimalistic headless VM is starting to work in Windows." }, { "name": "b813bda", "value": "I keep working on making this work on Windows." }, { "name": "b53b330", "value": "Minor change." }, { "name": "2a6304d", "value": "I am cleaning the Win32 security plugin unicode mess." }, { "name": "f598e84", "value": "I added the missing files from the previous commit." }, { "name": "69626c0", "value": "Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless" }, { "name": "c49e0a4", "value": "Adding some const to char*." }, { "name": "6ce327e", "value": "I am starting to generate the config.h using CMake." }, { "name": "088a46a", "value": "Oops, missing file from the last commit." }, { "name": "96597c8", "value": "I am starting to generate the config.h. Building and working in Linux." }, { "name": "5d5d208", "value": "Only use the -pthread option in Unixes." }, { "name": "8cc3989", "value": "I managed to get the FFI working back with MinGW. I was missing some flags in the CMake scripts. I still need to get this working with MSVC." }, { "name": "1e691c2", "value": "Minor change to the cmake files." }, { "name": "5df2678", "value": "Minor changes for OSX." }, { "name": "d342f83", "value": "Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless" }, { "name": "14bf4b5", "value": "The minheadless VM is now working on OS X." }, { "name": "3f77fde", "value": "Minheadless VM is now working on Windows with SDL2." }, { "name": "dd46e8f", "value": "Oops." }, { "name": "a488e47", "value": "I refactored the windowing system for choosing between the null window system and the SDL2 based system depending wheter the VM was executed in headless mode or not." }, { "name": "2023f88", "value": "I keep working on the SDL2 backend." }, { "name": "ba42788", "value": "Use a SDL2 hint instead of restoring the signal handlers for sigint and sigterm." }, { "name": "8421169", "value": "I added missing flags to the cmake building scripts." }, { "name": "2786fea", "value": "I implemented legacy file dropping support with the SDL2 backend." }, { "name": "ab144bf", "value": "I started to create the initial version of the embedding interface." }, { "name": "a079d4a", "value": "I added back some floating point flags to the minheadless vm." }, { "name": "f597d1a", "value": "I added back the processor relinquishing in the Windows Minheadless vm." }, { "name": "5a64fcb", "value": "I fixed a minor bug when using the SDL2 based window and Alt-Gr+Key combination." }, { "name": "2ecf11d", "value": "Merge branch 'Cog' into MinimalisticHeadless" }, { "name": "48bed59", "value": "Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless" }, { "name": "2b501f9", "value": "I refactored the locations of the files composing the minheadless favlour of the VM." }, { "name": "bfec17c", "value": "I removed the old FFI workaround in Windows." }, { "name": "6c8d8ca", "value": "I fixed the VirtualProtect failure in Windows. The size was not being computed in the correct way." }, { "name": "9735d99", "value": "I fixed the errors when calling mprotect with the spur memory manager." }, { "name": "39bdfe6", "value": "Oops." }, { "name": "9716474", "value": "I added back the stack trace printing to the Unix version of the Minheadless favlour." }, { "name": "46351c0", "value": "I fixed the stack trace printing in OS X when in the Minheadless favlour." }, { "name": "8714ffa", "value": "I added back the stack trace to the Windows version of the Minheadless VM Favlour." }, { "name": "9ac7ec8", "value": "Swapping some lines before mprotect call." }, { "name": "ee8be2e", "value": "I fixed some compilation errors with the original Windows compilation scripts. I added some convenience scripts for building the different variants." }, { "name": "cb54071", "value": "Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless" }, { "name": "e76d861", "value": "I added some missing execution permissions." }, { "name": "8f0d8bb", "value": "Fixing the building of some VM variants when using CMake for the minheadless VM." }, { "name": "a94e640", "value": "Set more lf eol attributes." }, { "name": "4828318", "value": "I am fixing the build scripts for Cygwin." }, { "name": "008052c", "value": "Restore the OpenGL context whenever we use a SDL2 renderer in legacy display mode." }, { "name": "5a77bd6", "value": "Removing the hack for getting the Git version string by using CMake." }, { "name": "0150b72", "value": "Merge branch 'Cog' into MinimalisticHeadless" }, { "name": "787b416", "value": "Adding missing toolchain files." }, { "name": "21cc02b", "value": "Cleaning a bit the coding style. Fixing a bug after merging the upstream Cog branch." }, { "name": "696a9e2", "value": "Use the osvm prefix instead of squeak for the public interface." }, { "name": "509e272", "value": "Merge branch 'MinimalisticHeadless' of github.com:ronsaldo/opensmalltalk-vm into MinimalisticHeadless" }, { "name": "be7b1c0", "value": "Fixing some coding style issues." }, { "name": "83d0572", "value": "Merge pull request #1 from ronsaldo/MinimalisticHeadless" }, { "name": "e816454", "value": "makefiles for build minheadless on macOS" }, { "name": "c51dff5", "value": "add EXTRAVMLIBS" }, { "name": "8725f36", "value": "pharo minheadless for macOS (i386 and x86) working" }, { "name": "bfa99ff", "value": "Adding the rest of the Pharo plugins to the cmake building scripts." }, { "name": "c77dc52", "value": "Merge pull request #2 from ronsaldo/add-minheadless-vm" }, { "name": "5f5e924", "value": "pharo minheadless for linux (i386 and x86) threaded hearbeat working" }, { "name": "9105ae2", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "25d0c0f", "value": "fixes" }, { "name": "d22c909", "value": "Merge branch 'Cog' into add-minheadless-vm" }, { "name": "cc1673d", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "11dfaf8", "value": "Merge branch 'Cog' into add-minheadless-vm" }, { "name": "4f338ee", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "f2920b9", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "fdbe9ce", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "e122f1c", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "5ce9f5f", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "bd5ba90", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "ba91653", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "c45e0d1", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "233b394", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "9dedc37", "value": "update freetype to 2.9.1" }, { "name": "8e3e6b6", "value": "update libSDL to 2.0.7" }, { "name": "7dd0dff", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "15d0675", "value": "update paths" }, { "name": "9f168a3", "value": "Merge branch 'update-libsdl-and-freetype' into add-minheadless-vm" }, { "name": "8c99c8f", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" }, { "name": "db7ec7b", "value": "Merge branch 'Cog' of github.com:OpenSmalltalk/opensmalltalk-vm into add-minheadless-vm" } ] }, { "title": "File Changes", "facts": [ { "name": "Added", "value": "[.clang_complete](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-0) (9 changes)" }, { "name": "Modified", "value": "[.gitattributes](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-1) (3 changes)" }, { "name": "Added", "value": "[CMakeLists.txt](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-2) (559 changes)" }, { "name": "Added", "value": "[build.linux32x86/pharo.cog.spur.minheadless/build.assert.itimerheartbeat/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-3) (37 changes)" }, { "name": "Added", "value": "[build.linux32x86/pharo.cog.spur.minheadless/build.assert/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-4) (50 changes)" }, { "name": "Added", "value": "[build.linux32x86/pharo.cog.spur.minheadless/build.debug.itimerheartbeat/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-5) (37 changes)" }, { "name": "Added", "value": "[build.linux32x86/pharo.cog.spur.minheadless/build.itimerheartbeat/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-6) (60 changes)" }, { "name": "Added", "value": "[build.linux32x86/pharo.cog.spur.minheadless/build/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-7) (51 changes)" }, { "name": "Added", "value": "[build.linux32x86/pharo.cog.spur.minheadless/makeallclean](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-8) (15 changes)" }, { "name": "Added", "value": "[build.linux32x86/pharo.cog.spur.minheadless/makealldirty](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-9) (15 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/build.assert.itimerheartbeat/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-10) (37 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/build.assert/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-11) (41 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/build.debug.itimerheartbeat/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-12) (37 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/build.debug/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-13) (41 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/build.itimerheartbeat/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-14) (60 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/build/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-15) (41 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/makeallclean](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-16) (15 changes)" }, { "name": "Added", "value": "[build.linux64x64/pharo.cog.spur.minheadless/makealldirty](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-17) (15 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.app](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-18) (190 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.app.newspeak](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-19) (29 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.app.squeak](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-20) (22 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.clangversion](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-21) (26 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.flags](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-22) (56 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.lib.extra](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-23) (33 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.plugin](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-24) (243 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.rules](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-25) (34 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.sources](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-26) (24 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/Makefile.vm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-27) (299 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/mkInternalPluginsList.sh](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-28) (11 changes)" }, { "name": "Added", "value": "[build.macos32x86/common.minheadless/mkNamedPrims.sh](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-29) (24 changes)" }, { "name": "Added", "value": "[build.macos32x86/pharo.cog.spur.minheadless/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-30) (35 changes)" }, { "name": "Added", "value": "[build.macos32x86/pharo.cog.spur.minheadless/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-31) (32 changes)" }, { "name": "Added", "value": "[build.macos32x86/pharo.cog.spur.minheadless/plugins.ext](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-32) (27 changes)" }, { "name": "Added", "value": "[build.macos32x86/pharo.cog.spur.minheadless/plugins.int](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-33) (28 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/common/Toolchain-mingw32-cygwin.cmake](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-34) (21 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/common/configure_variant.sh](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-35) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.cog.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-36) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.cog.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-37) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.cog.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-38) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.cog.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-39) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.stack.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-40) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.stack.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-41) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.stack.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-42) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/pharo.stack.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-43) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.cog.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-44) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.cog.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-45) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.cog.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-46) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.cog.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-47) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.stack.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-48) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.stack.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-49) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.stack.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-50) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x64/squeak.stack.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-51) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/common/Toolchain-mingw32-cygwin.cmake](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-52) (21 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/common/configure_variant.sh](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-53) (24 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.cog.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-54) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.cog.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-55) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.cog.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-56) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.cog.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-57) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.stack.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-58) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.stack.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-59) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.stack.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-60) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/pharo.stack.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-61) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.cog.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-62) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.cog.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-63) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.cog.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-64) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.cog.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-65) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.stack.spur/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-66) (18 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.stack.spur/mvm](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-67) (4 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.stack.spur/mvm_configure](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-68) (6 changes)" }, { "name": "Added", "value": "[build.minheadless.cmake/x86/squeak.stack.spur/mvm_configure_variant](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-69) (4 changes)" }, { "name": "Added", "value": "[cmake/Mpeg3Plugin.cmake](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-70) (44 changes)" }, { "name": "Added", "value": "[cmake/Plugins.cmake](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-71) (119 changes)" }, { "name": "Added", "value": "[cmake/PluginsPharo.cmake](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-72) (59 changes)" }, { "name": "Added", "value": "[include/OpenSmalltalkVM.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-73) (148 changes)" }, { "name": "Modified", "value": "[platforms/Cross/vm/sq.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-74) (12 changes)" }, { "name": "Modified", "value": "[platforms/Cross/vm/sqAssert.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-75) (43 changes)" }, { "name": "Added", "value": "[platforms/Cross/vm/sqCircularQueue.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-76) (62 changes)" }, { "name": "Added", "value": "[platforms/Cross/vm/sqPath.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-77) (135 changes)" }, { "name": "Added", "value": "[platforms/Cross/vm/sqPath.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-78) (42 changes)" }, { "name": "Added", "value": "[platforms/Cross/vm/sqTextEncoding.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-79) (191 changes)" }, { "name": "Added", "value": "[platforms/Cross/vm/sqTextEncoding.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-80) (39 changes)" }, { "name": "Added", "value": "[platforms/iOS/plugins/FilePlugin/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-81) (3 changes)" }, { "name": "Added", "value": "[platforms/iOS/plugins/FilePlugin/sqUnixFile.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-82) (361 changes)" }, { "name": "Removed", "value": "[platforms/iOS/plugins/SecurityPlugin/sqMacSecurity.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-83) (272 changes)" }, { "name": "Added", "value": "[platforms/iOS/plugins/SecurityPlugin/sqUnixSecurity.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-84) (208 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/English.lproj/Newspeak-Localizable.strings](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-85) (3 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/English.lproj/Pharo-Localizable.strings](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-86) (3 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/English.lproj/Squeak-Localizable.strings](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-87) (9 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/debug.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-88) (6 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/glibc.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-89) (37 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/mac-alias.inc](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-90) (42 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqConfig.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-91) (21 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqEventCommon.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-92) (50 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqEventCommon.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-93) (64 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqExternalPrimitives.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-94) (252 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqExternalPrimitives.c.orig](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-95) (241 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqInternalPrimitives.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-96) (74 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqMain.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-97) (34 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqNamedPrims.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-98) (1 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqPlatformSpecific.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-99) (43 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqPlatformSpecificCommon.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-100) (71 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqPrinting.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-101) (313 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqVirtualMachineInterface.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-102) (654 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqWindow-Dispatch.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-103) (286 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqWindow-Null.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-104) (271 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqWindow.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-105) (81 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/sqaio.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-106) (125 changes)" }, { "name": "Added", "value": "[platforms/minheadless/common/version.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-107) (25 changes)" }, { "name": "Added", "value": "[platforms/minheadless/config.h.in](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-108) (192 changes)" }, { "name": "Added", "value": "[platforms/minheadless/generic/sqPlatformSpecific-Generic.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-109) (270 changes)" }, { "name": "Added", "value": "[platforms/minheadless/generic/sqPlatformSpecific-Generic.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-110) (1 changes)" }, { "name": "Added", "value": "[platforms/minheadless/sdl2-window/sqWindow-SDL2.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-111) (1186 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/BlueSistaSqueak.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-112) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/GreenCogSqueak.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-113) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/NewspeakDocuments.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-114) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/NewspeakVirtualMachine.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-115) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/Pharo-Info.plist](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-116) (538 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/Pharo.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-117) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/PharoChanges.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-118) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/PharoImage.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-119) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/PharoSources.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-120) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/Squeak.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-121) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/SqueakChanges.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-122) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/SqueakGeneric.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-123) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/SqueakImage.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-124) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/SqueakPlugin.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-125) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/SqueakProject.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-126) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/SqueakScript.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-127) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/SqueakSources.icns](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-128) (0 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/aioUnix.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-129) (438 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqPlatformSpecific-Unix.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-130) (698 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqPlatformSpecific-Unix.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-131) (128 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqUnixCharConv.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-132) (474 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqUnixCharConv.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-133) (60 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqUnixHeartbeat.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-134) (410 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqUnixMemory.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-135) (369 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqUnixSpurMemory.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-136) (221 changes)" }, { "name": "Added", "value": "[platforms/minheadless/unix/sqUnixThreads.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-137) (244 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqGnu.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-138) (189 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqPlatformSpecific-Win32.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-139) (680 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqPlatformSpecific-Win32.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-140) (188 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-141) (19 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Alloc.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-142) (207 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Alloc.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-143) (32 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Backtrace.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-144) (631 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Backtrace.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-145) (8 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Common.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-146) (42 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Directory.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-147) (419 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32HandleTable.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-148) (127 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Heartbeat.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-149) (479 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Main.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-150) (43 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32SpurAlloc.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-151) (292 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Threads.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-152) (272 changes)" }, { "name": "Added", "value": "[platforms/minheadless/windows/sqWin32Time.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-153) (149 changes)" }, { "name": "Modified", "value": "[platforms/win32/plugins/FilePlugin/sqWin32File.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-154) (1 changes)" }, { "name": "Modified", "value": "[platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-155) (23 changes)" }, { "name": "Modified", "value": "[platforms/win32/plugins/SecurityPlugin/sqWin32Security.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-156) (191 changes)" }, { "name": "Modified", "value": "[platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-157) (1 changes)" }, { "name": "Modified", "value": "[platforms/win32/vm/sqPlatformSpecific.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-158) (6 changes)" }, { "name": "Modified", "value": "[platforms/win32/vm/sqWin32Window.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-159) (10 changes)" }, { "name": "Modified", "value": "[spursrc/vm/cogit.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-160) (2 changes)" }, { "name": "Modified", "value": "[spursrc/vm/cogitIA32.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-161) (2 changes)" }, { "name": "Modified", "value": "[spursrc/vm/cointerp.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-162) (2 changes)" }, { "name": "Modified", "value": "[third-party/freetype2.spec](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-163) (15 changes)" }, { "name": "Modified", "value": "[third-party/libsdl2.spec](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files#diff-164) (16 changes)" } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298.patch" } ], "@type": "OpenUri", "name": "View patch" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298.diff" } ], "@type": "OpenUri", "name": "View diff" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
 

@eliotmiranda commented on this pull request.

Hi Esteban,

this looks good, but there is at least one remaining issue.  For example, the changes to platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c eliminate necessary "if (f->isStdioStream) Read/WriteConsole(..." variants.  Can you take a pass over platforms/win32/vm and roll back any incidental changes?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda commented on #298"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@eliotmiranda commented on 298", "sections": [ { "text": "Hi Esteban,\r\n\r\n this looks good, but there is at least one remaining issue. For example, the changes to platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c eliminate necessary \"if (f-\u003eisStdioStream) Read/WriteConsole(...\" variants. Can you take a pass over platforms/win32/vm and roll back any incidental changes?", "activityTitle": "**Eliot Miranda**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@eliotmiranda", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

Hi @eliotmiranda,

I didn't have time to work on this (and I don't have much time now to be honest, I need to release Pharo7 and there are still too many things open :( )
Specially, because those changes are not mine but from @ronsaldo and I first need to see what he did and what you want to to be able to fix it :P

I think is to merge latest changes to File plugin there? (no idea how hard would it be :P)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@estebanlm in #298: Hi @eliotmiranda, \r\n\r\nI didn't have time to work on this (and I don't have much time now to be honest, I need to release Pharo7 and there are still too many things open :( )\r\nSpecially, because those changes are not mine but from @ronsaldo and I first need to see what he did and what you want to to be able to fix it :P \r\n\r\nI think is to merge latest changes to File plugin there? (no idea how hard would it be :P)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439398422"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439398422", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439398422", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**Esteban Lorenzano**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@estebanlm", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439398422" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

I can have a look at platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c and platforms/win32/vm if that helps. And try building the headless version on linux.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #298: I can have a look at platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c and platforms/win32/vm if that helps. And try building the headless version on linux."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439431399"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439431399", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439431399", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-439431399" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

@estebanlm pushed 1 commit.

  • 52f258a Merge branch 'Cog' into add-minheadless-vm


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@estebanlm pushed 1 commit in #298"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files/db7ec7bd953bd3602fdd04c0fd711a43ece7961b..52f258ace4f249add69d09a65928196bb3ad81cf"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files/db7ec7bd953bd3602fdd04c0fd711a43ece7961b..52f258ace4f249add69d09a65928196bb3ad81cf", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files/db7ec7bd953bd3602fdd04c0fd711a43ece7961b..52f258ace4f249add69d09a65928196bb3ad81cf", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@estebanlm pushed 1 commit in #298", "sections": [ { "text": "1 new commit pushed to OpenSmalltalk/opensmalltalk-vm #298:", "activityTitle": "**Esteban Lorenzano**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@estebanlm", "facts": [ { "name": "52f258a", "value": "Merge branch 'Cog' into add-minheadless-vm" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298/files/db7ec7bd953bd3602fdd04c0fd711a43ece7961b..52f258ace4f249add69d09a65928196bb3ad81cf" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

When I started making the minheadless vm, I rewrote most of the file primitives to force Unicode usage by manually converting from UTF-8 into UTF-16, and removing the usage of tchar for explicit wchar. I remember that I was having Unicode related issues with spanish accents in directories and folders, and also some differences when compiling with MSVC. In parallel, in the main vm branch I think that there was a parallel refactoring on these primitives, so another pass on it should be needed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ronsaldo in #298: When I started making the minheadless vm, I rewrote most of the file primitives to force Unicode usage by manually converting from UTF-8 into UTF-16, and removing the usage of tchar for explicit wchar. I remember that I was having Unicode related issues with spanish accents in directories and folders, and also some differences when compiling with MSVC. In parallel, in the main vm branch I think that there was a parallel refactoring on these primitives, so another pass on it should be needed."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440332411"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440332411", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440332411", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**Ronie Salgado**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@ronsaldo", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440332411" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

Hi Esteban, Eliot & Ronie,

Ronie, thanks for the history and explanation re Unicode.

Esteban & Ronnie, can I ask what the long term goals are for this code base?

The reason is that it appears to be adding significant complexity to the code base:

It's breaking the existing directory structure, e.g. the two instances of sqUnixCharConv.c are in:

./platforms/minheadless/unix/sqUnixCharConv.c
./platforms/unix/vm/sqUnixCharConv.c

It adds 69 file names. Some of these obviously need to be duplicated, e.g. make files are specific to the build type, but other examples include:

  • sqUnixCharConv.h is copied unchanged.
  • Changes the return types of some functions with the same name, e.g. 'int' to 'sqInt'.
  • sqWin32Heartbeat.c where the entire file is copied so that 1 function can be extended (ioHighResClock()).

And with an admission of being too lazy to figure it out, I'm not sure how to build the Windows minheadless variant of, e.g., pharo.cog.spur. There's:

build.linux64x64/pharo.cog.spur.minheadless/build/mvm

for linux 64 bit, and the equivalent for linux 32 bit and MacOS 32 bit, but not MacOS 64 bit or Windows. Should:

build.minheadless.cmake/x86/pharo.cog.spur/mvm

be used?

I can understand the problems of chasing a moving target, but without a commitment to continue working on this it looks like it will increase technical debt.

Or am I missing something?

Thanks,
Alistair


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #298: Hi Esteban, Eliot \u0026 Ronie,\r\n\r\nRonie, thanks for the history and explanation re Unicode.\r\n\r\nEsteban \u0026 Ronnie, can I ask what the long term goals are for this code base?\r\n\r\nThe reason is that it appears to be adding significant complexity to the code base:\r\n\r\nIt's breaking the existing directory structure, e.g. the two instances of sqUnixCharConv.c are in:\r\n\r\n```\r\n./platforms/minheadless/unix/sqUnixCharConv.c\r\n./platforms/unix/vm/sqUnixCharConv.c\r\n```\r\n\r\nIt adds 69 file names. Some of these obviously need to be duplicated, e.g. make files are specific to the build type, but other examples include:\r\n\r\n- sqUnixCharConv.h is copied unchanged.\r\n- Changes the return types of some functions with the same name, e.g. 'int' to 'sqInt'.\r\n- sqWin32Heartbeat.c where the entire file is copied so that 1 function can be extended (ioHighResClock()).\r\n\r\nAnd with an admission of being too lazy to figure it out, I'm not sure how to build the Windows minheadless variant of, e.g., pharo.cog.spur. There's:\r\n\r\n```\r\nbuild.linux64x64/pharo.cog.spur.minheadless/build/mvm\r\n```\r\n\r\nfor linux 64 bit, and the equivalent for linux 32 bit and MacOS 32 bit, but not MacOS 64 bit or Windows. Should:\r\n\r\n```\r\nbuild.minheadless.cmake/x86/pharo.cog.spur/mvm\r\n```\r\n\r\nbe used?\r\n\r\nI can understand the problems of chasing a moving target, but without a commitment to continue working on this it looks like it will increase technical debt.\r\n\r\nOr am I missing something?\r\n\r\nThanks,\r\nAlistair\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

I can address the high level concern. I will let the others address the specifics in the code. The high level goal of this code is to enable the VM to not assume a UI, or even a specific UI. This is important for enabling other user interface technologies.

The Windows part does not work yet. However, the goal of this branch is to integrate it now to not lose the work. The Windows support will be added later.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@girba in #298: I can address the high level concern. I will let the others address the specifics in the code. The high level goal of this code is to enable the VM to not assume a UI, or even a specific UI. This is important for enabling other user interface technologies.\r\n\r\nThe Windows part does not work yet. However, the goal of this branch is to integrate it now to not lose the work. The Windows support will be added later."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440950034"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440950034", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440950034", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**Tudor Girba**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@girba", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440950034" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

Medium term, it is intended to use this codebase as the foundation for the official PharoVMs (because we want a real headless option, with the responsibility of starting a world from the image, not the VM).

Of course, that does not means it does not needs work on it.

Most of the duplicates and that is because when started, @ronsaldo wanted to keep it as separated as possible from the main sources, as a way to preserve them and being able to modify what he needed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@estebanlm in #298: Medium term, it is intended to use this codebase as the foundation for the official PharoVMs (because we want a real headless option, with the responsibility of starting a world from the image, not the VM).\r\n\r\nOf course, that does not means it does not needs work on it. \r\n\r\nMost of the duplicates and that is because when started, @ronsaldo wanted to keep it as separated as possible from the main sources, as a way to preserve them and being able to modify what he needed. "}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440983968"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440983968", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440983968", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**Esteban Lorenzano**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@estebanlm", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440983968" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 
>
> not sure how to build the Windows minheadless variant of, e.g.,
> pharo.cog.spur.
>

I documented my experience getting the Windows build working with MSVC
here...
http://forum.world.st/Minheadless-trial-td5082569.html

After taking a short break from it I was planning to catch it up to
Esteban's branch
but I hadn't got an opportunity yet. Seeing Esteban integrating it
prompted me to plan some time
for this at the end of next week, but thats not assured so if you are so
inclined to have a go at it, please do.

From memory this gets at least the StackInterpreter doing simple arithmetic
from the command line,
which should allow you to test file primitives from the command-line.
Esteban mentioned he had
a custom Image for a minheadless+GUI. I don't remember the state I got Cog
to.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #298: \u003e\n\u003e not sure how to build the Windows minheadless variant of, e.g.,\n\u003e pharo.cog.spur.\n\u003e\n\nI documented my experience getting the Windows build working with MSVC\nhere...\nhttp://forum.world.st/Minheadless-trial-td5082569.html\n\nAfter taking a short break from it I was planning to catch it up to\nEsteban's branch\nbut I hadn't got an opportunity yet. Seeing Esteban integrating it\nprompted me to plan some time\nfor this at the end of next week, but thats not assured so if you are so\ninclined to have a go at it, please do.\n\nFrom memory this gets at least the StackInterpreter doing simple arithmetic\nfrom the command line,\nwhich should allow you to test file primitives from the command-line.\nEsteban mentioned he had\na custom Image for a minheadless+GUI. I don't remember the state I got Cog\nto.\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441037277"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441037277", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441037277", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**Ben Coman**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@bencoman", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441037277" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

@girba, @estebanlm & @ronsaldo thanks for the explanation. That makes sense, although I think we need to be careful about the duplication.

@bencoman thanks for the write-up, that explains quite a bit that I didn't really understand.

Progress report:

I've successfully built a linux 64 bit cog spur VM and started a standard image with it. Changes include:

  • platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
    -- Reinstate stdio processing as highlighted by @eliotmiranda
    -- I also looked at platforms/win32/vm, but the changes there all look fine.
  • build.linux64x64/pharo.cog.spur.minheadless/build/mvm
    -- Fix the install directory processing and change it so it doesn't write in the middle of the 32 bit VM
  • cmake/Plugins.cmake
    -- Add FileAttributesPlugin
  • third-party/libsdl2.spec
    -- fix libSDL2 linux64 so file name

See: https://github.com/akgrant43/opensmalltalk-vm/tree/akg-minheadless-vm

The only issue I've found so far is that right mouse click isn't working.

The MacOS build will still be broken.

Cheers,
Alistair


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #298: @girba, @estebanlm \u0026 @ronsaldo thanks for the explanation. That makes sense, although I think we need to be careful about the duplication.\r\n\r\n@bencoman thanks for the write-up, that explains quite a bit that I didn't really understand.\r\n\r\nProgress report:\r\n\r\nI've successfully built a linux 64 bit cog spur VM and started a standard image with it. Changes include:\r\n\r\n- platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c\r\n-- Reinstate stdio processing as highlighted by @eliotmiranda \r\n-- I also looked at platforms/win32/vm, but the changes there all look fine.\r\n- build.linux64x64/pharo.cog.spur.minheadless/build/mvm\r\n-- Fix the install directory processing and change it so it doesn't write in the middle of the 32 bit VM\r\n- cmake/Plugins.cmake\r\n-- Add FileAttributesPlugin\r\n- third-party/libsdl2.spec\r\n-- fix libSDL2 linux64 so file name\r\n\r\nSee: https://github.com/akgrant43/opensmalltalk-vm/tree/akg-minheadless-vm\r\n\r\nThe only issue I've found so far is that right mouse click isn't working.\r\n\r\nThe MacOS build will still be broken.\r\n\r\nCheers,\r\nAlistair"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441110358"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441110358", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441110358", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441110358" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

Current status:

  • The CI build completes for:
    -- Windows
    -- Main Squeak and Pharo linux and Mac builds
    -- Other linux builds
    -- Other Mac builds fails in the newspeak tests. I don't think this is
    related.

I've only tested linux64 at this stage, but given:

  • minheadless are (mostly) separate builds.
  • both Esteban and I have done some ad-hoc testing.
  • the CI succeeds.
  • the fact that this code is more susceptible than most to diverging
    from the main repository (due to code duplication).
  • Esteban and Doru both seem committed to continuing with this work.
  • integrating the code now will facilitate others looking at the code,
    e.g. Ben planned to have a look next week.

it may be worthwhile integrating this now.

What do you think?

Just a reminder, the PR is not this one, but:

#310

My Win32 build fails trying to build and install freetype:

-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttables.h
-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttags.h
-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/ft2build.h
CMake Error at cmake_install.cmake:35 (file):
file INSTALL cannot find
"/home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h".

I've never used cmake before, so am starting to learn about it, but does
anyone recognise the above?

Cheers,
Alistair


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #298: Current status:\r\n\r\n- The CI build completes for:\r\n-- Windows\r\n-- Main Squeak and Pharo linux and Mac builds\r\n-- Other linux builds\r\n-- Other Mac builds fails in the newspeak tests. I don't think this is \r\n related.\r\n\r\nI've only tested linux64 at this stage, but given:\r\n\r\n- minheadless are (mostly) separate builds.\r\n- both Esteban and I have done some ad-hoc testing.\r\n- the CI succeeds.\r\n- the fact that this code is more susceptible than most to diverging \r\n from the main repository (due to code duplication).\r\n- Esteban and Doru both seem committed to continuing with this work.\r\n- integrating the code now will facilitate others looking at the code, \r\n e.g. Ben planned to have a look next week.\r\n\r\nit may be worthwhile integrating this now.\r\n\r\nWhat do you think?\r\n\r\nJust a reminder, the PR is not this one, but: \r\n\r\nhttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/310\r\n\r\n\r\nMy Win32 build fails trying to build and install freetype:\r\n\r\n\r\n-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttables.h\r\n-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttags.h\r\n-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/ft2build.h\r\nCMake Error at cmake_install.cmake:35 (file):\r\n file INSTALL cannot find\r\n \"/home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h\".\r\n\r\n\r\nI've never used cmake before, so am starting to learn about it, but does \r\nanyone recognise the above?\r\n\r\n\r\nCheers,\r\nAlistair\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

Closed #298.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #298."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#event-1991564244"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#event-1991564244", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#event-1991564244", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#event-1991564244" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)

David T Lewis
In reply to this post by David T Lewis
 

This has been added through PR #310 which builds on this one.

Closing.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #298: This has been added through PR https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/310 which builds on this one.\r\n\r\nClosing."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-442336404"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-442336404", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-442336404", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-442336404" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}" } ], "themeColor": "26292E" } ]</script>