[OpenSmalltalk/opensmalltalk-vm] Add sndio sound support for OpenBSD (#451)

 

This commit introduces a new plugin "vm-sound-sndio" which uses the
native OpenBSD sound system as backend.

This commit is meant as an initial introduction of the plugin, as
sound output currently blocks the whole VM.

The plugin is not loaded by default and should only get built when
running on OpenBSD.

My intention with this pull request is to get the infrastructure for future improvements up and running, so further development is easier for me and people have a way of testing the plugin.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451

Commit Summary

• Add sndio sound support for OpenBSD

File Changes

• M build.linux64x64/squeak.cog.spur/build/mvm (2)
• A platforms/unix/vm-sound-sndio/acinclude.m4 (23)
• A platforms/unix/vm-sound-sndio/sqUnixSndioSound.c (201)
• M platforms/unix/vm/sqUnixMain.c (3)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEW7DUOIFPOM53WJDAUDQXYMMRA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7A4C5Q", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEW7DUOIFPOM53WJDAUDQXYMMRA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H7A4C5Q", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@krono commented on this pull request.

Looks good overall

---

In build.linux64x64/squeak.cog.spur/build/mvm:

> @@ -11,7 +11,7 @@ LDFLAGS=""
 case $(uname -s) in
   OpenBSD)
            CFLAGS="$CFLAGS -I/usr/local/include"
-           LIBS="$LIBS -lexecinfo"
+           LIBS="$LIBS -lexecinfo -lsndio"

This should go in Makefile.inc in the plugins dir as such:

PLIBS=-lsndio

---

In platforms/unix/vm-sound-sndio/sqUnixSndioSound.c:

> @@ -0,0 +1,201 @@
+/* sqUnixSndioSound.c -- sound module for sndio sound system
+ *
+ * Last edited: 2005-04-06 05:44:40 by piumarta on pauillac.hpl.hp.com

maybe adapt that one ;)

---

In platforms/unix/vm-sound-sndio/sqUnixSndioSound.c:

> @@ -0,0 +1,201 @@
+/* sqUnixSndioSound.c -- sound module for sndio sound system
+ *
+ * Last edited: 2005-04-06 05:44:40 by piumarta on pauillac.hpl.hp.com
+ *
+ * This is a driver for the OpenBSD sndio sound drivers for Squeak.
+ *
+ */
+
+#include "sq.h"
+#include "sqaio.h"
+
+#include <stdio.h>
+#include <sndio.h>
+
+#define trace() fprintf(stderr, "%s:%d %s\n", __FILE__, __LINE__, __FUNCTION__)

Please add a debug guard

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEWZBKSQUY6UMNIH34ATQXYOIXA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOMYAAQ#pullrequestreview-328826882", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEWZBKSQUY6UMNIH34ATQXYOIXA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOMYAAQ#pullrequestreview-328826882", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@ckeen pushed 1 commit.

• 180e1b8 Add sndio sound support for OpenBSD

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451/files/72196dce2fbc2efed8044a6c7f4b7e8262d38b72..180e1b8f9fb90ac428e365236961cf18cbd6aaca?email_source=notifications\u0026email_token=AIJPEW72KTA5YWOYLHKPWF3QYFOGVA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGM2TANRTGUYTEN2QOVZWQIZUGM4DKOBYGEYTENI", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451/files/72196dce2fbc2efed8044a6c7f4b7e8262d38b72..180e1b8f9fb90ac428e365236961cf18cbd6aaca?email_source=notifications\u0026email_token=AIJPEW72KTA5YWOYLHKPWF3QYFOGVA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGM2TANRTGUYTEN2QOVZWQIZUGM4DKOBYGEYTENI", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Many thanks for your feedback and sorry for the late reply. I have updated the branch incorporating your suggestions. If you can find the time to have a loot at it again, I'd appreciate it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEWZTIQ2HFVUM6RWIQNLQYFOOFA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUWNPI#issuecomment-564750013", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEWZTIQ2HFVUM6RWIQNLQYFOOFA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUWNPI#issuecomment-564750013", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Looks good to me. Anyone else having a look?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEW23V5BJRL3YZK6CWXLQYFOXNA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUWUKQ#issuecomment-564750890", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEW23V5BJRL3YZK6CWXLQYFOXNA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUWUKQ#issuecomment-564750890", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

 

Merged #451 into Cog.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEW4APZM2RIRXTBLRVTLQYLECBA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVOSXQIY#event-2879748131", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/451?email_source=notifications\u0026email_token=AIJPEW4APZM2RIRXTBLRVTLQYLECBA5CNFSM4JYGZGYKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVOSXQIY#event-2879748131", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>