[OpenSmalltalk/opensmalltalk-vm] Align windows behavior with other platforms in response to mouse wheel events (#459)

 

• Set all the meta bits to distinguish from a real arrow key, rather than just control key bit
• Set the utf32Code to the same arrow code rather than 0, not only on PharoVM

Yet do not translate horizontal mouse wheels to left/right arrows
Such events are troublesome if TextEditors are not ready to filter them out.

This is a partial fix for #456

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/459

Commit Summary

• Align windows behavior with other platforms in response to mouse wheel events

File Changes

• M platforms/win32/vm/sqWin32Window.c (14)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/459.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/459.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/459?email_source=notifications\u0026email_token=AIJPEW5PWF2UEX5IFZUYBWLQ2KMP3A5CNFSM4J7BHIDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICRU2EQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/459?email_source=notifications\u0026email_token=AIJPEW5PWF2UEX5IFZUYBWLQ2KMP3A5CNFSM4J7BHIDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICRU2EQ", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #459 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/459?email_source=notifications\u0026email_token=AIJPEW356CXFUZFQX3T6Q3LQ2OR4NA5CNFSM4J7BHIDKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVLLCDA#event-2908139788", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/459?email_source=notifications\u0026email_token=AIJPEW356CXFUZFQX3T6Q3LQ2OR4NA5CNFSM4J7BHIDKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVLLCDA#event-2908139788", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>