[OpenSmalltalk/opensmalltalk-vm] Cannot build SqueakFFIPrims as internal plugin on windows (#557)

 

This is because of a conflicting definition of error() in sqVirtualMachine.h and in sqAssert.h

Since pharo is building FFI as internal plugin, this makes the build red on windows.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

FFI has an internal plugin would be nice. :-)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557#issuecomment-823400049", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557#issuecomment-823400049", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

x86_64-w64-mingw32-clang -x c -MT build/SqueakFFIPrims/SqueakFFIPrims.o -MMD -MP -MF deps/SqueakFFIPrims.Td -fdeclspec -msse2 -ggdb2 -m64 -mno-rtd -mms-bitfields -O1 -momit-leaf-frame-pointer -funroll-loops -D_MT -fno-builtin-printf -fno-builtin-putchar -fno-builtin-fprintf -Wall -Wno-unused-variable -Wno-unknown-pragmas -Wno-unused-label -Wno-unused-function -DPharoVM=1 -DCOGMTVM=0 -DDEBUGVM=0 -fno-stack-protector -DSQUEAK_BUILTIN_PLUGIN -I. -I../../spur64src/vm -I../../platforms/win32/vm -I../../platforms/Cross/vm -I../../src/plugins/SqueakFFIPrims -I../../platforms/win32/plugins/SqueakFFIPrims -I../../platforms/Cross/plugins/SqueakFFIPrims -D_WIN32_WINNT=0x0501 -DWINVER=0x0501 -DWIN64=1 -DNO_ISNAN -DNO_SERVICE -DNDEBUG -DLSB_FIRST -DVM_NAME="Pharo" -c ../../src/plugins/SqueakFFIPrims/SqueakFFIPrims.c -o build/SqueakFFIPrims/SqueakFFIPrims.o
In file included from ../../src/plugins/SqueakFFIPrims/SqueakFFIPrims.c:28:
In file included from ../../src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c:38:
../../platforms/Cross/vm/sqAssert.h:27:14: error: static declaration of 'error' follows non-static declaration
EXPORT(void) error(const char *);
^
../../platforms/Cross/vm/sqVirtualMachine.h:547:7: note: previous declaration is here
void error(const char *);
^

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557#issuecomment-823416261", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557#issuecomment-823416261", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Closed #557.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557#event-4620636703", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/557#event-4620636703", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>