[OpenSmalltalk/opensmalltalk-vm] Customization for Pharo & About Dialog (#524)

 

should close PR #388

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524

Commit Summary

• Adding a custom Menu for Pharo VMs
• Adding a optional URL for the help, only fr Pharo
• Handling correctly the events of the about window
• Making the about window property as weak.
• Reverting a change I needed to compile in my machine
• Use $(SYSTEM)-MainMenu.xib to determine which xib file to use

File Changes

• M build.macos32x86/common/Makefile.app (4)
• M build.macos32x86/pharo.cog.spur.lowcode/Makefile (2)
• M build.macos32x86/pharo.cog.spur.minheadless/Makefile (2)
• M build.macos32x86/pharo.cog.v3/Makefile (2)
• M build.macos64x64/common/Makefile.app (4)
• R platforms/iOS/vm/English.lproj/Newspeak-MainMenu-cg.xib (0)
• R platforms/iOS/vm/English.lproj/Newspeak-MainMenu-opengl.xib (0)
• R platforms/iOS/vm/English.lproj/Newspeak-MainMenu.xib (0)
• A platforms/iOS/vm/English.lproj/Pharo-MainMenu-opengl.xib (1261)
• A platforms/iOS/vm/English.lproj/Pharo-MainMenu.xib (1261)
• A platforms/iOS/vm/English.lproj/Squeak-MainMenu-cg.xib (1261)
• A platforms/iOS/vm/English.lproj/Squeak-MainMenu-opengl.xib (1261)
• A platforms/iOS/vm/English.lproj/Squeak-MainMenu.xib (1261)
• M platforms/iOS/vm/OSX/Pharo-Info.plist (2)
• M platforms/iOS/vm/OSX/SqueakOSXApplication.m (30)
• M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (16)
• M platforms/iOS/vm/OSX/sqSqueakOSXApplication.h (5)
• M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (1)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@demarey pushed 1 commit.

• 75b9999 Merge branch 'Cog' into customizationForPharo

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files/c30c66231a0796a3a028284f051071cf9914c403..75b9999dad53f7754506372a77970d79674692e8", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524/files/c30c66231a0796a3a028284f051071cf9914c403..75b9999dad53f7754506372a77970d79674692e8", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#pullrequestreview-512136241", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#pullrequestreview-512136241", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Closed #524.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#event-3895399893", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#event-3895399893", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #524 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#event-3895406213", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#event-3895406213", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #524 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#event-3895406531", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#event-3895406531", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Hi Christophe,

when I try and build a PharoVM from the Cog sources after merging this pull request I get the following error:

    [gDelegateApp.squeakApplication setAboutWindow: [self keyWindow]];
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~
1 error generated.```

It's coming from this method:

```@implementation SqueakOSXApplication
...
- (void)orderFrontStandardAboutPanel:(id)sender;
{
    [super orderFrontStandardAboutPanel: sender];
    [gDelegateApp.squeakApplication setAboutWindow: [self keyWindow]];
}```

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#issuecomment-724245207", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/524#issuecomment-724245207", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>