[OpenSmalltalk/opensmalltalk-vm] Ensure readable error message for VM module dlopen failures. (#429)

 

If a module such as vm-display-X11 fails to load due to dynamic linking
errors such as symbol not found or missing runtime libary on the target
machine, then provide a meaningful error message.
Eliminate unnecessary check for if (strstr(why,"undefined symbol")) {...}
because it eats errors, e.g. in the case of missing xRender runtime
and VM compiled with xRender dev libaries.
Improve the error message for readability. Add fflush() for stderr
output to prevent messages being lost or mixed with stdout. Remove
redundant and unreachable code.

Note, duplicate error messages on for load failures may occur due
to path setup issues in the /bin/squeak start script, are are not
a VM issue per se.

Example error message for VM compiled with xRender library for large
cursor support, and run on a machine with missing runtime library:

vm-display-X11 tryLoading /usr/local/lib/squeak/5.0-201910110209/vm-display-X11.so: dlopen: libXrender.so.1: cannot open shared object file: No such file or directory

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/429

Commit Summary

• Ensure readable error message for VM module dlopen failures.

File Changes

• M platforms/unix/vm/sqUnixExternalPrims.c (31)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/429.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/429.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/429?email_source=notifications\u0026email_token=AIJPEW6DPOPRMEDNOQ6AGM3QONPFRA5CNFSM4JAH64C2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HRONKCQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/429?email_source=notifications\u0026email_token=AIJPEW6DPOPRMEDNOQ6AGM3QONPFRA5CNFSM4JAH64C2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HRONKCQ", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #429 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/429?email_source=notifications\u0026email_token=AIJPEW2EUQUOPSD45ALLDY3QQKJ4FA5CNFSM4JAH64C2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUOAPXUI#event-2743139281", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/429?email_source=notifications\u0026email_token=AIJPEW2EUQUOPSD45ALLDY3QQKJ4FA5CNFSM4JAH64C2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUOAPXUI#event-2743139281", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>