[OpenSmalltalk/opensmalltalk-vm] Failing linux build due to error directive in config.h (#560)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Failing linux build due to error directive in config.h (#560)

David T Lewis
 

The linux builds are failing for a while after some re-arrangement of header order.

It happens that config.h cannot work after linux features.h, so the former should be included before the later.
An #error directive checks and protect against this case.

One possible workaround could be to move #include "config.h" ahead in a few files...


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Failing linux build due to error directive in config.h (#560)

David T Lewis
 

This protection was introduced here:
25e4f4a


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560#issuecomment-824297951", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560#issuecomment-824297951", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Failing linux build due to error directive in config.h (#560)

David T Lewis
In reply to this post by David T Lewis
 

The solution shall take this commit message into account

aafcb78

Unfortunately, the TERF VM is not build here, so it's uneasy to tell whether we break it or not...


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560#issuecomment-824340466", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560#issuecomment-824340466", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>