Smalltalk › Squeak › Squeak VM

[OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

David T Lewis

[OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

1.3.0: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes.

You can view, comment on, or merge this pull request online at:

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268

Commit Summary

FileAttributesPlugin v1.3.0
FileAttributesPlugin: Interpreter proxy is responsible for conversion

File Changes

M platforms/unix/vm/sqUnixMain.c (44)
M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (523)

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Stuart Cassoff-2

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

+ * WARNING: On 32 bit platforms time_t is only 32 bits long.

FWIW, not everywhere.
I didn't look over your patch in detail so I don't know if this makes a difference.

$ uname -msr && cat ct.c && cc ct.c && ./a.out
OpenBSD 6.3 i386
#include <stdio.h>
int main (int argc, char *argv[]) {
printf("%lu\n", sizeof (void *));
printf("%lu\n", sizeof (time_t));
return 0;
}
4
8

$ uname -msr && cc ct.c && ./a.out
OpenBSD 6.3 amd64
8
8

Stu

> ---------- Original Message ----------
> From: akgrant43 <[hidden email]>
> Date: June 16, 2018 at 9:27 AM
>
>
> 1.3.0: Change from Unix (UTC) timestamps to Squeak timestamps for file attributes.
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268
>
> -- Commit Summary --
>
> * FileAttributesPlugin v1.3.0
> * FileAttributesPlugin: Interpreter proxy is responsible for conversion
>
> -- File Changes --
>
> M platforms/unix/vm/sqUnixMain.c (44)
> M src/plugins/FileAttributesPlugin/FileAttributesPlugin.c (523)
>
> -- Patch Links --
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.patch
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268.diff
>
> --
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/268

alistairgrant

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin 1.3.0 (#268)

Hi Stu,

On Sat, 16 Jun 2018 at 16:43, Stuart Cassoff <[hidden email]> wrote:

>
>
> + * WARNING: On 32 bit platforms time_t is only 32 bits long.
>
> FWIW, not everywhere.
> I didn't look over your patch in detail so I don't know if this makes a difference.
>
>
> $ uname -msr && cat ct.c && cc ct.c && ./a.out
> OpenBSD 6.3 i386
> #include <stdio.h>
> int main (int argc, char *argv[]) {
> printf("%lu\n", sizeof (void *));
> printf("%lu\n", sizeof (time_t));
> return 0;
> }
> 4
> 8
>
>
> $ uname -msr && cc ct.c && ./a.out
> OpenBSD 6.3 amd64
> 8
> 8
>
>
> Stu

Thanks for letting me know, I'll update the comment to say "On some 32
bit platforms...".

Cheers,
Alistair

David T Lewis