Restructure FileAttributesPlugin to move platform specific functionality out to separate files. This is required as Windows requires the "wide" versions of posix functions to be used, e.g. access() vs. _waccess(), while other seem to require the Windows native functions, e.g. iterating over directories, and interleaving #ifdef _WIN32 was becoming unwieldy.
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285
Commit Summary
- faSupport: initial commit for windows testing
- FileAttributesPlugin: restructure platform support files
- FileAttributesPlugin: Manual FileAttributesPlugin.c fixes
- FileAttributesPlugin: OSX and Windows fixes
- FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows
- Merge remote-tracking branch 'upstream/Cog' into FileAttributesPlugin200
File Changes
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows (#285)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows (#285)",
"sections": [
{
"text": "",
"activityTitle": "**akgrant43**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@akgrant43",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "a229a95",
"value": "faSupport: initial commit for windows testing"
},
{
"name": "71e9b7e",
"value": "FileAttributesPlugin: restructure platform support files"
},
{
"name": "2a0edb0",
"value": "FileAttributesPlugin: Manual FileAttributesPlugin.c fixes"
},
{
"name": "3cf4474",
"value": "FileAttributesPlugin: OSX and Windows fixes"
},
{
"name": "0c08668",
"value": "FileAttributesPlugin 2.0.0: Fixes UTF8 on Windows"
},
{
"name": "5aa42b7",
"value": "Merge remote-tracking branch 'upstream/Cog' into FileAttributesPlugin200"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Added",
"value": "[platforms/Cross/plugins/FileAttributesPlugin/faCommon.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-0) (67 changes)"
},
{
"name": "Added",
"value": "[platforms/Cross/plugins/FileAttributesPlugin/faCommon.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-1) (14 changes)"
},
{
"name": "Added",
"value": "[platforms/Cross/plugins/FileAttributesPlugin/faConstants.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-2) (32 changes)"
},
{
"name": "Modified",
"value": "[platforms/iOS/plugins/FileAttributesPlugin/Makefile](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-3) (6 changes)"
},
{
"name": "Added",
"value": "[platforms/unix/plugins/FileAttributesPlugin/faSupport.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-4) (515 changes)"
},
{
"name": "Added",
"value": "[platforms/unix/plugins/FileAttributesPlugin/faSupport.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-5) (71 changes)"
},
{
"name": "Added",
"value": "[platforms/win32/plugins/FileAttributesPlugin/faSupport.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-6) (657 changes)"
},
{
"name": "Added",
"value": "[platforms/win32/plugins/FileAttributesPlugin/faSupport.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-7) (72 changes)"
},
{
"name": "Modified",
"value": "[src/plugins/FileAttributesPlugin/FileAttributesPlugin.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285/files#diff-8) (1092 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 285,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 285\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/285.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 386778042\n}"
}
],
"themeColor": "26292E"
}
]</script>
Locked
