[OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin v2.0.1 (#287)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin v2.0.1 (#287)

David T Lewis
 
  1. The following primitives weren't updated as part of the support file
    restructure:
  • primitiveChangeMode
  • primitiveChangeOwner
  • primitiveSymlinkChangeOwner
  • primitiveRewinddir

Get these working again in the new framework (fapath).

  1. Rewinding the directory on Windows returns the first entry.
    Modify the primitive to behave this way on all platforms.

  2. Path conversion primitives shouldn't include the Long Path Prefix on
    Windows as part of the path.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287

Commit Summary

  • FileAttributesPlugin: Update remaining primitives
  • FileAttributesPlugin: redefine primitiveRewinddir the Windows way
  • FileAttributesPlugin: Fix path conversion primitives
  • FileAttributesPlugin v2.0.1

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"FileAttributesPlugin v2.0.1 (#287)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "FileAttributesPlugin v2.0.1 (#287)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] }, { "title": "Commit Summary", "facts": [ { "name": "bd88cc6", "value": "FileAttributesPlugin: Update remaining primitives" }, { "name": "b6b67f4", "value": "FileAttributesPlugin: redefine primitiveRewinddir the Windows way" }, { "name": "8c44f9b", "value": "FileAttributesPlugin: Fix path conversion primitives" }, { "name": "91e5787", "value": "FileAttributesPlugin v2.0.1" } ] }, { "title": "File Changes", "facts": [ { "name": "Modified", "value": "[platforms/unix/plugins/FileAttributesPlugin/faSupport.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287/files#diff-0) (27 changes)" }, { "name": "Modified", "value": "[platforms/unix/plugins/FileAttributesPlugin/faSupport.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287/files#diff-1) (1 changes)" }, { "name": "Modified", "value": "[platforms/win32/plugins/FileAttributesPlugin/faSupport.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287/files#diff-2) (132 changes)" }, { "name": "Modified", "value": "[platforms/win32/plugins/FileAttributesPlugin/faSupport.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287/files#diff-3) (15 changes)" }, { "name": "Modified", "value": "[src/plugins/FileAttributesPlugin/FileAttributesPlugin.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287/files#diff-4) (127 changes)" } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 287,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 287\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287.patch" } ], "@type": "OpenUri", "name": "View patch" }, { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287.diff" } ], "@type": "OpenUri", "name": "View diff" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 387683283\n}" } ], "themeColor": "26292E" } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin v2.0.1 (#287)

David T Lewis
 

Merged #287 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #287 into Cog."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287#event-1883634717"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287#event-1883634717", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287#event-1883634717", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin v2.0.1 (#287)", "sections": [ { "text": "", "activityTitle": "**akgrant43**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@akgrant43", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/287#event-1883634717" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 387683283\n}" } ], "themeColor": "26292E" } ]</script>