[OpenSmalltalk/opensmalltalk-vm] Fix 32 bits CI builds because of the Metal integration (#399)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[OpenSmalltalk/opensmalltalk-vm] Fix 32 bits CI builds because of the Metal integration (#399)

David T Lewis
 

This should fix this issue: #385 (comment)

On 32 bits it is possible to link with the Metal libraries, but the MTLCreateSystemDefaultDevice() function always returns nil, at least on my machines.


You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/399

Commit Summary

  • Always link the required dependencies for B3DAcceleratorPlugin.
  • Merge branch 'Cog' into bug/osx-32bit-opengl-undefined

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/399?email_source=notifications\u0026email_token=AIJPEW5IT56E3YWYTFADP6TPZLZTBA5CNFSM4HV7H7WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYLNJSA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/399?email_source=notifications\u0026email_token=AIJPEW5IT56E3YWYTFADP6TPZLZTBA5CNFSM4HV7H7WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYLNJSA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix 32 bits CI builds because of the Metal integration (#399)

David T Lewis
 

Merged #399 into Cog.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/399?email_source=notifications\u0026email_token=AIJPEW6YTMDNAKVEUNFXDULPZNSMBA5CNFSM4HV7H7WKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR35UK7I#event-2398831997", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/399?email_source=notifications\u0026email_token=AIJPEW6YTMDNAKVEUNFXDULPZNSMBA5CNFSM4HV7H7WKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR35UK7I#event-2398831997", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
Reply | Threaded
Open this post in threaded view
|

Re: [OpenSmalltalk/opensmalltalk-vm] Fix 32 bits CI builds because of the Metal integration (#399)

David T Lewis
In reply to this post by David T Lewis
 

Thanks for the fix, @ronsaldo!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/399?email_source=notifications\u0026email_token=AIJPEW4TNRP5643TF3UM5TLPZNSNLA5CNFSM4HV7H7WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHQESA#issuecomment-500105800", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/399?email_source=notifications\u0026email_token=AIJPEW4TNRP5643TF3UM5TLPZNSNLA5CNFSM4HV7H7WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHQESA#issuecomment-500105800", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>