[OpenSmalltalk/opensmalltalk-vm] Fix Freetype 2.9.1 third-party build (#327)

 

The Freetype 2.9.1 "release" was broken for CMake builds (at least tested on Windows).
This was fixed two commits later but the maitainers didn't feel it was important enough (??)
to issue another release. Here we cherry pick that commit into a patch file.

P.S. PR #325 was accidentally and can't be reopen ed, so repeat in this new PR.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327

Commit Summary

• Fix Freetype 2.9.1 third-party build

File Changes

• M .appveyor.yml (8)
• M build.win32x86/pharo.cog.spur/Makefile (2)
• M build.win32x86/third-party/Makefile.freetype2 (3)
• M scripts/installCygwin.bat (5)
• A third-party/freetype291.patch (19)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix Freetype 2.9.1 third-party build (#327)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@bencoman pushed 1 commit.

• 3e9f3b9 No thirdparty cache

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman pushed 1 commit in #327"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327/files/bbf4c6a93e243401e775cff4983f0349bdbf6d0c..3e9f3b9e06ec96b86b77533a1dea8d1ccb54db53"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327/files/bbf4c6a93e243401e775cff4983f0349bdbf6d0c..3e9f3b9e06ec96b86b77533a1dea8d1ccb54db53", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327/files/bbf4c6a93e243401e775cff4983f0349bdbf6d0c..3e9f3b9e06ec96b86b77533a1dea8d1ccb54db53", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@estebanlm, when you are back on board after vacation, this one is ready to go.
Appveyor passed, but also at I did some additional testing switching third-party-caching on and off
at https://ci.appveyor.com/project/bencoman/opensmalltalk-vm/history
between builds 0.0.23.bencoman and 0.0.30.bencoman

Travis failure seems irrelevant - presumably due to hiccup in external network resource.
36 of 37 Travis jobs succeeded. The one that failed was...
1590.36 Xcode: xcode7.3 C ARCH="macos32x86" FLAVOR="squeak.stack.spur"
3699 Tests, 20 Failures, 3 Errors
All 23 failures were from StringSocketTestCase & SocketStreamTest due to 10 second timeout.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #327: @estebanlm, when you are back on board after vacation, this one is ready to go.\r\nAppveyor passed, but also at I did some additional testing switching third-party-caching on and off\r\nat https://ci.appveyor.com/project/bencoman/opensmalltalk-vm/history\r\nbetween builds 0.0.23.bencoman and 0.0.30.bencoman\r\n\r\nTravis failure seems irrelevant - presumably due to hiccup in external network resource.\r\n36 of 37 Travis jobs succeeded. The one that failed was...\r\n 1590.36 Xcode: xcode7.3 C ARCH=\"macos32x86\" FLAVOR=\"squeak.stack.spur\"\r\n 3699 Tests, 20 Failures, 3 Errors \r\nAll 23 failures were from StringSocketTestCase \u0026 SocketStreamTest due to 10 second timeout."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#issuecomment-450557046"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#issuecomment-450557046", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#issuecomment-450557046", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Travis failure seems irrelevant - presumably due to hiccup in external network resource.
36 of 37 Travis jobs succeeded. The one that failed was...

   1590.36  Xcode: xcode7.3 C ARCH="macos32x86" FLAVOR="squeak.stack.spur"
   3699 Tests, 20 Failures, 3 Errors  

All 23 failures were from StringSocketTestCase & SocketStreamTest due to 10 second timeout.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #327: Travis failure seems irrelevant - presumably due to hiccup in external network resource.\r\n36 of 37 Travis jobs succeeded. The one that failed was...\r\n```\r\n 1590.36 Xcode: xcode7.3 C ARCH=\"macos32x86\" FLAVOR=\"squeak.stack.spur\"\r\n 3699 Tests, 20 Failures, 3 Errors \r\n```\r\nAll 23 failures were from StringSocketTestCase \u0026 SocketStreamTest due to 10 second timeout."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#issuecomment-450557354"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#issuecomment-450557354", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#issuecomment-450557354", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #327 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #327 into Cog."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#event-2048464993"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#event-2048464993", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/327#event-2048464993", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>