[OpenSmalltalk/opensmalltalk-vm] Fix image MC loading glitch in image build scripts when checking pack… (#466)

 

…age-cache.

MCRepository>>includesVersionNamed: does not check explicit version name,
so this may do the wrong thing when checking the cache:
version := ((MCCacheRepository default includesVersionNamed: latestVersion)
ifTrue: [MCCacheRepository default]
ifFalse: [repository]) versionNamed: latestVersion.

Therefore do this instead:
version := (MCCacheRepository default versionNamed: latestVersion)
ifNil: [repository versionNamed: latestVersion].

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466

Commit Summary

• Fix image MC loading glitch in image build scripts when checking package-cache.

File Changes

• M image/BuildPharo6VMMakerImage.st (2)
• M image/BuildSqueakSpurTrunkVMMakerImage.st (2)
• M image/LoadFFI.st (2)
• M image/LoadReader.st (5)
• M image/LoadSistaSupport.st (2)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466?email_source=notifications\u0026email_token=AIJPEW3JLIQOOP7UNMFEKRDQ4ENMXA5CNFSM4KCYPT3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IEBKM2Q", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466?email_source=notifications\u0026email_token=AIJPEW3JLIQOOP7UNMFEKRDQ4ENMXA5CNFSM4KCYPT3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IEBKM2Q", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@fniephaus approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466?email_source=notifications\u0026email_token=AIJPEW3KOJBCVMV4WNR4U6DQ4NJPRA5CNFSM4KCYPT3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQYKRLY#pullrequestreview-338733231", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466?email_source=notifications\u0026email_token=AIJPEW3KOJBCVMV4WNR4U6DQ4NJPRA5CNFSM4KCYPT3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQYKRLY#pullrequestreview-338733231", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #466 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466?email_source=notifications\u0026email_token=AIJPEW5CYBOVQ2XF3XUJIJTQ4NJRBA5CNFSM4KCYPT3KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVZJUY2Y#event-2924694635", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/466?email_source=notifications\u0026email_token=AIJPEW5CYBOVQ2XF3XUJIJTQ4NJRBA5CNFSM4KCYPT3KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVZJUY2Y#event-2924694635", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>