[OpenSmalltalk/opensmalltalk-vm] Fix image opening on unix (#529)

 

In imgInit() of sqUnixMain.c

• preserve fd instead of throwing it away
• use fileno() to get the file descriptor (fd) created by fopen() instead of
  opening the file again with open() (which leaked a file descriptor due to
  lack of close())
• pass the file descriptor fd instead of the FILE* f to the recently changed
  methods expecting a file descriptor, e.g. readImageFromFileHeapSizeStartingAt()

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529

Commit Summary

• Fix image opening on unix

File Changes

• M platforms/unix/vm/sqUnixMain.c (12)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529#pullrequestreview-512198218", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529#pullrequestreview-512198218", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #529 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529#event-3895738142", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/529#event-3895738142", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>