[OpenSmalltalk/opensmalltalk-vm] Fix issue #557 (workaround?) (#558)

 

If we build an internal plugin SQUEAK_BUILTIN_PLUGIN, then we don't need to EXPORT the error/warning functions.
There are still conflicting definitions in sqVirtualMachine.h which totally ignore IMPORT/EXPORT but these only generate warnings, not errors.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/558

Commit Summary

• Fix issue #557 (workaround?)

File Changes

• M platforms/Cross/vm/sqAssert.h (12)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/558.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/558.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/558", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/558", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #558 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/558#event-4620626617", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/558#event-4620626617", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>