[OpenSmalltalk/opensmalltalk-vm] Fix osx linux mouse wheel (#462)

 

This provides a fix for Issue #41

Both unix (X11) and OSX will now deliver the buttons and modifiers states like any other mouse event in fifth and sixth position in event structure (the so called eventBuffer at image side).

Note: OSX VM will now provide smooth wheel scroll events if possible, with a resolution of 20 scroll units (1/6th of wheel notch), like I did for Windows.
This threshold will avoid burst of wheel events with small deltas which where freezing Morphic interactivity.

Note: I did not accumulate small wheel events on linux yet, this remains a TODO.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462

Commit Summary

• Handle mouse wheel events like other mouse events
• Use precise scrolling deltas if available on OSX
• OSX: accumulate enough delta before sending the wheel event to the image
• Convert OSX point units into scrolling units

File Changes

• M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (60)
• M platforms/unix/vm/sqUnixEvent.c (7)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462?email_source=notifications\u0026email_token=AIJPEWZY24EUUAHLQ33OVZLQ2Z2OJA5CNFSM4KACUPL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IC5RNFA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462?email_source=notifications\u0026email_token=AIJPEWZY24EUUAHLQ33OVZLQ2Z2OJA5CNFSM4KACUPL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IC5RNFA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #462 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462?email_source=notifications\u0026email_token=AIJPEW5F467D4ARUGGQXHHTQ25GZLA5CNFSM4KACUPL2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVWHW5YI#event-2911858401", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462?email_source=notifications\u0026email_token=AIJPEW5F467D4ARUGGQXHHTQ25GZLA5CNFSM4KACUPL2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVWHW5YI#event-2911858401", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>