Hi Ronie,
What is your procedure for building with MSVC ?
I'd like to have a go at it.
cheers -ben
On Sat, 1 Dec 2018 at 07:20, Ronie Salgado <
[hidden email]> wrote:
> Quick fixup of the minheadless VM for windows using the CMake building
> scripts.
> The VM builds and works with Cygwin for 32 bits.
> It builds with MSVC, but fails with several errors on runtime.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311
> Commit Summary
>
> - Fix the build of the minheadless VM for Pharo in Win32.
>
> File Changes
>
> - *M* CMakeLists.txt
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-0>
> (23)
> - *M* build.minheadless.cmake/x64/common/configure_variant.sh
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-1>
> (1)
> - *M* cmake/Plugins.cmake
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-2>
> (9)
> - *M* cmake/PluginsPharo.cmake
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-3>
> (19)
> - *M* platforms/Cross/plugins/IA32ABI/ia32abicc.c
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-4>
> (4)
> - *M* platforms/Cross/plugins/IA32ABI/x64win64abicc.c
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-5>
> (8)
> - *M* platforms/Cross/plugins/IA32ABI/xabicc.c
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-6>
> (6)
> - *M* platforms/Cross/plugins/Mpeg3Plugin/libmpeg/changesForSqueak.c
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-7>
> (3)
> - *M* platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3private.h
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-8>
> (3)
> - *M* platforms/minheadless/windows/sqPlatformSpecific-Win32.c
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-9>
> (123)
> - *M* platforms/minheadless/windows/sqWin32Directory.c
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-10>
> (269)
> - *A* platforms/minheadless/windows/sqWin32Stubs.c
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-11>
> (19)
>
> Patch Links:
>
> - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311.patch
> - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311>, or mute the
> thread
> <https://github.com/notifications/unsubscribe-auth/ABolJ8jAUbhxA8NQPK4dTjyPdyEuzmS1ks5u0b00gaJpZM4Y8jIn>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bencoman in #311: Hi Ronie,\n\nWhat is your procedure for building with MSVC ?\nI'd like to have a go at it.\n\ncheers -ben\n\nOn Sat, 1 Dec 2018 at 07:20, Ronie Salgado \u003cnotifications@github.com\u003e wrote:\n\n\u003e Quick fixup of the minheadless VM for windows using the CMake building\n\u003e scripts.\n\u003e The VM builds and works with Cygwin for 32 bits.\n\u003e It builds with MSVC, but fails with several errors on runtime.\n\u003e ------------------------------\n\u003e You can view, comment on, or merge this pull request online at:\n\u003e\n\u003e https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311\n\u003e Commit Summary\n\u003e\n\u003e - Fix the build of the minheadless VM for Pharo in Win32.\n\u003e\n\u003e File Changes\n\u003e\n\u003e - *M* CMakeLists.txt\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-0\u003e\n\u003e (23)\n\u003e - *M* build.minheadless.cmake/x64/common/configure_variant.sh\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-1\u003e\n\u003e (1)\n\u003e - *M* cmake/Plugins.cmake\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-2\u003e\n\u003e (9)\n\u003e - *M* cmake/PluginsPharo.cmake\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-3\u003e\n\u003e (19)\n\u003e - *M* platforms/Cross/plugins/IA32ABI/ia32abicc.c\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-4\u003e\n\u003e (4)\n\u003e - *M* platforms/Cross/plugins/IA32ABI/x64win64abicc.c\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-5\u003e\n\u003e (8)\n\u003e - *M* platforms/Cross/plugins/IA32ABI/xabicc.c\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-6\u003e\n\u003e (6)\n\u003e - *M* platforms/Cross/plugins/Mpeg3Plugin/libmpeg/changesForSqueak.c\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-7\u003e\n\u003e (3)\n\u003e - *M* platforms/Cross/plugins/Mpeg3Plugin/libmpeg/mpeg3private.h\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-8\u003e\n\u003e (3)\n\u003e - *M* platforms/minheadless/windows/sqPlatformSpecific-Win32.c\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-9\u003e\n\u003e (123)\n\u003e - *M* platforms/minheadless/windows/sqWin32Directory.c\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-10\u003e\n\u003e (269)\n\u003e - *A* platforms/minheadless/windows/sqWin32Stubs.c\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311/files#diff-11\u003e\n\u003e (19)\n\u003e\n\u003e Patch Links:\n\u003e\n\u003e - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311.patch\n\u003e - https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311.diff\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311\u003e, or mute the\n\u003e thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ABolJ8jAUbhxA8NQPK4dTjyPdyEuzmS1ks5u0b00gaJpZM4Y8jIn\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311#issuecomment-443418024"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311#issuecomment-443418024",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311#issuecomment-443418024",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [OpenSmalltalk/opensmalltalk-vm] Fix the build of the minheadless VM for Pharo in Win32. (#311)",
"sections": [
{
"text": "",
"activityTitle": "**Ben Coman**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@bencoman",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 311,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311#issuecomment-443418024"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 418525735\n}"
}
],
"themeColor": "26292E"
}
]</script>
Locked
