Here is what I found... I'm not certain, but it seems if a previous Freetype 2.6.5 compile succeeded, then the Freetype 2.9.1 compile will succeed - but not in a fresh Cygwin install. So to reproduce...
— |
Hi Ben,
I'm afraid you're losing me in this sentence, sorry. Are you saying you succeeded in building 2.9.1 after 2.6.5? But that's my current situation, and it doesn't work. You seem to be saying that doing a fresh install of cygwin doesn't help, so why do it? Is this just showing how to reproduce the error? Can you clarify? Thanks, — |
In reply to this post by David T Lewis
A fresh cygwin help reproduce the error since it ensures nothing historical is accidentally making the HEAD build. i.e. to avoid a "works for me" scenario. — |
In reply to this post by David T Lewis
Okay, here is my experiment! Broken commit on its own...
Now in another directory, first the good commit then broken commit on top of that.
— |
In reply to this post by David T Lewis
Hi Ben, Can you check which version of libfreetype.dll you end up with after the final build. I followed basically the same steps as above (build b83f9ec followed by 7ac7303) and get: FT2Library current libraryVersion " 2.6.5" P.S. I hope I've done something wrong! Thanks again for looking in to this. Cheers, — |
In reply to this post by David T Lewis
I also get 2.6.5. So the reason it succeeded is that it used the cached library and didn't even try to build 2.9.1. So secondary issue, there seems something wrong with make's dependency on third-party/freetype2.spec. — |
In reply to this post by David T Lewis
Yep. And vmLatest is still 2.6.5, so it's not just us. — |
In reply to this post by David T Lewis
That seems a little strange though. IIUC vmLatest should be have been built on the CI with a fresh environment. — |
In reply to this post by David T Lewis
this is weird. I remember I cleaned the cache to have a proper build. — |
In reply to this post by David T Lewis
Just recording one observed post-build difference between v2.6.5 and v2.9.1...
And the broken build says...
— |
In reply to this post by David T Lewis
I normalised the LOGD files to remove the version info then diff'd them...
— |
In reply to this post by David T Lewis
harfbuzz commits since 2016-07-12...
— |
In reply to this post by David T Lewis
harfbuzz package has available versions 1.4.8-1, 1.7.4-1, 1.7.6-1. May as well choose the latest. — |
In reply to this post by David T Lewis
Just to isolate the error away from the overarching pharo build, so its easier to iterate on...
— |
In reply to this post by David T Lewis
Confirmed broken upstream — |
In reply to this post by David T Lewis
@estebanlm, Making just this change http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=660afb5ce81ccf3271ec80b6475ec8b16d862a25...
fixes the build
How do you want to handle applying this patch? — |
In reply to this post by David T Lewis
Ran image 71433 with VM built above. All tests pass except:
— |
In reply to this post by David T Lewis
Next step is to modify opensmalltalk-vm/build.win32x86/third-party/Makefile.freetype2 — |
In reply to this post by David T Lewis
@bencoman, I'm really grateful for you doing this. Thank you very much :) — |
In reply to this post by David T Lewis
Likewise. Esteban can I leave it to you to approve the pull request? I don't want to interfere; I'm afraid of breaking things. — |
Free forum by Nabble | Edit this page |