You can view, comment on, or merge this pull request online at:https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/334 Commit Summary
File Changes
Patch Links:
— |
@akgrant43 pushed 2 commits. — |
In reply to this post by David T Lewis
@akgrant43 pushed 2 commits.
— |
In reply to this post by David T Lewis
@akgrant43 pushed 2 commits. — |
In reply to this post by David T Lewis
@akgrant43 pushed 1 commit.
— |
In reply to this post by David T Lewis
@akgrant43 pushed 2 commits.
— |
In reply to this post by David T Lewis
This is annoying... the build fails in a different plugin every time. — |
In reply to this post by David T Lewis
Maybe you should remove -j4 like Ben did. — |
In reply to this post by David T Lewis
@akgrant43 pushed 1 commit.
— |
In reply to this post by David T Lewis
On Wed, 2 Jan 2019 at 18:04, Nicolas Cellier <[hidden email]> wrote:
Actually I'm curious why we've go the -j4? Maybe it was just to speed local builds? There didn't seem to much degradation in build time on Travis when I remove it. IIUC, our Travis build runs on a virtual machine with 2 CPUS shared over five separate Travis jobs running in parallel, so not much is gained by further "make"-level parallelization within each job. So after further observation of build times, maybe -j4 should be removed permanently. Clearly understandable log files seems more important. cheers -ben |
In reply to this post by David T Lewis
Thanks!
+1 — |
In reply to this post by David T Lewis
@akgrant43 pushed 1 commit.
— |
In reply to this post by David T Lewis
Look: From my understanding, this is the only macro that enables recognizing arm on gcc — |
In reply to this post by David T Lewis
Defining ARM32 allows the build to succeed. It will be tonight before I get a chance to tidy this up and try a build for real. — |
In reply to this post by David T Lewis
@akgrant43 pushed 1 commit.
— |
In reply to this post by David T Lewis
Fixed in 1c6552d Note: at least, all travis builds are green — |
In reply to this post by David T Lewis
Closed #334. — |
In reply to this post by Ben Coman
> On 2019-01-02, at 2:22 AM, Ben Coman <[hidden email]> wrote: > > On Wed, 2 Jan 2019 at 18:04, Nicolas Cellier <[hidden email]> wrote: > Maybe you should remove -j4 like Ben did. > > Actually I'm curious why we've go the -j4? Maybe it was just to speed local builds? Maybe it crept in with my raspberry pi build stuff - if makes a big difference when building on the Pi post Pi 2. tim -- tim Rowledge; [hidden email]; http://www.rowledge.org/tim Maybe Computer Science should be in the College of Theology |
In reply to this post by David T Lewis
Hi Nicolas & Ben, Thanks for your assistance with tracking this down and fixing it. Just FYI: I fired up a Raspberry Pi I have lying around and checked that the new VM will at least start and can run LibC>>system:. Cheers, — |
Free forum by Nabble | Edit this page |