[OpenSmalltalk/opensmalltalk-vm] Improved local address support on linux (#458)

 

Do not rely on hardcoded interface names (eth0, wlan0) in sqResolverLocalAddress(void). Use ifa_flags to filter the list instead.
When an interface has no address assigned, just skip it instead of failing the primitive and leaking memory (return without calling freeifaddrs).

On behalf of Levente

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458

Commit Summary

• Improved local address support on linux

File Changes

• M platforms/unix/plugins/SocketPlugin/sqUnixSocket.c (37)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEWZEHDGPGXQRQUPE5T3Q2HJFXA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICPG7WQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEWZEHDGPGXQRQUPE5T3Q2HJFXA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICPG7WQ", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

The changes look good to me, I let a bit of time if someone else want to review.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEW74XJOAMWT7RBV6ZSTQ2HKQTA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHS42TQ#issuecomment-568708430", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEW74XJOAMWT7RBV6ZSTQ2HKQTA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHS42TQ#issuecomment-568708430", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Just a question, is that Linux-specific flags or do they work, eg, on bsd'en?

(cc'ing @ckeen, asking for a tiny test please :) )

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEW7ENN4QWMDFBOMY5I3Q2H7YNA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTE4RY#issuecomment-568741447", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEW7ENN4QWMDFBOMY5I3Q2H7YNA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTE4RY#issuecomment-568741447", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 
On Tue, 24 Dec 2019, Tobias Pape wrote:

> Just a question, is that Linux-specific flags or do they work, eg, on bsd'en?

If you meant the IFF_* flags, then yes, the most popular BSD variants
do have them:
https://github.com/apple/darwin-xnu/blob/master/bsd/net/if.h#L108
https://github.com/openbsd/src/blob/master/sys/net/if.h#L203
https://github.com/freebsd/freebsd/blob/master/sys/net/if.h#L142
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/master/sys/net/if.h#L91
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/net/if.h?rev=1.277&content-type=text/x-cvsweb-markup&only_with_tag=MAIN

Levente

 

Merged #458 into Cog.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEWZTW3Z5DVQYL5RKCTLQ2RRSJA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVPMEWY#event-2908668507", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEWZTW3Z5DVQYL5RKCTLQ2RRSJA5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVPMEWY#event-2908668507", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

hooray!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEW6PCQSOJ6QN3U3FXHLQ2T3Q7A5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHV7UHI#issuecomment-569113117", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/458?email_source=notifications\u0026email_token=AIJPEW6PCQSOJ6QN3U3FXHLQ2T3Q7A5CNFSM4J64RDWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHV7UHI#issuecomment-569113117", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>