[OpenSmalltalk/opensmalltalk-vm] [Improvment][Win64]Cannot save and load image files with a heap whose size is more than 0xff ff ff ff (~4.1GB) (#486)

 

Use || instead of | and use MAXDWORD instead of a new constant

Fix review of #485 and Fix #484

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486

Commit Summary

• Use || instead of | and use MAXDWORD instead of a new constant

File Changes

• M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c (9)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486#pullrequestreview-404431126", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486#pullrequestreview-404431126", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #486 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486#event-3294652223", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/486#event-3294652223", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>