[OpenSmalltalk/opensmalltalk-vm] Minheadless SqueakSSL plugin compilation bug fix (#419)

 

I fixed a mistake in the compilation of the SqueakSSL plugin in the minheadless VM for Mac.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419

Commit Summary

• I fixed a mistake in the compilation of the SqueakSSL plugin in the minheadless VM for Mac.

File Changes

• M cmake/PluginsCommon.cmake (2)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW2OXXHFOWM4LBWF4V3QFXHIZA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGUVYQQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW2OXXHFOWM4LBWF4V3QFXHIZA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGUVYQQ", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Please explain.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW7H6UY2OBRHEF3N7QTQFYVPHA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44AKGA#issuecomment-523765016", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW7H6UY2OBRHEF3N7QTQFYVPHA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44AKGA#issuecomment-523765016", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

On the minheadless VM that is built using cmake, the add_vm_plugin_sources cmake macro requires specifying the the plugin sources explicitly, which is omitting the src/plugins/SqueakSSL/SqueakSSL.c in the compilation of the plugin. By using the other macro (add_vm_plugin_auto), the platform specific files are automatically found with a glob pattern. This is a mistake that I introduced myself. This problem can be reproduced in Pharo using the minheadless vm of this repository on OS X with the following script:

´´´smalltalk
url := 'https://google.com' asZnUrl.
ZnClient new
url: url;
get;
response
´´´

CI errors on travis are not related to this PR.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEWYULNSCU5UZE5PQO63QFZMQLA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44P3JI#issuecomment-523828645", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEWYULNSCU5UZE5PQO63QFZMQLA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44P3JI#issuecomment-523828645", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Ok, but then I don't understand why Mac needs the explicit ${SqueakSSL_Sources}. Apparently, Windows and Unix don't, but also have such specific sources.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW52PU3KARAUH6RDQMLQFZVBNA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44VRGI#issuecomment-523851929", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW52PU3KARAUH6RDQMLQFZVBNA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44VRGI#issuecomment-523851929", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

In the case of the minheadless VM for OS X, we are treating the VM as it were an unix since we are removing all of the platform specific windowing code in this VM variant. For this reason, in the cases where OS X is different than another unix, the plugin code has to be added manually.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEWYBOOCNGNQADJK7CP3QFZYAHA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44WLJA#issuecomment-523855268", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEWYBOOCNGNQADJK7CP3QFZYAHA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44WLJA#issuecomment-523855268", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

In the case of the minheadless VM for OS X, we are treating the VM as it were an unix since we are removing all of the platform specific windowing code in this VM variant. For this reason, in the cases where OS X is different than another unix, the plugin code has to be added manually.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW6BZDNDHBPN4YHMINTQFZYBDA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44WMHA#issuecomment-523855388", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW6BZDNDHBPN4YHMINTQFZYBDA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD44WMHA#issuecomment-523855388", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Side note: I would've liked to see the explanation to be part of the commit message. It'll be rather hard to find this discussion if we need to in the future. But it's not too late: we can still add the info to the merge commit.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW3KX2AAYJGLMFNNTI3QFZ6R7A5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD443V3A#issuecomment-523877100", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEW3KX2AAYJGLMFNNTI3QFZ6R7A5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD443V3A#issuecomment-523877100", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@ronsaldo pushed 1 commit.

• 23c3d10 On the minheadless VM that is built using cmake, the add_vm_plugin_sources cmake macro requires specifying the the plugin sources explicitly, which is omitting the src/plugins/SqueakSSL/SqueakSSL.c in the compilation of the plugin. By using the other macro (add_vm_plugin_auto), the platform specific files are automatically found with a glob pattern. This is a mistake that I introduced myself. This problem can be reproduced in Pharo using the minheadless vm of this repository on OS X with the following script:

—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419/files/75f466efe6bb05b85f75cba327626f7267713158..23c3d109be15eacd53d11b04c071267d2b1529a5?email_source=notifications\u0026email_token=AIJPEWYZTIT4URNVR4B7EGLQF2FYFA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGMYDSNZSG42TIN2QOVZWQIZTHE2TCNJXGM3DSMA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419/files/75f466efe6bb05b85f75cba327626f7267713158..23c3d109be15eacd53d11b04c071267d2b1529a5?email_source=notifications\u0026email_token=AIJPEWYZTIT4URNVR4B7EGLQF2FYFA5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGMYDSNZSG42TIN2QOVZWQIZTHE2TCNJXGM3DSMA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 


> On 2019-08-22, at 5:07 AM, Fabio Niephaus <[hidden email]> wrote:
>
> Side note: I would've liked to see the explanation to be part of the commit message. It'll be rather hard to find this discussion if we need to in the future. But it's not too late: we can still add the info to the merge commit.

Generically we should include actually meaningful comments and explanations to every change, vm or image. But we don't. This makes me sad.


tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Useful random insult:- Runs squares around the competition.

 

Merged #419 into Cog.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEWYZSVXUWFAPV6U22EDQHIWG5A5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTLSZ7FQ#event-2598739862", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/419?email_source=notifications\u0026email_token=AIJPEWYZSVXUWFAPV6U22EDQHIWG5A5CNFSM4IOPKCV2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTLSZ7FQ#event-2598739862", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>