[OpenSmalltalk/opensmalltalk-vm] Nuke mac roman (#460)

 

This will do 2 things:

• 1. expunge the macRoman encoding from event charCode (event at: 3) on unix and OSX
• 2. revert the change that transformed Ctrl+a from ASCII control character code 1 to $a for Squeak VM (no change for PharoVM though).

1. has been done on windows VM, and need to be done on over OSes
2. is essentially a fix for #456

I have reverted deeper changes aimed at using a platform independent keycode in (event at: 3).
This will be for another time and another branch.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460

Commit Summary

• Convert charCode to latin1 encoding rather than macRoman on iOS.
• Let default sqTextEncoding be latin1 instead of macRoman on unix VM
• Nuke recode entirely from unix X11
• Directly use the symbolic (=virtual) key code, that's what we want.
• Use translateCode primarily for translating symbolic X11 keysym to OSVM keycode
• Remove ux2st & st2ux deadcode
• Revert "Use translateCode primarily for translating symbolic X11 keysym to OSVM keycode"
• Revert "Directly use the symbolic (=virtual) key code, that's what we want."
• Let unix Squeak VM generate ASCII control characters like it always did

File Changes

• M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (6)
• M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (10)
• M platforms/unix/vm-display-X11/sqUnixX11.c (120)
• M platforms/unix/vm/sqUnixCharConv.c (4)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460?email_source=notifications\u0026email_token=AIJPEW2KRC5CLNAY6AONU3DQ2RQNLA5CNFSM4J7JH5HKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICVP4DA", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460?email_source=notifications\u0026email_token=AIJPEW2KRC5CLNAY6AONU3DQ2RQNLA5CNFSM4J7JH5HKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICVP4DA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #460 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460?email_source=notifications\u0026email_token=AIJPEW4LDE5YZ4Z7NWOITVDQ2RRQHA5CNFSM4J7JH5HKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVPL55A#event-2908667636", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/460?email_source=notifications\u0026email_token=AIJPEW4LDE5YZ4Z7NWOITVDQ2RRQHA5CNFSM4J7JH5HKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVVPL55A#event-2908667636", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>