[OpenSmalltalk/opensmalltalk-vm] OS X custom URL scheme and document open event injection fixup (#553)

 

These change fixup the events for handling custom url schemes, and the support for opening document types registered in the plist that are received as events before the image is even opened by the VM. These event are injected as drop event into the image for further processing.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553

Commit Summary

• I these changes perform minor refactoring on the place where the dragItems list is store with the purpose of handling url schema and document open events that are raised before the application is even started.

File Changes

• M platforms/iOS/vm/OSX/SqueakOSXAppDelegate.h (6)
• M platforms/iOS/vm/OSX/SqueakOSXAppDelegate.m (73)
• M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
• M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (21)
• M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (1)
• M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (30)
• M platforms/iOS/vm/OSX/sqSqueakOSXDropAPI.m (8)
• M platforms/iOS/vm/OSX/sqSqueakOSXHeadlessView.h (1)
• M platforms/iOS/vm/OSX/sqSqueakOSXHeadlessView.m (3)
• M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.h (1)
• M platforms/iOS/vm/OSX/sqSqueakOSXMetalView.m (29)
• M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (1)
• M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (30)
• M platforms/iOS/vm/OSX/sqSqueakOSXView.h (1)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

@eliotmiranda approved this pull request.

Best to get this in and fix any problems in situ. I want this :-)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553#pullrequestreview-606484543", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553#pullrequestreview-606484543", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Merged #553 into Cog.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553#event-4422276894", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/553#event-4422276894", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>