[OpenSmalltalk/opensmalltalk-vm] Remove macRoman translation of keyboard keyValue in Win32 VM (#401)

 

There is code that transforms the presumably latin-1 key value into approximately MacRoman encoding in platforms/win32/vm/sqWin32Window.c
I let the archeologists debate if this code dates from Jurassic period or more distant paleozoic era, all I know is that we pay for what we don't buy...

Thus I propose to entirely remove that piece of code and disentangle a bit the spaghetti keyboard handling.

We indeed do not need this extra level of complexity anymore, images do not use macRoman encoding for a long time

On the contrary, images have to undo the translation by sending macToSqueak message in various subclasses of KeyboardInputInterpreter.

For the transition period, old images running on new VMs, or new images running on old VMs, might encounter a few hickups while interpreting non ASCII characters in case of exotic KeyboardInputInterpreter. That won't be the case of main UTF32InputInterpreter since it mostly uses the utf32 code passed through eventBuffer sixth position rather than keyValue passed thru eventBuffer third, except for some CTRL+key for which the keyValue is more-than-often < 128, and thus unaffcted by the proposed change.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEW4WLUEFXLYB75PFPBTPZ6IENA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYZMZMQ", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEW4WLUEFXLYB75PFPBTPZ6IENA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYZMZMQ", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

> On Jun 11, 2019, at 5:04 AM, Nicolas Cellier <[hidden email]> wrote:
>
> There is code that transforms the presumably latin-1 key value into approximately MacRoman encoding in platforms/win32/vm/sqWin32Window.c
> I let the archeologists debate if this code dates from Jurassic period or more distant paleozoic era, all I know is that we pay for what we don't buy...
>
> Thus I propose to entirely remove that piece of code and disentangle a bit the spaghetti keyboard handling.
>
> We indeed do not need this extra level of complexity anymore, images do not use macRoman encoding for a long time
>
> On the contrary, images have to undo the translation by sending macToSqueak message in various subclasses of KeyboardInputInterpreter.
>
> For the transition period, old images running on new VMs, or new images running on old VMs, might encounter a few hickups while interpreting non ASCII characters in case of exotic KeyboardInputInterpreter. That won't be the case of main UTF32InputInterpreter since it mostly uses the utf32 code passed through eventBuffer sixth position rather than keyValue passed thru eventBuffer third, except for some CTRL+key for which the keyValue is more-than-often < 128, and thus unaffcted by the proposed change.
>

+1

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEWYDMDGNZ7VWKD7AQF3P2ENBRA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXQ57EA#issuecomment-501342096", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEWYDMDGNZ7VWKD7AQF3P2ENBRA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXQ57EA#issuecomment-501342096", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Closed #401.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEW2OJF4SIL7FTRUA76TQR7TUDA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUTWRCSY#event-2766999883", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEW2OJF4SIL7FTRUA76TQR7TUDA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUTWRCSY#event-2766999883", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>

 

Work has been marged in 40c0390

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEWYSGOAC47ZVVMTOPG3QR7TUDA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC6UPFI#issuecomment-549275541", "url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/401?email_source=notifications\u0026email_token=AIJPEWYSGOAC47ZVVMTOPG3QR7TUDA5CNFSM4HW5SSY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC6UPFI#issuecomment-549275541", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>